All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v3 8/9] igc: Add support for XDP_TX action
Date: Thu, 05 Nov 2020 14:03:31 -0800	[thread overview]
Message-ID: <87k0uza2bw.fsf@intel.com> (raw)
In-Reply-To: <160444685523.10323.13712174376571831748@anemani-mobl2.amr.corp.intel.com>

Hi,

Andre Guedes <andre.guedes@intel.com> writes:

> Quoting Maciej Fijalkowski (2020-11-02 10:26:59)
>> > +static struct igc_ring *igc_xdp_get_tx_ring(struct igc_adapter *adapter,
>> > +                                         int cpu)
>> > +{
>> > +     int index = cpu;
>> > +
>> > +     if (index >= adapter->num_tx_queues)
>> > +             index = index % adapter->num_tx_queues;
>> 
>> I'm not sure why you don't want to take the suggestion for getting rid of
>> modulo op. I won't insist anymore ;)
>
> As I mentioned in the previous comment, I was just following the same
> approach from igb. Since I'll submit a v4 already, I'll do that as
> well.

Another idea is to use iter_div_u64_rem() as the expected difference
between divident and divisor should be small.


Cheers,
-- 
Vinicius

  reply	other threads:[~2020-11-05 22:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30 21:03 [Intel-wired-lan] [PATCH v3 0/9] igc: Add XDP support Andre Guedes
2020-10-30 21:03 ` [Intel-wired-lan] [PATCH v3 1/9] igc: Fix igc_ptp_rx_pktstamp() Andre Guedes
2020-11-02 17:56   ` Maciej Fijalkowski
2020-11-03 23:39     ` Andre Guedes
2020-11-04 22:26       ` Maciej Fijalkowski
2020-11-06  1:01         ` Guedes, Andre
2020-10-30 21:03 ` [Intel-wired-lan] [PATCH v3 2/9] igc: Remove unused argument from igc_tx_cmd_type() Andre Guedes
2020-10-30 21:03 ` [Intel-wired-lan] [PATCH v3 3/9] igc: Introduce igc_rx_buffer_flip() helper Andre Guedes
2020-10-30 21:03 ` [Intel-wired-lan] [PATCH v3 4/9] igc: Introduce igc_get_rx_frame_truesize() helper Andre Guedes
2020-10-30 21:03 ` [Intel-wired-lan] [PATCH v3 5/9] igc: Refactor rx timestamp handling Andre Guedes
2020-10-30 21:03 ` [Intel-wired-lan] [PATCH v3 6/9] igc: Add set/clear large buffer helpers Andre Guedes
2020-10-30 21:03 ` [Intel-wired-lan] [PATCH v3 7/9] igc: Add initial XDP support Andre Guedes
2020-11-02 18:07   ` Maciej Fijalkowski
2020-11-03 23:40     ` Andre Guedes
2020-11-04 21:56       ` Maciej Fijalkowski
2020-10-30 21:03 ` [Intel-wired-lan] [PATCH v3 8/9] igc: Add support for XDP_TX action Andre Guedes
2020-11-02 18:26   ` Maciej Fijalkowski
2020-11-03 23:40     ` Andre Guedes
2020-11-05 22:03       ` Vinicius Costa Gomes [this message]
2020-10-30 21:03 ` [Intel-wired-lan] [PATCH v3 9/9] igc: Add support for XDP_REDIRECT action Andre Guedes
2020-11-02 18:30   ` Maciej Fijalkowski
2020-11-03 23:41     ` Andre Guedes
2020-11-02 18:31 ` [Intel-wired-lan] [PATCH v3 0/9] igc: Add XDP support Maciej Fijalkowski
2020-11-03 23:41   ` Andre Guedes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0uza2bw.fsf@intel.com \
    --to=vinicius.gomes@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.