From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com,
qemu-block@nongnu.org, qemu-devel@nongnu.org, rjones@redhat.com,
stefanha@redhat.com
Subject: Re: [PATCH v5 00/12] Exposing backing-chain allocation over NBD
Date: Mon, 26 Oct 2020 15:54:07 +0100 [thread overview]
Message-ID: <87k0vd3unk.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <e3c7c962-93ef-15a0-5fba-ecfcad6241b0@redhat.com> (Eric Blake's message of "Fri, 23 Oct 2020 13:44:55 -0500")
Eric Blake <eblake@redhat.com> writes:
> On 10/23/20 1:36 PM, Eric Blake wrote:
>> v4 was here:
>> https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg02708.html
>>
>> Since then:
>> - rebase to master
>> - patches 1, 2, and 12 are new based on Vladimir's observation of QAPI_LIST_ADD
>> - patches 10-11 are new based on prior discussion on exposing actual
>> depth in addition to a tri-state encoding
>> - patch 3 has a nasty bug fixed that was causing iotest failures
>> - patch 6 updated to take advantage of patch 2
>> - other minor tweaks based on review comments
>>
>> 001/12:[down] 'qapi: Move GenericList to qapi/util.h'
>> 002/12:[down] 'qapi: Make QAPI_LIST_ADD() public'
>> 003/12:[0002] [FC] 'nbd: Utilize QAPI_CLONE for type conversion'
>> 004/12:[0010] [FC] 'nbd: Add new qemu:allocation-depth metadata context'
>> 005/12:[----] [--] 'nbd: Add 'qemu-nbd -A' to expose allocation depth'
>> 006/12:[0014] [FC] 'nbd: Update qapi to support exporting multiple bitmaps'
>> 007/12:[----] [--] 'nbd: Simplify qemu bitmap context name'
>> 008/12:[----] [--] 'nbd: Refactor counting of metadata contexts'
>> 009/12:[0017] [FC] 'nbd: Allow export of multiple bitmaps for one device'
>> 010/12:[down] 'block: Return depth level during bdrv_is_allocated_above'
>> 011/12:[down] 'nbd: Expose actual depth in qemu:allocation-depth'
>> 012/12:[down] 'qapi: Use QAPI_LIST_ADD() where possible'
>
> and I meant to add:
>
> Also available at:
> https://repo.or.cz/qemu/ericb.git/shortlog/refs/tags/nbd-alloc-depth-v5
>
> patch 12 is the largest; it may be worth splitting that by maintainer,
I wouldn't split. The various parts will trickle in separately, and you
may well end up holding leftovers.
> or even pushing it off post-5.2. Logically, it can go in anywhere after
> patch 2, but by putting it last, I'm hoping to send a pull request for
> soft freeze next week for patches 1-11 for sure, and only include 12 if
> we get enough positive review in time. I did not try to see if
> Coccinelle could make the work done in patch 12 more automatable.
PATCH 12 serves a useful purpose even if we can't get it in right away:
it convinces me that making QAPI_LIST_ADD() public makes sense.
prev parent reply other threads:[~2020-10-26 14:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 18:36 [PATCH v5 00/12] Exposing backing-chain allocation over NBD Eric Blake
2020-10-23 18:36 ` [PATCH v5 01/12] qapi: Move GenericList to qapi/util.h Eric Blake
2020-10-24 9:06 ` Vladimir Sementsov-Ogievskiy
2020-10-26 14:18 ` Markus Armbruster
2020-10-26 14:22 ` Eric Blake
2020-10-23 18:36 ` [PATCH v5 02/12] qapi: Make QAPI_LIST_ADD() public Eric Blake
2020-10-24 9:10 ` Vladimir Sementsov-Ogievskiy
2020-10-26 14:25 ` Markus Armbruster
2020-10-26 14:37 ` Eric Blake
2020-10-26 14:38 ` Eric Blake
2020-10-23 18:36 ` [PATCH v5 03/12] nbd: Utilize QAPI_CLONE for type conversion Eric Blake
2020-10-24 9:17 ` Vladimir Sementsov-Ogievskiy
2020-10-26 14:41 ` Markus Armbruster
2020-10-23 18:36 ` [PATCH v5 04/12] nbd: Add new qemu:allocation-depth metadata context Eric Blake
2020-10-23 18:36 ` [PATCH v5 05/12] nbd: Add 'qemu-nbd -A' to expose allocation depth Eric Blake
2020-10-23 18:36 ` [PATCH v5 06/12] nbd: Update qapi to support exporting multiple bitmaps Eric Blake
2020-10-26 10:50 ` Peter Krempa
2020-10-26 13:06 ` Eric Blake
2020-10-23 18:36 ` [PATCH v5 07/12] nbd: Simplify qemu bitmap context name Eric Blake
2020-10-23 18:36 ` [PATCH v5 08/12] nbd: Refactor counting of metadata contexts Eric Blake
2020-10-23 18:36 ` [PATCH v5 09/12] nbd: Allow export of multiple bitmaps for one device Eric Blake
2020-10-23 18:36 ` [PATCH v5 10/12] block: Return depth level during bdrv_is_allocated_above Eric Blake
2020-10-24 9:49 ` Vladimir Sementsov-Ogievskiy
2020-10-26 12:26 ` Vladimir Sementsov-Ogievskiy
2020-10-23 18:36 ` [PATCH v5 11/12] nbd: Expose actual depth in qemu:allocation-depth Eric Blake
2020-10-24 9:59 ` Vladimir Sementsov-Ogievskiy
2020-10-26 12:31 ` Eric Blake
2020-10-23 18:36 ` [PATCH v5 12/12] qapi: Use QAPI_LIST_ADD() where possible Eric Blake
2020-10-23 20:23 ` Eric Blake
2020-10-23 20:23 ` Eric Blake
2020-10-23 18:44 ` [PATCH v5 00/12] Exposing backing-chain allocation over NBD Eric Blake
2020-10-26 14:54 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0vd3unk.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.