From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 346BAC4346E for ; Thu, 24 Sep 2020 23:19:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDACD2396F for ; Thu, 24 Sep 2020 23:19:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SOEtmzh0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726604AbgIXXT2 (ORCPT ); Thu, 24 Sep 2020 19:19:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:32423 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726205AbgIXXT2 (ORCPT ); Thu, 24 Sep 2020 19:19:28 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600989566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DNPW4CacsR/3OUSIFotWqGTYpLOGz4JMPt8HrL5jRII=; b=SOEtmzh0vQjRxkhqhusOFsIadbbp/aNsggOYN2vumfJ0zPDjvJEdGy7nb3h85bH8BBOb4y b0F0Z890AjtYEzUGuuS1fy3pOUVNR+BWRCgxuCzGJ4hwPL2+zqWaYRWZekt7FLgkPw35gc yhwQh5rnSKIN/VYK8WGieBYApEWGrbc= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-496-mcYk6qTmMti5BO7-N3itPQ-1; Thu, 24 Sep 2020 19:19:24 -0400 X-MC-Unique: mcYk6qTmMti5BO7-N3itPQ-1 Received: by mail-ej1-f70.google.com with SMTP id e13so307531ejk.1 for ; Thu, 24 Sep 2020 16:19:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=DNPW4CacsR/3OUSIFotWqGTYpLOGz4JMPt8HrL5jRII=; b=rqQ9agpLf6/E2YI5gh95sRn4ehirx6N7kY4R/k6h7QsoxdY77C5f+xVrwRKIi832Yq D4GUkiKz3mIJIKomrvpQCfbHFeffqi4M029xRS7g/mJ5KzGEuJGA9149QNdKoYL9PBPA t0G5YiiwI5HXGfZUCOFZOKAs1FmLbINn9kWwiYgASYjNG8VeNNu3TQdPw08RM6W7JtMf 8FWLPU91K8VKSoV0bdHhN/kjNGWm/SnmsVvzDNhc7HBAGhMZtn58Tw0DISlgBIzRhluY v1t5vfnQwwy7S1RSgzPwLdLJXR7nZGkM5AMTdsZq0iPFo4QIB2bP+kgRP9Gd2lyI5H5c UtdA== X-Gm-Message-State: AOAM531n/51A+r1VVkPFZbUkjCH7jY9RGIXj1ISSQIQgfjIXS2tP03Ug nc6B3rYrElhwerD2G0E/a29L2S6XfmZyjk2KJkrqidehhBtsukAv251GG1MKojbVIw8Fb5WQHBw nXIyw/6CaSJbv X-Received: by 2002:a17:906:d7a2:: with SMTP id pk2mr930376ejb.149.1600989563651; Thu, 24 Sep 2020 16:19:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRPzLYZqA3W0RqOUAbJgzs97HZF8iRKMZEHFdm4unyfyEgpyNZoC6GwLfgZLdmBmaJt6Q8QA== X-Received: by 2002:a17:906:d7a2:: with SMTP id pk2mr930363ejb.149.1600989563459; Thu, 24 Sep 2020 16:19:23 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id l26sm589756ejr.78.2020.09.24.16.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 16:19:22 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 6FA91183A90; Fri, 25 Sep 2020 01:19:22 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Andrii Nakryiko , Alexei Starovoitov Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , Jiri Olsa , Eelco Chaudron , KP Singh , Networking , bpf Subject: Re: [PATCH bpf-next v8 11/11] selftests: Remove fmod_ret from benchmarks and test_overhead In-Reply-To: References: <160079991372.8301.10648588027560707258.stgit@toke.dk> <160079992560.8301.11225602391403157558.stgit@toke.dk> <20200924010811.kwrkzdzh6za3w3fz@ast-mbp.dhcp.thefacebook.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 25 Sep 2020 01:19:22 +0200 Message-ID: <87k0wibw5h.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Andrii Nakryiko writes: > On Wed, Sep 23, 2020 at 6:08 PM Alexei Starovoitov > wrote: >> >> On Tue, Sep 22, 2020 at 08:38:45PM +0200, Toke H=C3=B8iland-J=C3=B8rgens= en wrote: >> > -const struct bench bench_trig_fmodret =3D { >> > - .name =3D "trig-fmodret", >> > - .validate =3D trigger_validate, >> > - .setup =3D trigger_fmodret_setup, >> > - .producer_thread =3D trigger_producer, >> > - .consumer_thread =3D trigger_consumer, >> > - .measure =3D trigger_measure, >> > - .report_progress =3D hits_drops_report_progress, >> > - .report_final =3D hits_drops_report_final, >> > -}; >> > diff --git a/tools/testing/selftests/bpf/progs/trigger_bench.c b/tools= /testing/selftests/bpf/progs/trigger_bench.c >> > index 9a4d09590b3d..1af23ac0c37c 100644 >> > --- a/tools/testing/selftests/bpf/progs/trigger_bench.c >> > +++ b/tools/testing/selftests/bpf/progs/trigger_bench.c >> > @@ -45,10 +45,3 @@ int bench_trigger_fentry_sleep(void *ctx) >> > __sync_add_and_fetch(&hits, 1); >> > return 0; >> > } >> > - >> > -SEC("fmod_ret/__x64_sys_getpgid") >> > -int bench_trigger_fmodret(void *ctx) >> > -{ >> > - __sync_add_and_fetch(&hits, 1); >> > - return -22; >> > -} >> >> why are you removing this? There is no problem here. >> All syscalls are error-injectable. >> I'm surprised Andrii acked this :( > > Andrii didn't know that all syscalls are error-injectable, thanks for > catching :) after fmod_ret/__set_task_comm I just assumed that I've > been abusing fmod_ret all this time... I didn't know that either. Shall I just drop your ACK from the next version so you can take another look? -Toke