From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:5042:0:0:0:0:0 with SMTP id a2csp3087020lfm; Mon, 22 Jun 2020 04:23:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypJUQeH94CUT5gCfhXnsH1QfBSNq5n7wDjyguuJ57oz5HycLDRJX58kZ58nIOv+XuO/elJ X-Received: by 2002:a25:e083:: with SMTP id x125mr28270256ybg.338.1592825004269; Mon, 22 Jun 2020 04:23:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592825004; cv=none; d=google.com; s=arc-20160816; b=tOpzX3vICBTJW1/H1lHs4LjnMcc1YVxX1EWRkEN2BFBi8zdgMCqL9G1jC1XIGi+wFu ScMfwt5hYpct32jxAp1zuvfOAKyF8I5ue7ULGAD2bLeh7qrIdynIq0metoIC9xN4rvJn NHfE9YY+6G1SJfRz1TtQi6PVFSuoJaF30vTmQ7hUNEhz2W7L2g7W6r7hiVHnd/hPf/91 gBpHftFJzZkQrcOtYSu2NObbXrN7+761vYLt5TF5uv4ADSZbvvBPz45n058RUud1gTVF Ln54t3Z9jbvmVIiEFWgkIywIoqvZFdYp6L8lN7aEl1lOawiOENawTXpzYgTLy/gMg5z2 HZRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:user-agent :message-id:in-reply-to:date:references:subject:to:from :dkim-signature; bh=TjN9niWCYIS4eow/uuCs74h2CERnYyO6Wpq+y+Da3P0=; b=PxwtdT+kQEjRgyGpJB2Ss8kRW6vxaadqxyylo+fBz0UsuIzKBmKChaOZ2B/385ruyT DSdGESA6umaMTDl1eV9QKBu/EuGn9E64UJVxIFMkwduBRDXsOIcoOnGkJl0nythbj1qp 52M6OCHjAQc/rqb5zn0D3esCC8FT7CSK+v/1aacNS4oit3j3js5Wv62SU00pqcBSggOF s/H+S2CNI15E3k9QWVCl1x6D1RuWIQhf2cl3e4GdK8Qf8bH2K7VbXZrgEBnYRIFujczV Cv01BNb/fAYQIM0iDZN33SvOP3fthzcwuN9ESDaRPCN8NEHraCFlE1HVgI9q9UJlUrwF WE4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=JDSh6A3q; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o3si13904952ybc.337.2020.06.22.04.23.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jun 2020 04:23:24 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=JDSh6A3q; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:33668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnKXr-0004Xa-LK for alex.bennee@linaro.org; Mon, 22 Jun 2020 07:23:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnKXX-0004XP-CG for qemu-arm@nongnu.org; Mon, 22 Jun 2020 07:23:03 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:48453 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jnKXT-0007Eq-H8 for qemu-arm@nongnu.org; Mon, 22 Jun 2020 07:23:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592824977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TjN9niWCYIS4eow/uuCs74h2CERnYyO6Wpq+y+Da3P0=; b=JDSh6A3q2dRPtlsExH/jqHjbmYHQDTShSqHvnvChmbGva1CGEBNvWpiha/+M4Ulg4ON8IG sg8pW+6Ey4/VerbovChhBLim6r+m08aNnMHFkv46C0W7L+eN9Y1Ist4nFfzWTc/UlChvO1 XDLklXfKh4oih2N5VkRT0SUAd1K1sLg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-wSm1QWw6MGaKtkYbtY1_xQ-1; Mon, 22 Jun 2020 07:22:55 -0400 X-MC-Unique: wSm1QWw6MGaKtkYbtY1_xQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7998C8005AD; Mon, 22 Jun 2020 11:22:54 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-121.ams2.redhat.com [10.36.112.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CA0D31A8F5; Mon, 22 Jun 2020 11:22:47 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 4F733113846D; Mon, 22 Jun 2020 13:22:46 +0200 (CEST) From: Markus Armbruster To: Eric Auger Subject: Re: [PATCH v3 1/5] qdev: Introduce DEFINE_PROP_RESERVED_REGION References: <20200611151209.22547-1-eric.auger@redhat.com> <20200611151209.22547-2-eric.auger@redhat.com> Date: Mon, 22 Jun 2020 13:22:46 +0200 In-Reply-To: <20200611151209.22547-2-eric.auger@redhat.com> (Eric Auger's message of "Thu, 11 Jun 2020 17:12:05 +0200") Message-ID: <87k0zzz6nt.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=205.139.110.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/22 01:27:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, mst@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com, jean-philippe@linaro.org, qemu-arm@nongnu.org, pbonzini@redhat.com, bbhushan2@marvell.com, eric.auger.pro@gmail.com Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: Xh+wni0st9QN Eric Auger writes: > Introduce a new property defining a reserved region: > , , . > > This will be used to encode reserved IOVA regions. > > For instance, in virtio-iommu use case, reserved IOVA regions > will be passed by the machine code to the virtio-iommu-pci > device (an array of those). The type of the reserved region > will match the virtio_iommu_probe_resv_mem subtype value: > - VIRTIO_IOMMU_RESV_MEM_T_RESERVED (0) > - VIRTIO_IOMMU_RESV_MEM_T_MSI (1) > > on PC/Q35 machine, this will be used to inform the > virtio-iommu-pci device it should bypass the MSI region. > The reserved region will be: 0xfee00000, 0xfeefffff, 1. > > On ARM, we can declare the ITS MSI doorbell as an MSI > region to prevent MSIs from being mapped on guest side. > > Signed-off-by: Eric Auger > > --- > > v11 -> v12: > - rename into DEFINE_PROP_RESERVED_REGION > - do not use g_strsplit anymore, use endptr instead > - remove 0x references > --- > include/exec/memory.h | 6 +++ > include/hw/qdev-properties.h | 3 ++ > include/qemu/typedefs.h | 1 + > hw/core/qdev-properties.c | 89 ++++++++++++++++++++++++++++++++++++ > 4 files changed, 99 insertions(+) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 3e00cdbbfa..3ee8224fa7 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -57,6 +57,12 @@ struct MemoryRegionMmio { > CPUWriteMemoryFunc *write[3]; > }; > > +struct ReservedRegion { > + hwaddr low; > + hwaddr high; > + unsigned int type; > +}; > + > typedef struct IOMMUTLBEntry IOMMUTLBEntry; > > /* See address_space_translate: bit 0 is read, bit 1 is write. */ > diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h > index f161604fb6..03bf850a7e 100644 > --- a/include/hw/qdev-properties.h > +++ b/include/hw/qdev-properties.h > @@ -19,6 +19,7 @@ extern const PropertyInfo qdev_prop_string; > extern const PropertyInfo qdev_prop_chr; > extern const PropertyInfo qdev_prop_tpm; > extern const PropertyInfo qdev_prop_macaddr; > +extern const PropertyInfo qdev_prop_reserved_region; > extern const PropertyInfo qdev_prop_on_off_auto; > extern const PropertyInfo qdev_prop_multifd_compression; > extern const PropertyInfo qdev_prop_losttickpolicy; > @@ -183,6 +184,8 @@ extern const PropertyInfo qdev_prop_pcie_link_width; > DEFINE_PROP(_n, _s, _f, qdev_prop_drive_iothread, BlockBackend *) > #define DEFINE_PROP_MACADDR(_n, _s, _f) \ > DEFINE_PROP(_n, _s, _f, qdev_prop_macaddr, MACAddr) > +#define DEFINE_PROP_RESERVED_REGION(_n, _s, _f) \ > + DEFINE_PROP(_n, _s, _f, qdev_prop_reserved_region, ReservedRegion) > #define DEFINE_PROP_ON_OFF_AUTO(_n, _s, _f, _d) \ > DEFINE_PROP_SIGNED(_n, _s, _f, _d, qdev_prop_on_off_auto, OnOffAuto) > #define DEFINE_PROP_MULTIFD_COMPRESSION(_n, _s, _f, _d) \ > diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h > index ecf3cde26c..85c4f891f4 100644 > --- a/include/qemu/typedefs.h > +++ b/include/qemu/typedefs.h > @@ -59,6 +59,7 @@ typedef struct ISABus ISABus; > typedef struct ISADevice ISADevice; > typedef struct IsaDma IsaDma; > typedef struct MACAddr MACAddr; > +typedef struct ReservedRegion ReservedRegion; > typedef struct MachineClass MachineClass; > typedef struct MachineState MachineState; > typedef struct MemoryListener MemoryListener; > diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c > index cc924815da..15b84adbee 100644 > --- a/hw/core/qdev-properties.c > +++ b/hw/core/qdev-properties.c > @@ -14,6 +14,7 @@ > #include "qapi/visitor.h" > #include "chardev/char.h" > #include "qemu/uuid.h" > +#include "qemu/cutils.h" > > void qdev_prop_set_after_realize(DeviceState *dev, const char *name, > Error **errp) > @@ -577,6 +578,94 @@ const PropertyInfo qdev_prop_macaddr = { > .set = set_mac, > }; > > +/* --- Reserved Region --- */ > + > +/* > + * accepted syntax version: > + * ,, > + * where low/high addresses are uint64_t in hexadecimal > + * and type is an unsigned integer in decimal > + */ > +static void get_reserved_region(Object *obj, Visitor *v, const char *name, > + void *opaque, Error **errp) > +{ > + DeviceState *dev = DEVICE(obj); > + Property *prop = opaque; > + ReservedRegion *rr = qdev_get_prop_ptr(dev, prop); > + char buffer[64]; > + char *p = buffer; > + > + snprintf(buffer, sizeof(buffer), "0x%"PRIx64",0x%"PRIx64",%u", > + rr->low, rr->high, rr->type); Matches existing practice in other getters. Nevertheless, I'd suggest something like n = snprintf(buffer, sizeof(buffer), ...); assert(n < sizeof(buffer); > + > + visit_type_str(v, name, &p, errp); > +} > + > +static void set_reserved_region(Object *obj, Visitor *v, const char *name, > + void *opaque, Error **errp) > +{ > + DeviceState *dev = DEVICE(obj); > + Property *prop = opaque; > + ReservedRegion *rr = qdev_get_prop_ptr(dev, prop); > + Error *local_err = NULL; > + const char *endptr; > + char *str; > + int ret; > + > + if (dev->realized) { > + qdev_prop_set_after_realize(dev, name, errp); > + return; > + } > + > + visit_type_str(v, name, &str, &local_err); > + if (local_err) { > + error_propagate(errp, local_err); > + return; > + } > + > + ret = qemu_strtou64(str, &endptr, 16, &rr->low); > + if (ret) { > + error_setg(errp, "Failed to decode reserved region low addr"); > + error_append_hint(errp, > + "should be an address in hexadecimal\n"); Comes out like this: qemu-system-x86_64: -device ...: Failed to decode reserved region low addr should be an address in hexadecimal I'd capitalize the other way, to get qemu-system-x86_64: -device ...: failed to decode reserved region low addr Should be an address in hexadecimal Note: output is made up; I failed at figuring out how to use the new property. An example in PATCH 4's commit message might help. Since the error message fails to mention @name, the user is left guessing unless "-device ..." contains just one reserved region parameter. What about something like this: error_setg(errp, "start address of reserved region '%s'" " must be a hexadecimal integer", name); No need to mess around with error_append_hint() then. Same for the other error messages. > + goto out; > + } > + if (*endptr != ',') { > + goto separator_error; > + } > + > + ret = qemu_strtou64(endptr + 1, &endptr, 16, &rr->high); > + if (ret) { > + error_setg(errp, "Failed to decode reserved region high addr"); > + error_append_hint(errp, > + "should be an address in hexadecimal\n"); > + goto out; > + } > + if (*endptr != ',') { > + goto separator_error; > + } > + > + ret = qemu_strtoui(endptr + 1, &endptr, 10, &rr->type); > + if (ret) { > + error_setg(errp, "Failed to decode reserved region type"); > + error_append_hint(errp, "should be an unsigned integer in decimal\n"); > + } I dimly remember discussing the wisdom of numeric type here, dig, dig, ..., aha: Subject: Re: [PATCH for-5.0 v11 12/20] qapi: Introduce DEFINE_PROP_INTERVAL Date: Fri, 13 Dec 2019 11:03:02 +0100 Message-ID: <87y2vg4k6h.fsf@dusky.pond.sub.org> >> So the "label" part of ",,label" is a number? > yes it is. >> >> Is a number appropriate for your use case, or would an enum be better? > I think a number is OK. There might be other types of reserved regions > in the future. Also if we want to allow somebody else to reuse that > property in another context, I would rather leave it open? I'd prioritize the user interface over possible reuse (which might never happen). Mind, I'm not telling you using numbers is a bad user interface. In general, enums are nicer, but I don't know enough about this particular case. > + goto out; > + > +separator_error: > + error_setg(errp, "reserved region fields must be separated with commas"); I'm not sure de-duplicating this error message is worth the extra goto. > +out: > + g_free(str); > + return; > +} > + > +const PropertyInfo qdev_prop_reserved_region = { > + .name = "reserved_region", > + .description = "Reserved Region, example: 0xFEE00000,0xFEEFFFFF,0", > + .get = get_reserved_region, > + .set = set_reserved_region, > +}; > + > /* --- on/off/auto --- */ > > const PropertyInfo qdev_prop_on_off_auto = { Can't find anything that's actually wrong, so Reviewed-by: Markus Armbruster