From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jb3An-0000pc-Va for mharc-grub-devel@gnu.org; Tue, 19 May 2020 10:24:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jb3Am-0000nB-LN for grub-devel@gnu.org; Tue, 19 May 2020 10:24:48 -0400 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:45284) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jb3Al-0004Tb-2M for grub-devel@gnu.org; Tue, 19 May 2020 10:24:48 -0400 Received: by mail-pg1-x543.google.com with SMTP id r22so6459744pga.12 for ; Tue, 19 May 2020 07:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=dVcMqF0hnMRV5GKKbJohm1Nan3lkcYhhtN2s1Zd7+VY=; b=i7KettXr74cGiIN/jLpILYC9qWCzp7UqhDbmoSUS37MIav9mIj61EPTcKzjjvPoard e0hGYRPa2Rdfeb/w3eSIbgFh76CQBe6REPCVhFc4huYMY/IJfKhS63B8kZxv6X1i0+vc w6KGSNyt0Rm6mEkxpm4eb4Mbz3/oFdvEJxB5U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=dVcMqF0hnMRV5GKKbJohm1Nan3lkcYhhtN2s1Zd7+VY=; b=Dsy86InxlpV/ssT9vEzqzWZtZCWPj/Rdu7nbiYHkMuVU4TBYzwCm5OTPPVRzFZkFNx +XyxUGvah8d+fW3tX+vfrP6T3z2zKWkCz2sNMvHFK0M2i/XBX2UJjLozCxpHhywycJsd s2sr7d5SYw7s9FzR+WPP4TW5wfDKdw8KirMcJB2JKvOCusbwqbffrPz9lg4Gqq+Q7x74 F+YTSlCyDjO3yAXbhC2FT1jPlDCht6u2sXVQigycmxLLIIODw5p5INIIq4V8fnScFNbD rSgnVr+zr2ViQo8u2PCbnTZLckiatoJD/czh+2xuEvXOYGRwmaA4cebqWnpknV3zwYsu TeXA== X-Gm-Message-State: AOAM532WkczpCXOWZFGpSlKmyHRlvX4dpnckXMjxPA+m3zlgJ1UF2jsk J7AQad0bBAKztO9owWkttS8OcQ== X-Google-Smtp-Source: ABdhPJxZxYbRoX8xP4j6VFbd6mpx9GpBbSdNeub7GRexEaEEn4RoY98+NeRAMatT1mzEnfTOF8TAyQ== X-Received: by 2002:a63:7f48:: with SMTP id p8mr6554602pgn.440.1589898285517; Tue, 19 May 2020 07:24:45 -0700 (PDT) Received: from localhost (2001-44b8-111e-5c00-b5ed-d3ff-25d3-7e68.static.ipv6.internode.on.net. [2001:44b8:111e:5c00:b5ed:d3ff:25d3:7e68]) by smtp.gmail.com with ESMTPSA id 196sm10981906pfx.105.2020.05.19.07.24.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 07:24:44 -0700 (PDT) From: Daniel Axtens To: Javier Martinez Canillas , Daniel Kiper Cc: grub-devel@gnu.org, eschwartz@archlinux.org, floppym@gentoo.org, glaubitz@physik.fu-berlin.de, leif@nuviainc.com, olaf@aepfle.de, phcoder@gmail.com, pjones@redhat.com, ps@pks.im Subject: Re: [PATCH v3 2/5] configure: Set gnu99 C language standard by default In-Reply-To: <1932a609-af11-4dc3-256c-a52ef65fbdc2@redhat.com> References: <20200513120251.9861-1-daniel.kiper@oracle.com> <20200513120251.9861-3-daniel.kiper@oracle.com> <87v9kyq7tj.fsf@dja-thinkpad.axtens.net> <20200518154952.snfclj26ibmbbkk3@tomti.i.net-space.pl> <87sgfwr90h.fsf@dja-thinkpad.axtens.net> <1932a609-af11-4dc3-256c-a52ef65fbdc2@redhat.com> Date: Wed, 20 May 2020 00:24:41 +1000 Message-ID: <87k118huja.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::543; envelope-from=dja@axtens.net; helo=mail-pg1-x543.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 14:24:48 -0000 Javier Martinez Canillas writes: > Hello Daniel, > > On 5/19/20 3:47 AM, Daniel Axtens wrote: >> Javier Martinez Canillas writes: >> >>> Hello Daniel, >>> >>> On 5/18/20 5:49 PM, Daniel Kiper wrote: >>> >>> [snip] >>> >>>>> >>>>> Without this patch, clang-9 fails on the use of nested functions in >>>>> commit cb2f15c54489 ("normal/main: Search for specific config files for >>>>> netboot") - I'll send a fix for that shortly. If I revert that as a >>>>> temporary measure, clang will build. >>>> >>>> Javier, could you take a look at this too? >> >> Javier, >> >> I think this is as simple as un-nesting the function, but you know the >> code base better than me, so I'll leave it to you unless you >> particularly want me to handle it. >> > > Yes, that should be enough. I'll post a patch but I don't have a clang > build environment so I would appreciate if you can test it. Will do. > >> Regards, >> Daniel >> > > Best regards, > -- > Javier Martinez Canillas > Software Engineer - Desktop Hardware Enablement > Red Hat