From: Jani Nikula <jani.nikula@intel.com>
To: "Kulkarni\, Vandita" <vandita.kulkarni@intel.com>,
"intel-gfx\@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v3 07/13] drm/i915/dsi: set pipe_bpp on ICL configure config
Date: Mon, 09 Dec 2019 17:46:06 +0200 [thread overview]
Message-ID: <87k1754i4h.fsf@intel.com> (raw)
In-Reply-To: <57510F3E2013164E925CD03ED7512A3B809DA25C@BGSMSX108.gar.corp.intel.com>
On Thu, 05 Dec 2019, "Kulkarni, Vandita" <vandita.kulkarni@intel.com> wrote:
>> -----Original Message-----
>> From: Jani Nikula <jani.nikula@intel.com>
>> Sent: Tuesday, November 26, 2019 7:13 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Nikula, Jani <jani.nikula@intel.com>; Kulkarni, Vandita
>> <vandita.kulkarni@intel.com>; Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Subject: [PATCH v3 07/13] drm/i915/dsi: set pipe_bpp on ICL configure config
>>
>> The ICL DSI pipe_bpp currently comes from compute_baseline_pipe_bpp().
>> Fix it.
>>
>> Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/icl_dsi.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c
>> b/drivers/gpu/drm/i915/display/icl_dsi.c
>> index f688207932e0..ef53ed6d3ecf 100644
>> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
>> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
>> @@ -1286,6 +1286,11 @@ static int gen11_dsi_compute_config(struct
>> intel_encoder *encoder,
>> else
>> pipe_config->cpu_transcoder = TRANSCODER_DSI_0;
>>
>
> Can we use mipi_dsi_pixel_format_to_bpp?
No, this is for the pipe which is different from what goes on the DSI.
BR,
Jani.
>
>> + if (intel_dsi->pixel_format == MIPI_DSI_FMT_RGB888)
>> + pipe_config->pipe_bpp = 24;
>> + else
>> + pipe_config->pipe_bpp = 18;
>> +
> Otherwise LGTM.
> Reviewed-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
>
> Thanks,
> Vandita
>> pipe_config->clock_set = true;
>> pipe_config->port_clock = intel_dsi_bitrate(intel_dsi) / 5;
>>
>> --
>> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-09 15:46 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 13:42 [PATCH v3 00/13] drm/i915/dsi: enable DSC Jani Nikula
2019-11-26 13:42 ` [Intel-gfx] " Jani Nikula
2019-11-26 13:42 ` [PATCH v3 01/13] drm/i915/bios: pass devdata to parse_ddi_port Jani Nikula
2019-11-26 13:42 ` [Intel-gfx] " Jani Nikula
2019-12-04 7:52 ` Kulkarni, Vandita
2019-11-26 13:42 ` [PATCH v3 02/13] drm/i915/bios: parse compression parameters block Jani Nikula
2019-11-26 13:42 ` [Intel-gfx] " Jani Nikula
2019-12-04 8:07 ` Kulkarni, Vandita
2019-11-26 13:42 ` [PATCH v3 03/13] drm/i915/bios: add support for querying DSC details for encoder Jani Nikula
2019-11-26 13:42 ` [Intel-gfx] " Jani Nikula
2019-12-05 4:42 ` Kulkarni, Vandita
2019-11-26 13:42 ` [PATCH v3 04/13] drm/i915/dsc: move DP specific compute params to intel_dp.c Jani Nikula
2019-11-26 13:42 ` [Intel-gfx] " Jani Nikula
2019-12-05 5:07 ` Kulkarni, Vandita
2019-11-26 13:42 ` [PATCH v3 05/13] drm/i915/dsc: move slice height calculation to encoder Jani Nikula
2019-11-26 13:42 ` [Intel-gfx] " Jani Nikula
2019-12-05 5:28 ` Kulkarni, Vandita
2019-11-26 13:42 ` [PATCH v3 06/13] drm/i915/dsc: add support for computing and writing PPS for DSI encoders Jani Nikula
2019-11-26 13:42 ` [Intel-gfx] " Jani Nikula
2019-12-05 5:44 ` Kulkarni, Vandita
2019-12-09 15:43 ` Jani Nikula
2019-11-26 13:42 ` [PATCH v3 07/13] drm/i915/dsi: set pipe_bpp on ICL configure config Jani Nikula
2019-11-26 13:42 ` [Intel-gfx] " Jani Nikula
2019-12-05 10:15 ` Kulkarni, Vandita
2019-12-09 15:46 ` Jani Nikula [this message]
2019-11-26 13:42 ` [PATCH v3 08/13] drm/i915/dsi: abstract afe_clk calculation Jani Nikula
2019-11-26 13:42 ` [Intel-gfx] " Jani Nikula
2019-12-05 8:25 ` Kulkarni, Vandita
2019-11-26 13:42 ` [PATCH v3 09/13] drm/i915/dsi: use afe_clk() instead of intel_dsi_bitrate() Jani Nikula
2019-11-26 13:42 ` [Intel-gfx] " Jani Nikula
2019-12-05 13:06 ` Kulkarni, Vandita
2019-11-26 13:42 ` [PATCH v3 10/13] drm/i915/dsi: take compression into account in afe_clk() Jani Nikula
2019-11-26 13:42 ` [Intel-gfx] " Jani Nikula
2019-12-05 14:36 ` Kulkarni, Vandita
2019-11-26 13:42 ` [PATCH v3 11/13] drm/i915/dsi: use compressed pixel format with DSC Jani Nikula
2019-11-26 13:42 ` [Intel-gfx] " Jani Nikula
2019-12-05 14:44 ` Kulkarni, Vandita
2019-11-26 13:42 ` [PATCH v3 12/13] drm/i915/dsi: account for DSC in horizontal timings Jani Nikula
2019-11-26 13:42 ` [Intel-gfx] " Jani Nikula
2019-12-05 14:52 ` Kulkarni, Vandita
2019-11-26 13:42 ` [PATCH v3 13/13] drm/i915/dsi: add support for DSC Jani Nikula
2019-11-26 13:42 ` [Intel-gfx] " Jani Nikula
2019-12-05 6:14 ` Kulkarni, Vandita
2019-12-09 16:02 ` Jani Nikula
2019-11-26 18:22 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: enable DSC (rev3) Patchwork
2019-11-26 18:22 ` [Intel-gfx] " Patchwork
2019-11-26 18:52 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-11-26 18:52 ` [Intel-gfx] " Patchwork
2019-11-27 14:07 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: enable DSC (rev4) Patchwork
2019-11-27 14:07 ` [Intel-gfx] " Patchwork
2019-11-27 14:30 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-27 14:30 ` [Intel-gfx] " Patchwork
2019-11-28 14:21 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-28 14:21 ` [Intel-gfx] " Patchwork
2019-12-05 15:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: enable DSC (rev5) Patchwork
2019-12-05 16:20 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1754i4h.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vandita.kulkarni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.