From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B6C8C432C0 for ; Mon, 2 Dec 2019 12:57:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6623820717 for ; Mon, 2 Dec 2019 12:57:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hbs3BHqw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6623820717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iblGR-00055t-GQ for qemu-devel@archiver.kernel.org; Mon, 02 Dec 2019 07:57:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54460) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iblFk-0004f0-4O for qemu-devel@nongnu.org; Mon, 02 Dec 2019 07:56:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iblFh-0006Og-3f for qemu-devel@nongnu.org; Mon, 02 Dec 2019 07:56:34 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:58896 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iblFg-0006Ny-Ci for qemu-devel@nongnu.org; Mon, 02 Dec 2019 07:56:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575291391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i1sPX+QrhBFOPkP94paUM31L2cSiYdIkfBteOwr4yiI=; b=Hbs3BHqwywJ/Ns4UXw5KbGxzfnd0rqlBsId9DJ1WGPOcm5pQUZLsfBV+fgCTehJPfkWMTC ZsUNRSsnGQeUv+/iES8reydBVT37FseQG1OrtLxX5qrK/IpGLXU6DYf6P8GSa3bvCaXgJD UCeJLdOWMxBQxi9gLrIyK9i7FVY10qk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-357-4QHx0zJBOaS_2QxiV_GwvQ-1; Mon, 02 Dec 2019 07:56:30 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 21762800D53; Mon, 2 Dec 2019 12:56:29 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-134.ams2.redhat.com [10.36.116.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4CBE25D6A0; Mon, 2 Dec 2019 12:56:24 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D3B9A1138606; Mon, 2 Dec 2019 13:56:22 +0100 (CET) From: Markus Armbruster To: Peter Maydell Subject: Re: virtiofsd: Where should it live? References: <20191125185021.GB3767@work-vm> <20191126102600.GG556568@redhat.com> <20191126121416.GE2928@work-vm> Date: Mon, 02 Dec 2019 13:56:22 +0100 In-Reply-To: (Peter Maydell's message of "Mon, 2 Dec 2019 10:12:33 +0000") Message-ID: <87k17ekhs9.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: 4QHx0zJBOaS_2QxiV_GwvQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mszeredi@redhat.com, "Daniel P. =?utf-8?Q?Berrang=C3=A9?=" , "Dr. David Alan Gilbert" , QEMU Developers , Stefan Hajnoczi , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , vgoyal@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Peter Maydell writes: > On Tue, 26 Nov 2019 at 12:15, Dr. David Alan Gilbert > wrote: >> >> * Daniel P. Berrang=C3=A9 (berrange@redhat.com) wrote: >> > My main objection to 'contrib/' is actually the perceived notions >> > about what the contrib directory is for. When I see 'contrib/' >> > code in either QEMU, or other open source projects, my general >> > impression is that this is largely unsupported code which is just >> > there as it might be interesting to someone, and doesn't typically >> > get much ongoing dev attention. > >> > virtiofsd is definitely different as it is intended to be a >> > fully production quality supported tool with active dev into >> > the future IIUC. >> > >> > IOW, if we did decide we want it in QEMU, then instead of >> > '$GIT/contrib/virtiofsd', I'd prefer to see '$GIT/virtiofsd'. >> >> I'm not sure it deserves a new top level for such a specific tool. > > Maybe, but I think I agree with Daniel that 'contrib/' is > probably not the right place for it if it's something that > we care about supporting. 'contrib' to me is "bucket of stuff > that we didn't really feel strongly we wanted to reject but > which is probably random special-cases or other obscure > stuff, don't bother looking in here and don't assume it's > going to work either". Agree. We have source for several separate programs in the root directory already: qemu-bridge-helper, qemu-edid, qemu-img, qemu-io, qemu-nbd, qemu-keymap, qemu-seccomp, qemu-ga. Just a .c file when that suffixes, else a subdirectory, except for qemu-io, which is two .c files in the root, plus include/qemu-io.h. Putting virtiofsd/ there follows qemu-ga's precedence. There's also precedence for putting such programs into their subsystem's sub-directory: fsdev/virtfs-proxy-helper, scsi/pr-manager-helper.