From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Fri, 29 Nov 2019 10:35:24 +0000 Subject: Re: [Intel-gfx] [PATCH v2 10/14] video: constify fb ops across all drivers Message-Id: <87k17jkm1f.fsf@intel.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org On Fri, 29 Nov 2019, Jani Nikula wrote: > Now that the fbops member of struct fb_info is const, we can start > making the ops const as well. > > This does not cover all drivers; some actually modify the fbops struct, > for example to adjust for different configurations, and others do more > involved things that I'd rather not touch in practically obsolete > drivers. Mostly this is the low hanging fruit where we can add "const" > and be done with it. > > v2: > - fix typo (Christophe de Dinechin) > - use "static const" instead of "const static" in mx3fb.c > - also constify smscufx.c > > Cc: linux-fbdev@vger.kernel.org > Reviewed-by: Daniel Vetter > Signed-off-by: Jani Nikula > > fixup to video drivers Rebase artefact, to be removed before applying... BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 10/14] video: constify fb ops across all drivers Date: Fri, 29 Nov 2019 12:35:24 +0200 Message-ID: <87k17jkm1f.fsf@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyOSBOb3YgMjAxOSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g d3JvdGU6Cj4gTm93IHRoYXQgdGhlIGZib3BzIG1lbWJlciBvZiBzdHJ1Y3QgZmJfaW5mbyBpcyBj b25zdCwgd2UgY2FuIHN0YXJ0Cj4gbWFraW5nIHRoZSBvcHMgY29uc3QgYXMgd2VsbC4KPgo+IFRo aXMgZG9lcyBub3QgY292ZXIgYWxsIGRyaXZlcnM7IHNvbWUgYWN0dWFsbHkgbW9kaWZ5IHRoZSBm Ym9wcyBzdHJ1Y3QsCj4gZm9yIGV4YW1wbGUgdG8gYWRqdXN0IGZvciBkaWZmZXJlbnQgY29uZmln dXJhdGlvbnMsIGFuZCBvdGhlcnMgZG8gbW9yZQo+IGludm9sdmVkIHRoaW5ncyB0aGF0IEknZCBy YXRoZXIgbm90IHRvdWNoIGluIHByYWN0aWNhbGx5IG9ic29sZXRlCj4gZHJpdmVycy4gTW9zdGx5 IHRoaXMgaXMgdGhlIGxvdyBoYW5naW5nIGZydWl0IHdoZXJlIHdlIGNhbiBhZGQgImNvbnN0Igo+ IGFuZCBiZSBkb25lIHdpdGggaXQuCj4KPiB2MjoKPiAtIGZpeCB0eXBvIChDaHJpc3RvcGhlIGRl IERpbmVjaGluKQo+IC0gdXNlICJzdGF0aWMgY29uc3QiIGluc3RlYWQgb2YgImNvbnN0IHN0YXRp YyIgaW4gbXgzZmIuYwo+IC0gYWxzbyBjb25zdGlmeSBzbXNjdWZ4LmMKPgo+IENjOiBsaW51eC1m YmRldkB2Z2VyLmtlcm5lbC5vcmcKPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4KPiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1 bGFAaW50ZWwuY29tPgo+Cj4gZml4dXAgdG8gdmlkZW8gZHJpdmVycwoKUmViYXNlIGFydGVmYWN0 LCB0byBiZSByZW1vdmVkIGJlZm9yZSBhcHBseWluZy4uLgoKQlIsCkphbmkuCgotLSAKSmFuaSBO aWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FE7AC432C0 for ; Fri, 29 Nov 2019 10:35:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E42AD215F1 for ; Fri, 29 Nov 2019 10:35:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E42AD215F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 089336E8CE; Fri, 29 Nov 2019 10:35:31 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67EC56E8CD; Fri, 29 Nov 2019 10:35:29 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2019 02:35:29 -0800 X-IronPort-AV: E=Sophos;i="5.69,257,1571727600"; d="scan'208";a="199774627" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2019 02:35:26 -0800 From: Jani Nikula To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH v2 10/14] video: constify fb ops across all drivers In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Fri, 29 Nov 2019 12:35:24 +0200 Message-ID: <87k17jkm1f.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191129103524.Ke9Fsz290iw4qYtT-AHaZk7ORPNU0e3UkGeIt6aPHMA@z> T24gRnJpLCAyOSBOb3YgMjAxOSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g d3JvdGU6Cj4gTm93IHRoYXQgdGhlIGZib3BzIG1lbWJlciBvZiBzdHJ1Y3QgZmJfaW5mbyBpcyBj b25zdCwgd2UgY2FuIHN0YXJ0Cj4gbWFraW5nIHRoZSBvcHMgY29uc3QgYXMgd2VsbC4KPgo+IFRo aXMgZG9lcyBub3QgY292ZXIgYWxsIGRyaXZlcnM7IHNvbWUgYWN0dWFsbHkgbW9kaWZ5IHRoZSBm Ym9wcyBzdHJ1Y3QsCj4gZm9yIGV4YW1wbGUgdG8gYWRqdXN0IGZvciBkaWZmZXJlbnQgY29uZmln dXJhdGlvbnMsIGFuZCBvdGhlcnMgZG8gbW9yZQo+IGludm9sdmVkIHRoaW5ncyB0aGF0IEknZCBy YXRoZXIgbm90IHRvdWNoIGluIHByYWN0aWNhbGx5IG9ic29sZXRlCj4gZHJpdmVycy4gTW9zdGx5 IHRoaXMgaXMgdGhlIGxvdyBoYW5naW5nIGZydWl0IHdoZXJlIHdlIGNhbiBhZGQgImNvbnN0Igo+ IGFuZCBiZSBkb25lIHdpdGggaXQuCj4KPiB2MjoKPiAtIGZpeCB0eXBvIChDaHJpc3RvcGhlIGRl IERpbmVjaGluKQo+IC0gdXNlICJzdGF0aWMgY29uc3QiIGluc3RlYWQgb2YgImNvbnN0IHN0YXRp YyIgaW4gbXgzZmIuYwo+IC0gYWxzbyBjb25zdGlmeSBzbXNjdWZ4LmMKPgo+IENjOiBsaW51eC1m YmRldkB2Z2VyLmtlcm5lbC5vcmcKPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4KPiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1 bGFAaW50ZWwuY29tPgo+Cj4gZml4dXAgdG8gdmlkZW8gZHJpdmVycwoKUmViYXNlIGFydGVmYWN0 LCB0byBiZSByZW1vdmVkIGJlZm9yZSBhcHBseWluZy4uLgoKQlIsCkphbmkuCgotLSAKSmFuaSBO aWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5523CC432C0 for ; Fri, 29 Nov 2019 10:35:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30E05215F1 for ; Fri, 29 Nov 2019 10:35:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30E05215F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BAD5C6E8CD; Fri, 29 Nov 2019 10:35:30 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67EC56E8CD; Fri, 29 Nov 2019 10:35:29 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2019 02:35:29 -0800 X-IronPort-AV: E=Sophos;i="5.69,257,1571727600"; d="scan'208";a="199774627" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2019 02:35:26 -0800 From: Jani Nikula To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Fri, 29 Nov 2019 12:35:24 +0200 Message-ID: <87k17jkm1f.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v2 10/14] video: constify fb ops across all drivers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191129103524.OJFPf8VuR4jhzjAdm6j5r738KjK3A5e7ibIj7Ea9bJY@z> T24gRnJpLCAyOSBOb3YgMjAxOSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g d3JvdGU6Cj4gTm93IHRoYXQgdGhlIGZib3BzIG1lbWJlciBvZiBzdHJ1Y3QgZmJfaW5mbyBpcyBj b25zdCwgd2UgY2FuIHN0YXJ0Cj4gbWFraW5nIHRoZSBvcHMgY29uc3QgYXMgd2VsbC4KPgo+IFRo aXMgZG9lcyBub3QgY292ZXIgYWxsIGRyaXZlcnM7IHNvbWUgYWN0dWFsbHkgbW9kaWZ5IHRoZSBm Ym9wcyBzdHJ1Y3QsCj4gZm9yIGV4YW1wbGUgdG8gYWRqdXN0IGZvciBkaWZmZXJlbnQgY29uZmln dXJhdGlvbnMsIGFuZCBvdGhlcnMgZG8gbW9yZQo+IGludm9sdmVkIHRoaW5ncyB0aGF0IEknZCBy YXRoZXIgbm90IHRvdWNoIGluIHByYWN0aWNhbGx5IG9ic29sZXRlCj4gZHJpdmVycy4gTW9zdGx5 IHRoaXMgaXMgdGhlIGxvdyBoYW5naW5nIGZydWl0IHdoZXJlIHdlIGNhbiBhZGQgImNvbnN0Igo+ IGFuZCBiZSBkb25lIHdpdGggaXQuCj4KPiB2MjoKPiAtIGZpeCB0eXBvIChDaHJpc3RvcGhlIGRl IERpbmVjaGluKQo+IC0gdXNlICJzdGF0aWMgY29uc3QiIGluc3RlYWQgb2YgImNvbnN0IHN0YXRp YyIgaW4gbXgzZmIuYwo+IC0gYWxzbyBjb25zdGlmeSBzbXNjdWZ4LmMKPgo+IENjOiBsaW51eC1m YmRldkB2Z2VyLmtlcm5lbC5vcmcKPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4KPiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1 bGFAaW50ZWwuY29tPgo+Cj4gZml4dXAgdG8gdmlkZW8gZHJpdmVycwoKUmViYXNlIGFydGVmYWN0 LCB0byBiZSByZW1vdmVkIGJlZm9yZSBhcHBseWluZy4uLgoKQlIsCkphbmkuCgotLSAKSmFuaSBO aWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=