All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aurélien Aptel" <aaptel@suse.com>
To: Steve French <smfrench@gmail.com>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [RFC][SMB3][PATCH] Allow share to be mounted with "cache=ro" if immutable share
Date: Wed, 28 Aug 2019 12:20:59 +0200	[thread overview]
Message-ID: <87k1axlhf8.fsf@suse.com> (raw)
In-Reply-To: <CAH2r5mu_koRUCV9snYu_A6at8r+kJ85DgFszG4=seEEn+qb0LQ@mail.gmail.com>

"Steve French" <smfrench@gmail.com> writes:
> Increases performance a lot in cases where we know that the share is
> not changing

This is just adding the parsing of the option but it sounds like a good idea.

> +#define CIFS_MOUNT_RO_CACHE	0x20000000  /* assumes share will not change */

This flag probably needs to be added to CIFS_MOUNT_MASK: if one cifs sb
is using that flag, it should only be reused for new mounts that also
require that flag.

Cheers,

-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)

  parent reply	other threads:[~2019-08-28 10:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28  5:02 [RFC][SMB3][PATCH] Allow share to be mounted with "cache=ro" if immutable share Steve French
2019-08-28  6:11 ` ronnie sahlberg
2019-08-28 10:20 ` Aurélien Aptel [this message]
2019-08-28 10:27   ` ronnie sahlberg
2019-08-28 10:54     ` Aurélien Aptel
2019-08-28 22:17     ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1axlhf8.fsf@suse.com \
    --to=aaptel@suse.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.