From: Kalle Valo <kvalo@codeaurora.org>
To: "Enrico Weigelt\, metux IT consult" <info@metux.net>
Cc: linux-kernel@vger.kernel.org, amitkarwar@gmail.com,
siva8118@gmail.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] drivers: net: wireless: rsi: return explicit error values
Date: Tue, 30 Jul 2019 11:29:49 +0300 [thread overview]
Message-ID: <87k1c0lybm.fsf@codeaurora.org> (raw)
In-Reply-To: <1564413872-10720-1-git-send-email-info@metux.net> (Enrico Weigelt's message of "Mon, 29 Jul 2019 17:24:32 +0200")
"Enrico Weigelt, metux IT consult" <info@metux.net> writes:
> From: Enrico Weigelt <info@metux.net>
>
> Explicitly return constants instead of variable (and rely on
> it to be explicitly initialized), if the value is supposed
> to be fixed anyways. Align it with the rest of the driver,
> which does it the same way.
>
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
> drivers/net/wireless/rsi/rsi_91x_sdio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
The prefix should be just "rsi:", I'll fix that.
--
Kalle Valo
next prev parent reply other threads:[~2019-07-30 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 15:24 [PATCH] drivers: net: wireless: rsi: return explicit error values Enrico Weigelt, metux IT consult
2019-07-30 8:29 ` Kalle Valo [this message]
2019-08-06 12:41 ` [PATCH] " Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2019-06-27 14:30 [PATCH] drivers: net: wireless: " Enrico Weigelt, metux IT consult
2019-07-24 11:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1c0lybm.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=info@metux.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=siva8118@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.