From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 607B2C28CC1 for ; Wed, 29 May 2019 12:51:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37891205ED for ; Wed, 29 May 2019 12:51:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37891205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:53849 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVy3F-0005px-GF for qemu-devel@archiver.kernel.org; Wed, 29 May 2019 08:51:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVy1S-0004lN-LT for qemu-devel@nongnu.org; Wed, 29 May 2019 08:49:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVy1R-0001qL-FQ for qemu-devel@nongnu.org; Wed, 29 May 2019 08:49:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55544) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVy1P-0001mW-Oj for qemu-devel@nongnu.org; Wed, 29 May 2019 08:49:37 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7722630BBE9D; Wed, 29 May 2019 12:49:19 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-117-250.ams2.redhat.com [10.36.117.250]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C629680BB; Wed, 29 May 2019 12:49:05 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 97DA51138648; Wed, 29 May 2019 14:49:04 +0200 (CEST) From: Markus Armbruster To: Paul Durrant References: <87lfyqla7r.fsf@dusky.pond.sub.org> <20190528192317.GG22103@habkost.net> <3038b5ea224c4f2b84eb7c1f5fa36134@AMSPEX02CL03.citrite.net> Date: Wed, 29 May 2019 14:49:04 +0200 In-Reply-To: <3038b5ea224c4f2b84eb7c1f5fa36134@AMSPEX02CL03.citrite.net> (Paul Durrant's message of "Wed, 29 May 2019 08:21:33 +0000") Message-ID: <87k1e9fmtb.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 29 May 2019 12:49:29 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] Headers without multiple inclusion guards X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Dmitry Fleytman , Sagar Karandikar , "Michael S. Tsirkin" , James Hogan , Anthony Green , Palmer Dabbelt , Mark Cave-Ayland , "qemu-devel@nongnu.org" , Philippe =?utf-8?Q?Mathieu-Daud?= =?utf-8?Q?=C3=A9?= , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Helge Deller , David Hildenbrand , Halil Pasic , Christian Borntraeger , Anthony Perard , David Gibson , Laszlo Ersek , Jason Wang , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Alistair Francis , 'Eduardo Habkost' , Riku Voipio , Greg Kurz , Marcelo Tosatti , Beniamino Galvani , Eric Auger , Stafford Horne , Alex =?utf-8?Q?Benn=C3=A9e?= , Richard Henderson , "Daniel P. Berrange" , Claudio Fontana , Bastian Koppelmann , Chris Wulff , Claudio Fontana , Laurent Vivier , Andrew Baumann , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Michael Walle , Aleksandar Markovic , Cornelia Huck , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Paul Durrant writes: > >> [...] >> > Guest CPU Cores (Xen): >> > ---------------------- >> > >> > X86 >> > M: Stefano Stabellini >> > M: Anthony Perard >> > M: Paul Durrant >> > include/hw/xen/io/ring.h >> >> I see a __XEN_PUBLIC_IO_RING_H__ guard there. Probably >> clean-header-guards.pl is confused by the comments at the end of >> the file? >> > > Yes, I see no problem there. The emacs boilerplate is common in Xen headers and persisted when this was imported. I fixed scripts/clean-header-guards.pl in my tree to cope with this pattern. Thanks!