From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E019EC43381 for ; Thu, 28 Mar 2019 17:25:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B53AE2173C for ; Thu, 28 Mar 2019 17:25:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726046AbfC1RZ0 convert rfc822-to-8bit (ORCPT ); Thu, 28 Mar 2019 13:25:26 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:34473 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbfC1RZ0 (ORCPT ); Thu, 28 Mar 2019 13:25:26 -0400 X-Originating-IP: 109.213.38.144 Received: from localhost (alyon-652-1-47-144.w109-213.abo.wanadoo.fr [109.213.38.144]) (Authenticated sender: gregory.clement@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 0AF74FF80E; Thu, 28 Mar 2019 17:25:14 +0000 (UTC) From: Gregory CLEMENT To: Rob Herring Cc: Stephen Boyd , Mike Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Antoine Tenart , =?utf-8?Q?Miqu=C3=A8l?= Raynal , Maxime Chevallier Subject: Re: [PATCH v4 1/6] dt-bindings: ap806: add the cluster clock node in the syscon file In-Reply-To: <20190328171350.GA26680@bogus> References: <20190325124803.28904-1-gregory.clement@bootlin.com> <20190325124803.28904-2-gregory.clement@bootlin.com> <20190328171350.GA26680@bogus> Date: Thu, 28 Mar 2019 18:25:14 +0100 Message-ID: <87k1gioqrp.fsf@FE-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Rob, On jeu., mars 28 2019, Rob Herring wrote: > On Mon, Mar 25, 2019 at 01:47:58PM +0100, Gregory CLEMENT wrote: >> Document the device tree binding for the cluster clock controllers found >> in the Armada 7K/8K SoCs. >> >> Signed-off-by: Gregory CLEMENT >> --- >> .../arm/marvell/ap806-system-controller.txt | 25 +++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt >> index 7b8b8eb0191f..ceeba18b4ac3 100644 >> --- a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt >> +++ b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt >> @@ -143,3 +143,28 @@ ap_syscon1: system-controller@6f8000 { >> #thermal-sensor-cells = <1>; >> }; >> }; >> + >> +Cluster clocks: >> +--------------- >> + >> +Device Tree Clock bindings for cluster clock of AP806 Marvell. Each >> +cluster contain up to 2 CPUs running at the same frequency. >> + >> +Required properties: >> +- compatible: must be "marvell,ap806-cpu-clock"; >> +- #clock-cells : should be set to 1. >> +- clocks : shall be the input parents clock phandle for the clock. >> + >> +Optional property: >> + - reg: register range associated the cluser clocks > > reg can be optional to use, but should either be there or not. OK so let's remove it! Thanks, Grégory > > And there's a typo. > >> + >> +ap_syscon1: system-controller@6f8000 { >> + compatible = "syscon", "simple-mfd"; >> + reg = <0x6f8000 0x1000>; >> + >> + cpu_clk: clock-cpu { >> + compatible = "marvell,ap806-cpu-clock"; >> + clocks = <&ap_clk 0>, <&ap_clk 1>; >> + #clock-cells = <1>; >> + }; >> +}; >> -- >> 2.20.1 >> -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBE7AC43381 for ; Thu, 28 Mar 2019 17:25:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A67432173C for ; Thu, 28 Mar 2019 17:25:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ktk8/13P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A67432173C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=inn51Vpr3jYTXouzo7CANOozC/jfKWnHCfdDePLrq64=; b=Ktk8/13Ph92Zg8 GpybZVdo5Vw8M07DEdWaAEmEBGzfuyQUv9XccKWG4UtFCeQMyTiyWy5Yzhwcg6IKt4LEjrTHqGSOj YJxkol1EsECtBT0o+XDMQVH1Z43a2VM4/d8MvR2OGPNrvS3mi942+cp6OCgp3WuqynlSW0ZmS/UIn 9VufMzbgTKghRAjAyup8i5uN+5QefJTY/2Tv+8UftgBtey8MxTCAJxSx+m1M1uUYsBiWFKIxkC2pE GbS5XmNOH9hN2ebnthEt+zz2OSsvV971/L5Z90UAmP8x6+Dxizpsrg+L8JzZcDeUKDtPdL5ojuY3V VcGONguLFqCxsRSltXvQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9YmX-0003aA-50; Thu, 28 Mar 2019 17:25:37 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9YmT-0003Z4-Bb for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2019 17:25:35 +0000 X-Originating-IP: 109.213.38.144 Received: from localhost (alyon-652-1-47-144.w109-213.abo.wanadoo.fr [109.213.38.144]) (Authenticated sender: gregory.clement@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 0AF74FF80E; Thu, 28 Mar 2019 17:25:14 +0000 (UTC) From: Gregory CLEMENT To: Rob Herring Subject: Re: [PATCH v4 1/6] dt-bindings: ap806: add the cluster clock node in the syscon file In-Reply-To: <20190328171350.GA26680@bogus> References: <20190325124803.28904-1-gregory.clement@bootlin.com> <20190325124803.28904-2-gregory.clement@bootlin.com> <20190328171350.GA26680@bogus> Date: Thu, 28 Mar 2019 18:25:14 +0100 Message-ID: <87k1gioqrp.fsf@FE-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_102533_545299_0DE5AE17 X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jason Cooper , Andrew Lunn , Antoine Tenart , Mike Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, Maxime Chevallier , Thomas Petazzoni , =?utf-8?Q?Miqu=C3=A8l?= Raynal , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUm9iLAogCiBPbiBqZXUuLCBtYXJzIDI4IDIwMTksIFJvYiBIZXJyaW5nIDxyb2JoQGtlcm5l bC5vcmc+IHdyb3RlOgoKPiBPbiBNb24sIE1hciAyNSwgMjAxOSBhdCAwMTo0Nzo1OFBNICswMTAw LCBHcmVnb3J5IENMRU1FTlQgd3JvdGU6Cj4+IERvY3VtZW50IHRoZSBkZXZpY2UgdHJlZSBiaW5k aW5nIGZvciB0aGUgY2x1c3RlciBjbG9jayBjb250cm9sbGVycyBmb3VuZAo+PiBpbiB0aGUgQXJt YWRhIDdLLzhLIFNvQ3MuCj4+IAo+PiBTaWduZWQtb2ZmLWJ5OiBHcmVnb3J5IENMRU1FTlQgPGdy ZWdvcnkuY2xlbWVudEBib290bGluLmNvbT4KPj4gLS0tCj4+ICAuLi4vYXJtL21hcnZlbGwvYXA4 MDYtc3lzdGVtLWNvbnRyb2xsZXIudHh0ICAgfCAyNSArKysrKysrKysrKysrKysrKysrCj4+ICAx IGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKQo+PiAKPj4gZGlmZiAtLWdpdCBhL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vbWFydmVsbC9hcDgwNi1zeXN0ZW0tY29u dHJvbGxlci50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvYXJtL21hcnZl bGwvYXA4MDYtc3lzdGVtLWNvbnRyb2xsZXIudHh0Cj4+IGluZGV4IDdiOGI4ZWIwMTkxZi4uY2Vl YmExOGI0YWMzIDEwMDY0NAo+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvYXJtL21hcnZlbGwvYXA4MDYtc3lzdGVtLWNvbnRyb2xsZXIudHh0Cj4+ICsrKyBiL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vbWFydmVsbC9hcDgwNi1zeXN0ZW0tY29u dHJvbGxlci50eHQKPj4gQEAgLTE0MywzICsxNDMsMjggQEAgYXBfc3lzY29uMTogc3lzdGVtLWNv bnRyb2xsZXJANmY4MDAwIHsKPj4gIAkJI3RoZXJtYWwtc2Vuc29yLWNlbGxzID0gPDE+Owo+PiAg CX07Cj4+ICB9Owo+PiArCj4+ICtDbHVzdGVyIGNsb2NrczoKPj4gKy0tLS0tLS0tLS0tLS0tLQo+ PiArCj4+ICtEZXZpY2UgVHJlZSBDbG9jayBiaW5kaW5ncyBmb3IgY2x1c3RlciBjbG9jayBvZiBB UDgwNiBNYXJ2ZWxsLiBFYWNoCj4+ICtjbHVzdGVyIGNvbnRhaW4gdXAgdG8gMiBDUFVzIHJ1bm5p bmcgYXQgdGhlIHNhbWUgZnJlcXVlbmN5Lgo+PiArCj4+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ PiArLSBjb21wYXRpYmxlOiBtdXN0IGJlICAibWFydmVsbCxhcDgwNi1jcHUtY2xvY2siOwo+PiAr LSAjY2xvY2stY2VsbHMgOiBzaG91bGQgYmUgc2V0IHRvIDEuCj4+ICstIGNsb2NrcyA6IHNoYWxs IGJlIHRoZSBpbnB1dCBwYXJlbnRzIGNsb2NrIHBoYW5kbGUgZm9yIHRoZSBjbG9jay4KPj4gKwo+ PiArT3B0aW9uYWwgcHJvcGVydHk6Cj4+ICsgLSByZWc6IHJlZ2lzdGVyIHJhbmdlIGFzc29jaWF0 ZWQgdGhlIGNsdXNlciBjbG9ja3MKPgo+IHJlZyBjYW4gYmUgb3B0aW9uYWwgdG8gdXNlLCBidXQg c2hvdWxkIGVpdGhlciBiZSB0aGVyZSBvciBub3QuCgpPSyBzbyBsZXQncyByZW1vdmUgaXQhCgpU aGFua3MsCgpHcsOpZ29yeQoKPgo+IEFuZCB0aGVyZSdzIGEgdHlwby4KPgo+PiArCj4+ICthcF9z eXNjb24xOiBzeXN0ZW0tY29udHJvbGxlckA2ZjgwMDAgewo+PiArCWNvbXBhdGlibGUgPSAic3lz Y29uIiwgInNpbXBsZS1tZmQiOwo+PiArCXJlZyA9IDwweDZmODAwMCAweDEwMDA+Owo+PiArCj4+ ICsJY3B1X2NsazogY2xvY2stY3B1IHsKPj4gKwkJY29tcGF0aWJsZSA9ICJtYXJ2ZWxsLGFwODA2 LWNwdS1jbG9jayI7Cj4+ICsJCWNsb2NrcyA9IDwmYXBfY2xrIDA+LCA8JmFwX2NsayAxPjsKPj4g KwkJI2Nsb2NrLWNlbGxzID0gPDE+Owo+PiArCX07Cj4+ICt9Owo+PiAtLSAKPj4gMi4yMC4xCj4+ IAoKLS0gCkdyZWdvcnkgQ2xlbWVudCwgQm9vdGxpbgpFbWJlZGRlZCBMaW51eCBhbmQgS2VybmVs IGVuZ2luZWVyaW5nCmh0dHA6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=