From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/optee-client: depends on thread support
Date: Thu, 07 Mar 2019 11:35:33 +0200 [thread overview]
Message-ID: <87k1hb2fiy.fsf@tarshish> (raw)
In-Reply-To: <17603738bfac0de04a1de57a562dbde2a572d926.1551944208.git.etienne.carriere@linaro.org>
Hi Etienne,
On Thu, Mar 07 2019, Etienne Carriere wrote:
> BR2_PACKAGE_OPTEE_CLIENT depends on BR2_TOOLCHAIN_HAS_THREADS.
> Library teec uses pthread support to protect clients state
> management. This change declares this dependency in the package.
>
> Fixes [1] that set an toolchain without thread support and failed
> to build with trace:
>
> CMake Error at /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
> Could NOT find Threads (missing: Threads_FOUND)
> Call Stack (most recent call first):
> /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377 (_FPHSA_FAILURE_MESSAGE)
> /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindThreads.cmake:212 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
> libteec/CMakeLists.txt:8 (find_package)
>
> [1] https://autobuild.buildroot.net/results/ed6ffe2197da4f3a970bd3c5522291236396cc8e
>
> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> ---
> package/optee-client/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/optee-client/Config.in b/package/optee-client/Config.in
> index db0b7b7..1379201 100644
> --- a/package/optee-client/Config.in
> +++ b/package/optee-client/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_OPTEE_CLIENT
> bool "optee-client"
> depends on !BR2_STATIC_LIBS
> + depends on BR2_TOOLCHAIN_HAS_THREADS
You need to propagate this added dependencies to packages that select
optee-client recursively. These are currently optee-test and
optee-benchmark.
You should also update the dependencies commit below, and in all other
packages you update.
baruch
> help
> Enable the OP-TEE client package that brings non-secure
> client application resources for OP-TEE support. OP-TEE
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2019-03-07 9:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 9:29 [Buildroot] [PATCH] package/optee-client: depends on thread support Etienne Carriere
2019-03-07 9:35 ` Baruch Siach [this message]
2019-03-07 10:02 ` Etienne Carriere
2019-03-07 14:48 ` [Buildroot] [PATCH v2 1/4] " Etienne Carriere
2019-03-07 14:48 ` [Buildroot] [PATCH v2 2/4] package/optee-benchmark: thread dependency from optee-client Etienne Carriere
2019-03-07 14:48 ` [Buildroot] [PATCH v2 3/4] package/optee-examples: " Etienne Carriere
2019-03-07 14:48 ` [Buildroot] [PATCH v2 4/4] package/optee-test: " Etienne Carriere
2019-03-07 15:10 ` [Buildroot] [PATCH v2 1/4] package/optee-client: depends on thread support Baruch Siach
2019-03-07 15:30 ` Etienne Carriere
2019-03-07 15:45 ` [Buildroot] [PATCH v3] package/optee-*: packages depend " Etienne Carriere
2019-03-07 17:13 ` Baruch Siach
2019-03-07 17:22 ` Etienne Carriere
2019-03-07 21:31 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1hb2fiy.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.