From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 08/34] drm/i915: Make all GPU resets atomic Date: Wed, 23 Jan 2019 10:52:03 +0200 Message-ID: <87k1ivn4cs.fsf@gaia.fi.intel.com> References: <20190121222117.23305-1-chris@chris-wilson.co.uk> <20190121222117.23305-9-chris@chris-wilson.co.uk> <2943ee42-b094-8977-a4fa-fac111d5604d@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 058526EEAC for ; Wed, 23 Jan 2019 08:53:57 +0000 (UTC) In-Reply-To: <2943ee42-b094-8977-a4fa-fac111d5604d@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John Harrison , Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Sm9obiBIYXJyaXNvbiA8Sm9obi5DLkhhcnJpc29uQEludGVsLmNvbT4gd3JpdGVzOgoKPiBPbiAx LzIxLzIwMTkgMTQ6MjAsIENocmlzIFdpbHNvbiB3cm90ZToKPj4gSW4gcHJlcGFyYXRpb24gZm9y IHRoZSBuZXh0IGZldyBjb21taXRzLCBtYWtlIHJlc2V0dGluZyB0aGUgR1BVIGF0b21pYy4KPj4g Q3VycmVudGx5LCB3ZSBoYXZlIHByZXBhcmVkIGdlbjYrIGZvciBhdG9taWMgcmVzZXR0aW5nIG9m IGluZGl2aWR1YWwKPj4gZW5naW5lcywgYnV0IG5vdyB0aGVyZSBpcyBhIHJlcXVpcmVtZW50IHRv IHBlcmZvcm0gdGhlIHdob2xlIGRldmljZQo+PiBsZXZlbCByZXNldCAoanVzdCB0aGUgcmVnaXN0 ZXIgcG9raW5nKSBmcm9tIGluc2lkZSBhbiBhdG9taWMgY29udGV4dC4KPj4KPj4gU2lnbmVkLW9m Zi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+IFJldmlld2Vk LWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPj4gLS0t Cj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXNldC5jIHwgNTAgKysrKysrKysrKysr KysrKystLS0tLS0tLS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCsp LCAyMyBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfcmVzZXQuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVzZXQuYwo+PiBpbmRl eCAzNDJkOWVlNDI2MDEuLmI5ZDBlYTcwMzYxYyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9yZXNldC5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cmVzZXQuYwo+PiBAQCAtMTQ0LDE0ICsxNDQsMTQgQEAgc3RhdGljIGludCBpOTE1X2RvX3Jlc2V0 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+PiAgIAo+PiAgIAkvKiBBc3NlcnQgcmVz ZXQgZm9yIGF0IGxlYXN0IDIwIHVzZWMsIGFuZCB3YWl0IGZvciBhY2tub3dsZWRnZW1lbnQuICov Cj4+ICAgCXBjaV93cml0ZV9jb25maWdfYnl0ZShwZGV2LCBJOTE1X0dEUlNULCBHUkRPTV9SRVNF VF9FTkFCTEUpOwo+PiAtCXVzbGVlcF9yYW5nZSg1MCwgMjAwKTsKPj4gLQllcnIgPSB3YWl0X2Zv cihpOTE1X2luX3Jlc2V0KHBkZXYpLCA1MDApOwo+PiArCXVkZWxheSg1MCk7Cj4+ICsJZXJyID0g d2FpdF9mb3JfYXRvbWljKGk5MTVfaW5fcmVzZXQocGRldiksIDUwKTsKPiBJcyBpdCBrbm93biB0 byBiZSBzYWZlIHRvIHJlZHVjZSBhbGwgb2YgdGhlc2UgdGltZSBvdXQgdmFsdWVzPyBXaGVyZSBk aWQgCj4gdGhlIG9yaWdpbmFsbHkgNTAwbXMgdmFsdWUgY29tZSBmcm9tPyBJcyB0aGVyZSBhbnkg Y2hhbmNlIG9mIGdldHRpbmcgCj4gc3BvcmFkaWMgZmFpbHVyZXMgYmVjYXVzZSA1MG1zIGlzIGJv cmRlcmxpbmUgaW4gdGhlIHdvcnN0IGNhc2Ugc2NlbmFyaW8/IAo+IEl0IHN0aWxsIHNvdW5kcyBo dWdlIGJ1dCBhbiBvcmRlciBvZiBtYWduaXR1ZGUgY2hhbmdlIGluIGEgdGltZW91dCAKPiBhbHdh eXMgc2VlbXMgd29ycnlpbmchCj4KPj4gICAKPj4gICAJLyogQ2xlYXIgdGhlIHJlc2V0IHJlcXVl c3QuICovCj4+ICAgCXBjaV93cml0ZV9jb25maWdfYnl0ZShwZGV2LCBJOTE1X0dEUlNULCAwKTsK Pj4gLQl1c2xlZXBfcmFuZ2UoNTAsIDIwMCk7Cj4+ICsJdWRlbGF5KDUwKTsKPj4gICAJaWYgKCFl cnIpCj4+IC0JCWVyciA9IHdhaXRfZm9yKCFpOTE1X2luX3Jlc2V0KHBkZXYpLCA1MDApOwo+PiAr CQllcnIgPSB3YWl0X2Zvcl9hdG9taWMoIWk5MTVfaW5fcmVzZXQocGRldiksIDUwKTsKPj4gICAK Pj4gICAJcmV0dXJuIGVycjsKPj4gICB9Cj4+IEBAIC0xNzEsNyArMTcxLDcgQEAgc3RhdGljIGlu dCBnMzNfZG9fcmVzZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4+ICAgCXN0cnVj dCBwY2lfZGV2ICpwZGV2ID0gaTkxNS0+ZHJtLnBkZXY7Cj4+ICAgCj4+ICAgCXBjaV93cml0ZV9j b25maWdfYnl0ZShwZGV2LCBJOTE1X0dEUlNULCBHUkRPTV9SRVNFVF9FTkFCTEUpOwo+PiAtCXJl dHVybiB3YWl0X2ZvcihnNHhfcmVzZXRfY29tcGxldGUocGRldiksIDUwMCk7Cj4+ICsJcmV0dXJu IHdhaXRfZm9yX2F0b21pYyhnNHhfcmVzZXRfY29tcGxldGUocGRldiksIDUwKTsKPj4gICB9Cj4+ ICAgCj4+ICAgc3RhdGljIGludCBnNHhfZG9fcmVzZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LAo+PiBAQCAtMTgyLDEzICsxODIsMTMgQEAgc3RhdGljIGludCBnNHhfZG9fcmVz ZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgIAlpbnQgcmV0Owo+PiAg IAo+PiAgIAkvKiBXYVZjcENsa0dhdGVEaXNhYmxlRm9yTWVkaWFSZXNldDpjdGcsZWxrICovCj4+ IC0JSTkxNV9XUklURShWREVDQ0xLX0dBVEVfRCwKPj4gLQkJICAgSTkxNV9SRUFEKFZERUNDTEtf R0FURV9EKSB8IFZDUF9VTklUX0NMT0NLX0dBVEVfRElTQUJMRSk7Cj4+IC0JUE9TVElOR19SRUFE KFZERUNDTEtfR0FURV9EKTsKPj4gKwlJOTE1X1dSSVRFX0ZXKFZERUNDTEtfR0FURV9ELAo+PiAr CQkgICAgICBJOTE1X1JFQUQoVkRFQ0NMS19HQVRFX0QpIHwgVkNQX1VOSVRfQ0xPQ0tfR0FURV9E SVNBQkxFKTsKPj4gKwlQT1NUSU5HX1JFQURfRlcoVkRFQ0NMS19HQVRFX0QpOwo+PiAgIAo+PiAg IAlwY2lfd3JpdGVfY29uZmlnX2J5dGUocGRldiwgSTkxNV9HRFJTVCwKPj4gICAJCQkgICAgICBH UkRPTV9NRURJQSB8IEdSRE9NX1JFU0VUX0VOQUJMRSk7Cj4+IC0JcmV0ID0gIHdhaXRfZm9yKGc0 eF9yZXNldF9jb21wbGV0ZShwZGV2KSwgNTAwKTsKPj4gKwlyZXQgPSAgd2FpdF9mb3JfYXRvbWlj KGc0eF9yZXNldF9jb21wbGV0ZShwZGV2KSwgNTApOwo+PiAgIAlpZiAocmV0KSB7Cj4+ICAgCQlE Uk1fREVCVUdfRFJJVkVSKCJXYWl0IGZvciBtZWRpYSByZXNldCBmYWlsZWRcbiIpOwo+PiAgIAkJ Z290byBvdXQ7Cj4+IEBAIC0xOTYsNyArMTk2LDcgQEAgc3RhdGljIGludCBnNHhfZG9fcmVzZXQo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgIAo+PiAgIAlwY2lfd3JpdGVf Y29uZmlnX2J5dGUocGRldiwgSTkxNV9HRFJTVCwKPj4gICAJCQkgICAgICBHUkRPTV9SRU5ERVIg fCBHUkRPTV9SRVNFVF9FTkFCTEUpOwo+PiAtCXJldCA9ICB3YWl0X2ZvcihnNHhfcmVzZXRfY29t cGxldGUocGRldiksIDUwMCk7Cj4+ICsJcmV0ID0gIHdhaXRfZm9yX2F0b21pYyhnNHhfcmVzZXRf Y29tcGxldGUocGRldiksIDUwKTsKPj4gICAJaWYgKHJldCkgewo+PiAgIAkJRFJNX0RFQlVHX0RS SVZFUigiV2FpdCBmb3IgcmVuZGVyIHJlc2V0IGZhaWxlZFxuIik7Cj4+ICAgCQlnb3RvIG91dDsK Pj4gQEAgLTIwNSw5ICsyMDUsOSBAQCBzdGF0aWMgaW50IGc0eF9kb19yZXNldChzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICAgb3V0Ogo+PiAgIAlwY2lfd3JpdGVfY29uZmln X2J5dGUocGRldiwgSTkxNV9HRFJTVCwgMCk7Cj4+ICAgCj4+IC0JSTkxNV9XUklURShWREVDQ0xL X0dBVEVfRCwKPj4gLQkJICAgSTkxNV9SRUFEKFZERUNDTEtfR0FURV9EKSAmIH5WQ1BfVU5JVF9D TE9DS19HQVRFX0RJU0FCTEUpOwo+PiAtCVBPU1RJTkdfUkVBRChWREVDQ0xLX0dBVEVfRCk7Cj4+ ICsJSTkxNV9XUklURV9GVyhWREVDQ0xLX0dBVEVfRCwKPj4gKwkJICAgICAgSTkxNV9SRUFEKFZE RUNDTEtfR0FURV9EKSAmIH5WQ1BfVU5JVF9DTE9DS19HQVRFX0RJU0FCTEUpOwo+PiArCVBPU1RJ TkdfUkVBRF9GVyhWREVDQ0xLX0dBVEVfRCk7Cj4+ICAgCj4+ICAgCXJldHVybiByZXQ7Cj4+ICAg fQo+PiBAQCAtMjE4LDI3ICsyMTgsMjkgQEAgc3RhdGljIGludCBpcm9ubGFrZV9kb19yZXNldChz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICAgewo+PiAgIAlpbnQgcmV0Owo+ PiAgIAo+PiAtCUk5MTVfV1JJVEUoSUxLX0dEU1IsIElMS19HUkRPTV9SRU5ERVIgfCBJTEtfR1JE T01fUkVTRVRfRU5BQkxFKTsKPj4gLQlyZXQgPSBpbnRlbF93YWl0X2Zvcl9yZWdpc3RlcihkZXZf cHJpdiwKPj4gLQkJCQkgICAgICBJTEtfR0RTUiwgSUxLX0dSRE9NX1JFU0VUX0VOQUJMRSwgMCwK Pj4gLQkJCQkgICAgICA1MDApOwo+PiArCUk5MTVfV1JJVEVfRlcoSUxLX0dEU1IsIElMS19HUkRP TV9SRU5ERVIgfCBJTEtfR1JET01fUkVTRVRfRU5BQkxFKTsKPj4gKwlyZXQgPSBfX2ludGVsX3dh aXRfZm9yX3JlZ2lzdGVyX2Z3KGRldl9wcml2LCBJTEtfR0RTUiwKPj4gKwkJCQkJICAgSUxLX0dS RE9NX1JFU0VUX0VOQUJMRSwgMCwKPj4gKwkJCQkJICAgNTAwMCwgMCwKPj4gKwkJCQkJICAgTlVM TCk7Cj4gVGhlc2UgdHdvIHRpbWVvdXRzIGFyZSBub3cgdHdvIG9yZGVycyBvZiBtYWduaXR1ZGUg c21hbGxlcj8gSXQgd2FzIDUwMG1zIAo+IGJ1dCBpcyBub3cgNTAwMHVzICg9NW1zKT8KCkFncmVl ZC4gSSBpbmRpcmVjdHkgcmFpc2VkIHNhbWUgY29uY2VybiBvbiBwcmV2aW91cyByb3VuZCBvZgpy ZXZpZXcgYnkgc2F5aW5nIHRoYXQgaXQgd291bGQgYmUgbmljZSBpZiB3ZSBoYWQgc29tZSBzdGF0 aXN0aWNzCmZyb20gQ0kuCgpUaGUgb3JpZ2luYWwgYmFsbG9vbmluZyBvZiB0aGVzZSBudW1iZXJz LCBmcm9tIHRoZSBsaXR0bGUKdGhhdCBpcyBhdmFpbGFibGUgb24gZG9jdW1lbnRhdGlvbiwgaXMg dGhlIGZhY3QgdGhhdApwcmV2aW91c2x5LCBpdCBkaWRuJ3QgZG8gbXVjaCBoYXJtIHRvIHBpY2sg YSBsYXJnZSBudW1iZXIKdG8gYmUgb24gc2FmZSBzaWRlLCBzbyB3aHkgbm90LgoKTm93LCBpdCBp cyBhIGRpZmZlcmVudCBnYW1lLgoKLU1pa2EKCj4KPiBKb2huLgo+Cj4KPj4gICAJaWYgKHJldCkg ewo+PiAgIAkJRFJNX0RFQlVHX0RSSVZFUigiV2FpdCBmb3IgcmVuZGVyIHJlc2V0IGZhaWxlZFxu Iik7Cj4+ICAgCQlnb3RvIG91dDsKPj4gICAJfQo+PiAgIAo+PiAtCUk5MTVfV1JJVEUoSUxLX0dE U1IsIElMS19HUkRPTV9NRURJQSB8IElMS19HUkRPTV9SRVNFVF9FTkFCTEUpOwo+PiAtCXJldCA9 IGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGRldl9wcml2LAo+PiAtCQkJCSAgICAgIElMS19HRFNS LCBJTEtfR1JET01fUkVTRVRfRU5BQkxFLCAwLAo+PiAtCQkJCSAgICAgIDUwMCk7Cj4+ICsJSTkx NV9XUklURV9GVyhJTEtfR0RTUiwgSUxLX0dSRE9NX01FRElBIHwgSUxLX0dSRE9NX1JFU0VUX0VO QUJMRSk7Cj4+ICsJcmV0ID0gX19pbnRlbF93YWl0X2Zvcl9yZWdpc3Rlcl9mdyhkZXZfcHJpdiwg SUxLX0dEU1IsCj4+ICsJCQkJCSAgIElMS19HUkRPTV9SRVNFVF9FTkFCTEUsIDAsCj4+ICsJCQkJ CSAgIDUwMDAsIDAsCj4+ICsJCQkJCSAgIE5VTEwpOwo+PiAgIAlpZiAocmV0KSB7Cj4+ICAgCQlE Uk1fREVCVUdfRFJJVkVSKCJXYWl0IGZvciBtZWRpYSByZXNldCBmYWlsZWRcbiIpOwo+PiAgIAkJ Z290byBvdXQ7Cj4+ICAgCX0KPj4gICAKPj4gICBvdXQ6Cj4+IC0JSTkxNV9XUklURShJTEtfR0RT UiwgMCk7Cj4+IC0JUE9TVElOR19SRUFEKElMS19HRFNSKTsKPj4gKwlJOTE1X1dSSVRFX0ZXKElM S19HRFNSLCAwKTsKPj4gKwlQT1NUSU5HX1JFQURfRlcoSUxLX0dEU1IpOwo+PiAgIAlyZXR1cm4g cmV0Owo+PiAgIH0KPj4gICAKPj4gQEAgLTU3Miw3ICs1NzQsOSBAQCBpbnQgaW50ZWxfZ3B1X3Jl c2V0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LCB1bnNpZ25lZCBpbnQgZW5naW5lX21h c2spCj4+ICAgCQlyZXQgPSAtRU5PREVWOwo+PiAgIAkJaWYgKHJlc2V0KSB7Cj4+ICAgCQkJR0VN X1RSQUNFKCJlbmdpbmVfbWFzaz0leFxuIiwgZW5naW5lX21hc2spOwo+PiArCQkJcHJlZW1wdF9k aXNhYmxlKCk7Cj4+ICAgCQkJcmV0ID0gcmVzZXQoaTkxNSwgZW5naW5lX21hc2ssIHJldHJ5KTsK Pj4gKwkJCXByZWVtcHRfZW5hYmxlKCk7Cj4+ICAgCQl9Cj4+ICAgCQlpZiAocmV0ICE9IC1FVElN RURPVVQgfHwgZW5naW5lX21hc2sgIT0gQUxMX0VOR0lORVMpCj4+ICAgCQkJYnJlYWs7Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=