From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 05/23] drm/i915: Issue engine resets onto idle engines Date: Fri, 18 Jan 2019 14:06:32 +0200 Message-ID: <87k1j2w4on.fsf@gaia.fi.intel.com> References: <20190117143519.16086-1-chris@chris-wilson.co.uk> <20190117143519.16086-6-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 30E846E4F1 for ; Fri, 18 Jan 2019 12:08:22 +0000 (UTC) In-Reply-To: <20190117143519.16086-6-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQWx3YXlz IHBlcmZvcm0gdGhlIHJlcXVlc3RlZCByZXNldCwgZXZlbiBpZiB3ZSBiZWxpZXZlIHRoZSBlbmdp bmUgaXMKPiBpZGxlLiBQcmVzdW1hYmx5IHRoZXJlIHdhcyBhIHJlYXNvbiB0aGUgY2FsbGVyIHdh bnRlZCB0aGUgcmVzZXQsIGFuZCBpbgo+IHRoZSBuZWFyIGZ1dHVyZSB3ZSBsb3NlIHRoZSBlYXN5 IHRyYWNraW5nIGZvciB3aGV0aGVyIHRoZSBlbmdpbmUgaXMKPiBpZGxlLgo+Cj4gU2lnbmVkLW9m Zi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVzZXQuYyAgICAgICAgICAgICB8ICA0IC0tLS0KPiAg Li4uL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaW50ZWxfaGFuZ2NoZWNrLmMgIHwgMjIgKysrKyst LS0tLS0tLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMjAgZGVs ZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXNl dC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXNldC5jCj4gaW5kZXggMDY0ZmM2ZGEx NTEyLi5kNDRiMDk1ZTI4NjAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9yZXNldC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXNldC5jCj4gQEAg LTEwNjMsMTAgKzEwNjMsNiBAQCBpbnQgaTkxNV9yZXNldF9lbmdpbmUoc3RydWN0IGludGVsX2Vu Z2luZV9jcyAqZW5naW5lLCBjb25zdCBjaGFyICptc2cpCj4gIAlHRU1fVFJBQ0UoIiVzIGZsYWdz PSVseFxuIiwgZW5naW5lLT5uYW1lLCBlcnJvci0+ZmxhZ3MpOwo+ICAJR0VNX0JVR19PTighdGVz dF9iaXQoSTkxNV9SRVNFVF9FTkdJTkUgKyBlbmdpbmUtPmlkLCAmZXJyb3ItPmZsYWdzKSk7Cj4g IAo+IC0JaWYgKGk5MTVfc2Vxbm9fcGFzc2VkKGludGVsX2VuZ2luZV9nZXRfc2Vxbm8oZW5naW5l KSwKPiAtCQkJICAgICAgaW50ZWxfZW5naW5lX2xhc3Rfc3VibWl0KGVuZ2luZSkpKQo+IC0JCXJl dHVybiAwOwoKCkl0IHNlZW1zIHlvdSByZWluc3RhdGUgdGhpcyBsYXRlciBpbiB0aGlzIHNlcmll cy4gQW5kCnRoaXMgcGF0Y2ggZG9lc24ndCBhcHBseSBhcyB0aGUgaTkxNV9yZXNldF9lbmdpbmUg ZG9lc24ndApoYXZlIHRoZSBpZGxlIGNoZWNrLgoKLU1pa2EKCj4gLQo+ICAJcmVzZXRfcHJlcGFy ZV9lbmdpbmUoZW5naW5lKTsKPiAgCj4gIAlpZiAobXNnKQo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaW50ZWxfaGFuZ2NoZWNrLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9zZWxmdGVzdHMvaW50ZWxfaGFuZ2NoZWNrLmMKPiBpbmRleCAyODE0NGZkNzI1NTAu LjlkMGNjOWQ2M2ExZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVz dHMvaW50ZWxfaGFuZ2NoZWNrLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVz dHMvaW50ZWxfaGFuZ2NoZWNrLmMKPiBAQCAtNDQ5LDggKzQ0OSw2IEBAIHN0YXRpYyBpbnQgX19p Z3RfcmVzZXRfZW5naW5lKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LCBib29sIGFjdGl2 ZSkKPiAgCj4gIAkJc2V0X2JpdChJOTE1X1JFU0VUX0VOR0lORSArIGlkLCAmaTkxNS0+Z3B1X2Vy cm9yLmZsYWdzKTsKPiAgCQlkbyB7Cj4gLQkJCXUzMiBzZXFubyA9IGludGVsX2VuZ2luZV9nZXRf c2Vxbm8oZW5naW5lKTsKPiAtCj4gIAkJCWlmIChhY3RpdmUpIHsKPiAgCQkJCXN0cnVjdCBpOTE1 X3JlcXVlc3QgKnJxOwo+ICAKPiBAQCAtNDc5LDggKzQ3Nyw2IEBAIHN0YXRpYyBpbnQgX19pZ3Rf cmVzZXRfZW5naW5lKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LCBib29sIGFjdGl2ZSkK PiAgCQkJCQlicmVhazsKPiAgCQkJCX0KPiAgCj4gLQkJCQlHRU1fQlVHX09OKCFycS0+Z2xvYmFs X3NlcW5vKTsKPiAtCQkJCXNlcW5vID0gcnEtPmdsb2JhbF9zZXFubyAtIDE7Cj4gIAkJCQlpOTE1 X3JlcXVlc3RfcHV0KHJxKTsKPiAgCQkJfQo+ICAKPiBAQCAtNDk2LDExICs0OTIsMTAgQEAgc3Rh dGljIGludCBfX2lndF9yZXNldF9lbmdpbmUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUs IGJvb2wgYWN0aXZlKQo+ICAJCQkJYnJlYWs7Cj4gIAkJCX0KPiAgCj4gLQkJCXJlc2V0X2VuZ2lu ZV9jb3VudCArPSBhY3RpdmU7Cj4gIAkJCWlmIChpOTE1X3Jlc2V0X2VuZ2luZV9jb3VudCgmaTkx NS0+Z3B1X2Vycm9yLCBlbmdpbmUpICE9Cj4gLQkJCSAgICByZXNldF9lbmdpbmVfY291bnQpIHsK PiAtCQkJCXByX2VycigiJXMgZW5naW5lIHJlc2V0ICVzcmVjb3JkZWQhXG4iLAo+IC0JCQkJICAg ICAgIGVuZ2luZS0+bmFtZSwgYWN0aXZlID8gIm5vdCAiIDogIiIpOwo+ICsJCQkgICAgKytyZXNl dF9lbmdpbmVfY291bnQpIHsKPiArCQkJCXByX2VycigiJXMgZW5naW5lIHJlc2V0IG5vdCByZWNv cmRlZCFcbiIsCj4gKwkJCQkgICAgICAgZW5naW5lLT5uYW1lKTsKPiAgCQkJCWVyciA9IC1FSU5W QUw7Cj4gIAkJCQlicmVhazsKPiAgCQkJfQo+IEBAIC03MjgsNyArNzIzLDYgQEAgc3RhdGljIGlu dCBfX2lndF9yZXNldF9lbmdpbmVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ICAK PiAgCQlzZXRfYml0KEk5MTVfUkVTRVRfRU5HSU5FICsgaWQsICZpOTE1LT5ncHVfZXJyb3IuZmxh Z3MpOwo+ICAJCWRvIHsKPiAtCQkJdTMyIHNlcW5vID0gaW50ZWxfZW5naW5lX2dldF9zZXFubyhl bmdpbmUpOwo+ICAJCQlzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSA9IE5VTEw7Cj4gIAo+ICAJCQlp ZiAoZmxhZ3MgJiBURVNUX0FDVElWRSkgewo+IEBAIC03NTYsOSArNzUwLDYgQEAgc3RhdGljIGlu dCBfX2lndF9yZXNldF9lbmdpbmVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ICAJ CQkJCWVyciA9IC1FSU87Cj4gIAkJCQkJYnJlYWs7Cj4gIAkJCQl9Cj4gLQo+IC0JCQkJR0VNX0JV R19PTighcnEtPmdsb2JhbF9zZXFubyk7Cj4gLQkJCQlzZXFubyA9IHJxLT5nbG9iYWxfc2Vxbm8g LSAxOwo+ICAJCQl9Cj4gIAo+ICAJCQllcnIgPSBpOTE1X3Jlc2V0X2VuZ2luZShlbmdpbmUsIE5V TEwpOwo+IEBAIC03OTUsMTAgKzc4Niw5IEBAIHN0YXRpYyBpbnQgX19pZ3RfcmVzZXRfZW5naW5l cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiAgCj4gIAkJcmVwb3J0ZWQgPSBpOTE1 X3Jlc2V0X2VuZ2luZV9jb3VudCgmaTkxNS0+Z3B1X2Vycm9yLCBlbmdpbmUpOwo+ICAJCXJlcG9y dGVkIC09IHRocmVhZHNbZW5naW5lLT5pZF0ucmVzZXRzOwo+IC0JCWlmIChyZXBvcnRlZCAhPSAo ZmxhZ3MgJiBURVNUX0FDVElWRSA/IGNvdW50IDogMCkpIHsKPiAtCQkJcHJfZXJyKCJpOTE1X3Jl c2V0X2VuZ2luZSglczolcyk6IHJlc2V0ICVsdSB0aW1lcywgYnV0IHJlcG9ydGVkICVsdSwgZXhw ZWN0ZWQgJWx1IHJlcG9ydGVkXG4iLAo+IC0JCQkgICAgICAgZW5naW5lLT5uYW1lLCB0ZXN0X25h bWUsIGNvdW50LCByZXBvcnRlZCwKPiAtCQkJICAgICAgIChmbGFncyAmIFRFU1RfQUNUSVZFID8g Y291bnQgOiAwKSk7Cj4gKwkJaWYgKHJlcG9ydGVkICE9IGNvdW50KSB7Cj4gKwkJCXByX2Vycigi aTkxNV9yZXNldF9lbmdpbmUoJXM6JXMpOiByZXNldCAlbHUgdGltZXMsIGJ1dCByZXBvcnRlZCAl bHVcbiIsCj4gKwkJCSAgICAgICBlbmdpbmUtPm5hbWUsIHRlc3RfbmFtZSwgY291bnQsIHJlcG9y dGVkKTsKPiAgCQkJaWYgKCFlcnIpCj4gIAkJCQllcnIgPSAtRUlOVkFMOwo+ICAJCX0KPiAtLSAK PiAyLjIwLjEKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK