From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2] sysfs: constify sysfs create/remove files harder Date: Tue, 16 Oct 2018 15:10:24 +0300 Message-ID: <87k1miks7j.fsf@intel.com> References: <20181004143750.30880-1-jani.nikula@intel.com> <20181016104845.GB4768@kroah.com> <87pnwakto2.fsf@intel.com> <20181016114347.GA21790@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2CE756E197 for ; Tue, 16 Oct 2018 12:10:44 +0000 (UTC) In-Reply-To: <20181016114347.GA21790@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Greg Kroah-Hartman Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAxNiBPY3QgMjAxOCwgR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3Vu ZGF0aW9uLm9yZz4gd3JvdGU6Cj4gT24gVHVlLCBPY3QgMTYsIDIwMTggYXQgMDI6Mzg6NTNQTSAr MDMwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+IE9uIFR1ZSwgMTYgT2N0IDIwMTgsIEdyZWcgS3Jv YWgtSGFydG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+IHdyb3RlOgo+PiA+IE9uIFRo dSwgT2N0IDA0LCAyMDE4IGF0IDA1OjM3OjQ5UE0gKzAzMDAsIEphbmkgTmlrdWxhIHdyb3RlOgo+ PiA+PiBMZXQgdGhlIHBhc3NlZCBpbiBhcnJheSBiZSBjb25zdCAoYW5kIHRodXMgcGxhY2VkIGlu IHJvZGF0YSkgaW5zdGVhZCBvZgo+PiA+PiBhIG11dGFibGUgYXJyYXkgb2YgY29uc3QgcG9pbnRl cnMuCj4+ID4+IAo+PiA+PiBDYzogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3Vu ZGF0aW9uLm9yZz4KPj4gPj4gQ2M6ICJSYWZhZWwgSi4gV3lzb2NraSIgPHJhZmFlbEBrZXJuZWwu b3JnPgo+PiA+PiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwu Y29tPgo+PiA+PiAtLS0KPj4gPj4gIGZzL3N5c2ZzL2ZpbGUuYyAgICAgICB8IDQgKystLQo+PiA+ PiAgaW5jbHVkZS9saW51eC9zeXNmcy5oIHwgOCArKysrLS0tLQo+PiA+PiAgMiBmaWxlcyBjaGFu Z2VkLCA2IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4+ID4KPj4gPiBSZXZpZXdlZC1i eTogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KPj4gCj4+ IFRoYW5rczsgd2hvIHNob3VsZCBwaWNrIHRoZW0gdXA/Cj4KPiBJIGNvdWxkIHBpY2sgdGhlIGZp cnN0IG9uZSB1cCwgYnV0IGFzIHlvdSBuZWVkIHRoaXMgZm9yIGEgZHJtIHBhdGNoLAo+IGJvdGgg c2hvdWxkIHByb2JhYmx5IGdvIHRocm91Z2ggdGhhdCB0cmVlLCByaWdodD8KCkkgY2FuIHBpY2sg dGhlbSBib3RoIGlmIGl0IGRvZXNuJ3QgYm90aGVyIHlvdSB0aGF0IHRoZSBzeXNmcyBwYXJ0cyB3 aWxsCmJlIG1lcmdlZCBpbiB0aGUgbWVyZ2Ugd2luZG93IGZvciB2NC4yMSBpLmUuIHRoZSBjaGFu Z2Ugd291bGQgYmUgaW4gZHJtCnRyZWVzIGZvciBhbiBlbnRpcmUgcmVsZWFzZSBjeWNsZS4gV2Un dmUgYmVlbiBkb25lIGZvciB2NC4yMCBtZXJnZQp3aW5kb3cgZm9yIGEgd2hpbGUgbm93LgoKQlIs CkphbmkuCgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50 ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A89EC04EBD for ; Tue, 16 Oct 2018 12:10:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4895D2089E for ; Tue, 16 Oct 2018 12:10:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4895D2089E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727146AbeJPUAz (ORCPT ); Tue, 16 Oct 2018 16:00:55 -0400 Received: from mga07.intel.com ([134.134.136.100]:21816 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726718AbeJPUAy (ORCPT ); Tue, 16 Oct 2018 16:00:54 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2018 05:10:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,388,1534834800"; d="scan'208";a="99628267" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.72.61]) by fmsmga001.fm.intel.com with ESMTP; 16 Oct 2018 05:10:42 -0700 From: Jani Nikula To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, "Rafael J. Wysocki" Subject: Re: [PATCH 1/2] sysfs: constify sysfs create/remove files harder In-Reply-To: <20181016114347.GA21790@kroah.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20181004143750.30880-1-jani.nikula@intel.com> <20181016104845.GB4768@kroah.com> <87pnwakto2.fsf@intel.com> <20181016114347.GA21790@kroah.com> Date: Tue, 16 Oct 2018 15:10:24 +0300 Message-ID: <87k1miks7j.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Oct 2018, Greg Kroah-Hartman wrote: > On Tue, Oct 16, 2018 at 02:38:53PM +0300, Jani Nikula wrote: >> On Tue, 16 Oct 2018, Greg Kroah-Hartman wrote: >> > On Thu, Oct 04, 2018 at 05:37:49PM +0300, Jani Nikula wrote: >> >> Let the passed in array be const (and thus placed in rodata) instead of >> >> a mutable array of const pointers. >> >> >> >> Cc: Greg Kroah-Hartman >> >> Cc: "Rafael J. Wysocki" >> >> Signed-off-by: Jani Nikula >> >> --- >> >> fs/sysfs/file.c | 4 ++-- >> >> include/linux/sysfs.h | 8 ++++---- >> >> 2 files changed, 6 insertions(+), 6 deletions(-) >> > >> > Reviewed-by: Greg Kroah-Hartman >> >> Thanks; who should pick them up? > > I could pick the first one up, but as you need this for a drm patch, > both should probably go through that tree, right? I can pick them both if it doesn't bother you that the sysfs parts will be merged in the merge window for v4.21 i.e. the change would be in drm trees for an entire release cycle. We've been done for v4.20 merge window for a while now. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center