From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [RFC 1/3] drm/i915/icl: Restructure ICL DPLL enable
 functionality
Date: Wed, 03 Oct 2018 14:41:28 +0300
Message-ID: <87k1mzqmtz.fsf@intel.com>
References: <1536908054-2176-1-git-send-email-vandita.kulkarni@intel.com>
 <1536908054-2176-2-git-send-email-vandita.kulkarni@intel.com>
 <20180914160655.GJ5565@intel.com> <87pnwrqxbg.fsf@intel.com>
 <87murvqx1o.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id BCF346E44A
 for <intel-gfx@lists.freedesktop.org>; Wed,  3 Oct 2018 11:41:35 +0000 (UTC)
In-Reply-To: <87murvqx1o.fsf@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?utf-8?B?U3lyasOkbMOk?= <ville.syrjala@linux.intel.com>, Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: intel-gfx@lists.freedesktop.org, paulo.r.zanoni@intel.com
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCAwMyBPY3QgMjAxOCwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g
d3JvdGU6Cj4gT24gV2VkLCAwMyBPY3QgMjAxOCwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGlu
dGVsLmNvbT4gd3JvdGU6Cj4+IE9uIEZyaSwgMTQgU2VwIDIwMTgsIFZpbGxlIFN5cmrDpGzDpCA8
dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+Pj4gT24gRnJpLCBTZXAgMTQs
IDIwMTggYXQgMTI6MjQ6MTJQTSArMDUzMCwgVmFuZGl0YSBLdWxrYXJuaSB3cm90ZToKPj4+PiBG
cm9tOiBNYWRoYXYgQ2hhdWhhbiA8bWFkaGF2LmNoYXVoYW5AaW50ZWwuY29tPgo+Pj4+IAo+Pj4+
IEluIEdlbjExLCBEUExMIDAgYW5kIDEgYXJlIHNoYXJlZCBiZXR3ZWVuIERESSBhbmQgRFNJLgo+
Pj4+IE1vc3Qgb2YgdGhlIHN0ZXBzIGZvciBlbmFibGluZyBEUExMIGFyZSBjb21tb24gYWNyb3Nz
IERESQo+Pj4+IGFuZCBEU0kuIFRoaXMgcGF0Y2ggbWFrZXMgaWNsX2RwbGxfZW5hYmxlKCkgZ2Vu
ZXJpYyB3aGljaAo+Pj4+IHdpbGwgYmUgdXNlZCBieSBhbGwgdGhlIGVuY29kZXJzLgo+Pj4+IAo+
Pj4+IFNpZ25lZC1vZmYtYnk6IE1hZGhhdiBDaGF1aGFuIDxtYWRoYXYuY2hhdWhhbkBpbnRlbC5j
b20+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogVmFuZGl0YSBLdWxrYXJuaSA8dmFuZGl0YS5rdWxrYXJu
aUBpbnRlbC5jb20+Cj4+Pj4gLS0tCj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rk
aS5jICAgICAgfCAxMiArKysrKysrKysrKysKPj4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZHBsbF9tZ3IuYyB8IDE5ICsrLS0tLS0tLS0tLS0tLS0tLS0KPj4+PiAgZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaCB8ICAyICstCj4+Pj4gIDMgZmlsZXMgY2hhbmdlZCwg
MTUgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCj4+Pj4gCj4+Pj4gZGlmZiAtLWdpdCBh
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfZGRpLmMKPj4+PiBpbmRleCBjZDAxYTA5Li4yOTQyYTI0IDEwMDY0NAo+Pj4+IC0tLSBh
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4+Pj4gKysrIGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZGRpLmMKPj4+PiBAQCAtMjgxMCw2ICsyODEwLDE4IEBAIHN0YXRpYyB2
b2lkIGludGVsX2RkaV9jbGtfc2VsZWN0KHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+
Pj4+ICAJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPmRwbGxfbG9jayk7Cj4+Pj4gIAo+Pj4+ICAJaWYg
KElTX0lDRUxBS0UoZGV2X3ByaXYpKSB7Cj4+Pj4gKwkJZW51bSBpbnRlbF9kcGxsX2lkIGlkID0g
cGxsLT5pbmZvLT5pZDsKPj4+PiArCQlpOTE1X3JlZ190IGVuYWJsZV9yZWcgPSBpY2xfcGxsX2lk
X3RvX2VuYWJsZV9yZWcoaWQpOwo+Pj4+ICsKPj4+PiArCQl2YWwgPSBJOTE1X1JFQUQoZW5hYmxl
X3JlZyk7Cj4+Pj4gKwkJdmFsIHw9IFBMTF9FTkFCTEU7Cj4+Pj4gKwkJSTkxNV9XUklURShlbmFi
bGVfcmVnLCB2YWwpOwo+Pj4+ICsKPj4+PiArCQkvKiBUT0RPOiB3YWl0IHRpbWVzIG1pc3Npbmcg
ZnJvbSB0aGUgc3BlYy4gKi8KPj4+PiArCQlpZiAoaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2
X3ByaXYsIGVuYWJsZV9yZWcsIFBMTF9MT0NLLAo+Pj4+ICsJCQkJCSAgICBQTExfTE9DSywgNSkp
Cj4+Pj4gKwkJCURSTV9FUlJPUigiUExMICVkIG5vdCBsb2NrZWRcbiIsIGlkKTsKPj4+PiArCj4+
Pgo+Pj4gSSBkb24ndCByZWFsbHkgc2VlIHdoeSB0aGlzIGNhbid0IHN0YXkgaW4gdGhlIGRwbGwg
bWdyLgo+Pgo+PiBBZ3JlZWQsIEkgdGhpbmsgaXQgc2hvdWxkIHN0YXkgaW4gRFBMTCBtYW5hZ2Vy
Lgo+Pgo+PiBUaGUgdGhpbmcgaXMsIERQTEwgZW5hYmxpbmcgZm9yIERTSSByZXF1aXJlcyBlbmNv
ZGVyIHNwZWNpZmljIHN0ZXBzIGluCj4+IHRoZSBtaWRkbGUgb2YgdGhlIHNlcXVlbmNlIGhpZGRl
biBpbiBEUExMIG1hbmFnZXIuIEl0J3Mgbm90IHByZXR0eSB0bwo+PiBhZGQgdGhhdCBpbiBEUExM
IG1hbmFnZXIuCj4+Cj4+IE9uZSBhcHByb2FjaCBtaWdodCBiZSB0byBhZGQgZW5jb2RlciBob29r
cyB0byBjYWxsIGZyb20gdGhlIHJpZ2h0IHNwb3QKPj4gaW4gdGhlIERQTEwgbWFuYWdlciwgIm1p
ZF9wbGxfZW5hYmxlIi4gSXQncyBhbm5veWluZyBiZWNhdXNlIGl0IHdvdWxkCj4+IGhhdmUgdG8g
aGFwcGVuIGluIHRoZSBtaWRkbGUgb2YgdGhlIHBsYXRmb3JtIHNwZWNpZmljIERQTEwgbWFuYWdl
cgo+PiBwbGwtPmluZm8tPmZ1bmNzLT5lbmFibGUgaG9vay4gV2UnZCBoYXZlIHRvIGNhbGwgdGhl
IGhvb2tzIGZyb20gcGxhdGZvcm0KPj4gc3BlY2lmaWMgY29kZSwgb3Igc3BsaXQgdGhvc2UgaG9v
a3MgaW4gdHdvLiBUaGUgZm9ybWVyIGlzIHVnbHkgYmVjYXVzZQo+PiBpdCByZXF1aXJlcyBwYXNz
aW5nIGNydGMgdG8gdGhlIHBsbCBlbmFibGUgaG9vay4gU28gSSBndWVzcyBhZGQgYSBwbGwKPj4g
cG9zdCBlbmFibGUgaG9vay4KPj4KPj4gQmVsb3cncyBzb21lIGRyYWZ0IGNvZGUgdG8gZ2l2ZSBh
biBpZGVhIHdoYXQgSSBtZWFuLiBZb3UnZCBtb3ZlIHRoZQo+PiBhYm92ZSBodW5rIHRvIHRoZSBw
b3N0IGhvb2sgaW5zdGVhZC4KPj4KPj4gU28gdGhlbiB3ZSdkIGFkZCBtaWRfcGxsX2VuYWJsZSBo
b29rcyBhbmQgZG8gdGhlIHJlcXVpcmVkIG1hZ2ljIGluIHRoZQo+PiBEU0kgbWlkIHBsbCBob29r
Lgo+Cj4gUFMuIEFuZCBldmVuIHdpdGggdGhpcyBJJ20gbm90IHlldCBzdXJlIGlmIHdlIGNhbiBk
byB0aGUgb3ZlcmFsbCBEUExMCj4gZW5hYmxpbmcgYXQgdGhlIHJpZ2h0IHNwb3Qgd3J0IGJzcGVj
IERTSSBtb2RlIHNldCBzZXF1ZW5jZS4gKmNyaW5nZSouCgpWaWxsZSByZW1pbmRlZCBtZSB0aGF0
IHdlIGRpZCBoYXZlIHRoaXMgaWRlYSBvZiBwdXNoaW5nIHBsbCBlbmFibGUgY2FsbHMKZG93biB0
byBlbmNvZGVycyBvbiBEREkgcGxhdGZvcm1zLiBUaGlzIHdvdWxkIGhlbHAsIG9mIGNvdXJzZS4K
CkJSLApKYW5pLgoKCj4KPiBCUiwKPiBKYW5pLgo+Cj4+Cj4+IE92ZXJhbGwgSSdtIHN0YXJ0aW5n
IHRvIGZlZWwgdGhlIGFwcGVhbCBvZiBkcml2aW5nIG1vZGVzZXQgZnJvbQo+PiBlbmNvZGVycywg
d2l0aCBsaWJyYXJ5IHN0eWxlIGhlbHBlcnMgcHJvdmlkZWQgZnJvbSBpbnRlbF9kaXNwbGF5LmMs
Cj4+IGluc3RlYWQgb2YgYWRkaW5nIG1vcmUgYW5kIG1vcmUgZW5jb2RlciBob29rcyB0byBkbyBz
dHVmZiBhdCBzcGVjaWZpYwo+PiBwbGFjZXMuIEJ1dCBJIGRpZ3Jlc3MuCj4+Cj4+IEJSLAo+PiBK
YW5pLgo+Pgo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBs
bF9tZ3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPj4gaW5kZXgg
ZTZjYWM5MjI1NTM2Li5hNGNhMWI0YTEyNGMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZHBsbF9tZ3IuYwo+PiBAQCAtMTkxLDYgKzE5MSwxMiBAQCB2b2lkIGludGVsX2VuYWJsZV9z
aGFyZWRfZHBsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPj4gIAo+PiAgCURSTV9ERUJVR19L
TVMoImVuYWJsaW5nICVzXG4iLCBwbGwtPmluZm8tPm5hbWUpOwo+PiAgCXBsbC0+aW5mby0+ZnVu
Y3MtPmVuYWJsZShkZXZfcHJpdiwgcGxsKTsKPj4gKwo+PiArCWludGVsX2VuY29kZXJzX21pZF9w
bGxfZW5hYmxlKGNydGMpOyAvKiBwaXBlX2NvbmZpZywgb2xkX3N0YXRlPyAqLwo+PiArCj4+ICsJ
aWYgKHBsbC0+aW5mby0+ZnVuY3MtPnBvc3RfZW5hYmxlKQo+PiArCQlwbGwtPmluZm8tPmZ1bmNz
LT5wb3N0X2VuYWJsZShkZXZfcHJpdiwgcGxsKTsKPj4gKwo+PiAgCXBsbC0+b24gPSB0cnVlOwo+
PiAgCj4+ICBvdXQ6Cj4+IEBAIC0zMTk5LDYgKzMyMDUsNyBAQCBzdGF0aWMgdm9pZCBpY2xfZHVt
cF9od19zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICAKPj4gIHN0
YXRpYyBjb25zdCBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGxfZnVuY3MgaWNsX3BsbF9mdW5jcyA9
IHsKPj4gIAkuZW5hYmxlID0gaWNsX3BsbF9lbmFibGUsCj4+ICsJLnBvc3RfZW5hYmxlID0gaWNs
X3BsbF9wb3N0X2VuYWJsZSwKPj4gIAkuZGlzYWJsZSA9IGljbF9wbGxfZGlzYWJsZSwKPj4gIAku
Z2V0X2h3X3N0YXRlID0gaWNsX3BsbF9nZXRfaHdfc3RhdGUsCj4+ICB9Owo+PiBkaWZmIC0tZ2l0
IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaCBiL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2RwbGxfbWdyLmgKPj4gaW5kZXggYmYwZGU4YTRkYzYzLi5lY2VlZWYzYjg4
NzIgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmgK
Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAo+PiBAQCAtMjMx
LDYgKzIzMSwxNiBAQCBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGxfZnVuY3Mgewo+PiAgCQkgICAg
ICAgc3RydWN0IGludGVsX3NoYXJlZF9kcGxsICpwbGwpOwo+PiAgCj4+ICAJLyoqCj4+ICsJICog
QHBvc3RfZW5hYmxlOgo+PiArCSAqCj4+ICsJICogT3B0aW9uYWwgaG9vayB0byBjYWxsIGFmdGVy
IGVuY29kZXIgc3BlY2lmaWMgbWlkIHBsbCBob29rcyBoYXZlIGJlZW4KPj4gKwkgKiBjYWxsZWQg
ZnJvbSBpbnRlbF9lbmFibGVfc2hhcmVkX2RwbGwoKS4KPj4gKwkgKi8KPj4gKwl2b2lkICgqcG9z
dF9lbmFibGUpKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gKwkJCSAgICBz
dHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbCk7Cj4+ICsKPj4gKwo+PiArCS8qKgo+PiAgCSAq
IEBkaXNhYmxlOgo+PiAgCSAqCj4+ICAJICogSG9vayBmb3IgZGlzYWJsaW5nIHRoZSBwbGwsIGNh
bGxlZCBmcm9tIGludGVsX2Rpc2FibGVfc2hhcmVkX2RwbGwoKQoKLS0gCkphbmkgTmlrdWxhLCBJ
bnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA
bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt
YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==