From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.toke.dk ([52.28.52.200]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g6C8v-0004Jr-UD for ath10k@lists.infradead.org; Sat, 29 Sep 2018 10:06:36 +0000 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [RFC v2 1/2] ath10k: migrate to mac80211 txq scheduling In-Reply-To: <1538176574-5580-1-git-send-email-rmanohar@codeaurora.org> References: <1538176574-5580-1-git-send-email-rmanohar@codeaurora.org> Date: Sat, 29 Sep 2018 12:06:13 +0200 Message-ID: <87k1n4botm.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Rajkumar Manoharan , ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org UmFqa3VtYXIgTWFub2hhcmFuIDxybWFub2hhckBjb2RlYXVyb3JhLm9yZz4gd3JpdGVzOgoKPiBh dGgxMGsgbWFpbnRhaW5zIGNvbW1vbiB0eHFzIGxpc3QgZm9yIGFsbCBzdGF0aW9ucy4gVGhpcyB0 eHEKPiBtYW5hZ2VtZW50IGNhbiBiZSByZW1vdmVkIGJ5IG1pZ3JhdGluZyB0byBtYWM4MDIxMSB0 eHEgQVBJcwo+IGFuZCBsZXQgbWFjODAyMTEgaGFuZGxlIHR4cXMgcmVvcmRlcmluZyBiYXNlZCBv biByZXBvcnRlZCBhaXJ0aW1lLgo+IEJ5IGRvaW5nIHRoaXMsIHR4cSBmYWlybmVzcyBtYWludGFp bmVkIGluIGF0aDEwayBpLmUgcHJvY2Vzc2luZwo+IE4gZnJhbWVzIHBlciB0eHEgaXMgcmVtb3Zl ZC4gQnkgYWRhcHRpbmcgdG8gbWFjODAyMTEgQVBJcywKPiBhdGgxMGsgd2lsbCBzdXBwb3J0IG1h YzgwMjExIGJhc2VkIGFpcnRpbWUgZmFpcm5lc3MgYWxnb3JpdGhtLgo+Cj4gU2lnbmVkLW9mZi1i eTogVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHRva2UuZGs+Cj4gU2lnbmVkLW9mZi1i eTogUmFqa3VtYXIgTWFub2hhcmFuIDxybWFub2hhckBjb2RlYXVyb3JhLm9yZz4KPiAtLS0KPiAg ZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9jb3JlLmMgICB8ICAyIC0KPiAgZHJpdmVy cy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9jb3JlLmggICB8ICAzIC0tCj4gIGRyaXZlcnMvbmV0 L3dpcmVsZXNzL2F0aC9hdGgxMGsvaHRjLmggICAgfCAgMSAtCj4gIGRyaXZlcnMvbmV0L3dpcmVs ZXNzL2F0aC9hdGgxMGsvaHR0X3J4LmMgfCAgOCArKysKPiAgZHJpdmVycy9uZXQvd2lyZWxlc3Mv YXRoL2F0aDEway9tYWMuYyAgICB8IDkyICsrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0t Cj4gIDUgZmlsZXMgY2hhbmdlZCwgNDUgaW5zZXJ0aW9ucygrKSwgNjEgZGVsZXRpb25zKC0pCj4K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9jb3JlLmMgYi9k cml2ZXJzL25ldC93aXJlbGVzcy9hdGgvYXRoMTBrL2NvcmUuYwo+IGluZGV4IGNmM2M0N2I4Y2Iy ZC4uMDY4NGY4N2FiYzliIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9h dGgxMGsvY29yZS5jCj4gKysrIGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9jb3Jl LmMKPiBAQCAtMzA2OCw5ICszMDY4LDcgQEAgc3RydWN0IGF0aDEwayAqYXRoMTBrX2NvcmVfY3Jl YXRlKHNpemVfdCBwcml2X3NpemUsIHN0cnVjdCBkZXZpY2UgKmRldiwKPiAgCj4gIAltdXRleF9p bml0KCZhci0+Y29uZl9tdXRleCk7Cj4gIAlzcGluX2xvY2tfaW5pdCgmYXItPmRhdGFfbG9jayk7 Cj4gLQlzcGluX2xvY2tfaW5pdCgmYXItPnR4cXNfbG9jayk7Cj4gIAo+IC0JSU5JVF9MSVNUX0hF QUQoJmFyLT50eHFzKTsKPiAgCUlOSVRfTElTVF9IRUFEKCZhci0+cGVlcnMpOwo+ICAJaW5pdF93 YWl0cXVldWVfaGVhZCgmYXItPnBlZXJfbWFwcGluZ193cSk7Cj4gIAlpbml0X3dhaXRxdWV1ZV9o ZWFkKCZhci0+aHR0LmVtcHR5X3R4X3dxKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvd2ly ZWxlc3MvYXRoL2F0aDEway9jb3JlLmggYi9kcml2ZXJzL25ldC93aXJlbGVzcy9hdGgvYXRoMTBr L2NvcmUuaAo+IGluZGV4IGY2ZTVjMjlmNzRlNy4uZDNlMjBhYWY4MDIzIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvY29yZS5oCj4gKysrIGIvZHJpdmVycy9u ZXQvd2lyZWxlc3MvYXRoL2F0aDEway9jb3JlLmgKPiBAQCAtMTA1NCwxMCArMTA1NCw3IEBAIHN0 cnVjdCBhdGgxMGsgewo+ICAKPiAgCS8qIHByb3RlY3RzIHNoYXJlZCBzdHJ1Y3R1cmUgZGF0YSAq Lwo+ICAJc3BpbmxvY2tfdCBkYXRhX2xvY2s7Cj4gLQkvKiBwcm90ZWN0czogYXItPnR4cXMsIGFy dHhxLT5saXN0ICovCj4gLQlzcGlubG9ja190IHR4cXNfbG9jazsKPiAgCj4gLQlzdHJ1Y3QgbGlz dF9oZWFkIHR4cXM7Cj4gIAlzdHJ1Y3QgbGlzdF9oZWFkIGFydmlmczsKPiAgCXN0cnVjdCBsaXN0 X2hlYWQgcGVlcnM7Cj4gIAlzdHJ1Y3QgYXRoMTBrX3BlZXIgKnBlZXJfbWFwW0FUSDEwS19NQVhf TlVNX1BFRVJfSURTXTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0 aDEway9odGMuaCBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvaHRjLmgKPiBpbmRl eCA1MWZkYTZjMjNmNjkuLmNiMzBhZGQ3ZGQzMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL25ldC93 aXJlbGVzcy9hdGgvYXRoMTBrL2h0Yy5oCj4gKysrIGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRo L2F0aDEway9odGMuaAo+IEBAIC01MSw3ICs1MSw2IEBACj4gICAqLwo+ICAKPiAgI2RlZmluZSBI VENfSE9TVF9NQVhfTVNHX1BFUl9SWF9CVU5ETEUgICAgICAgIDgKPiAtI2RlZmluZSBIVENfSE9T VF9NQVhfTVNHX1BFUl9UWF9CVU5ETEUgICAgICAgIDE2Cj4gIAo+ICBlbnVtIGF0aDEwa19odGNf dHhfZmxhZ3Mgewo+ICAJQVRIMTBLX0hUQ19GTEFHX05FRURfQ1JFRElUX1VQREFURSA9IDB4MDEs Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvaHR0X3J4LmMg Yi9kcml2ZXJzL25ldC93aXJlbGVzcy9hdGgvYXRoMTBrL2h0dF9yeC5jCj4gaW5kZXggZjI0MDUy NThhNmQzLi5mMmFhYTJmN2EwMjIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9uZXQvd2lyZWxlc3Mv YXRoL2F0aDEway9odHRfcnguYwo+ICsrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgx MGsvaHR0X3J4LmMKPiBAQCAtMjM3OSw2ICsyMzc5LDcgQEAgc3RhdGljIHZvaWQgYXRoMTBrX2h0 dF9yeF90eF9mZXRjaF9pbmQoc3RydWN0IGF0aDEwayAqYXIsIHN0cnVjdCBza19idWZmICpza2Ip Cj4gIAl1OCB0aWQ7Cj4gIAlpbnQgcmV0Owo+ICAJaW50IGk7Cj4gKwlib29sIG1heV90eDsKPiAg Cj4gIAlhdGgxMGtfZGJnKGFyLCBBVEgxMEtfREJHX0hUVCwgImh0dCByeCB0eCBmZXRjaCBpbmRc biIpOwo+ICAKPiBAQCAtMjQ1MSw4ICsyNDUyLDEzIEBAIHN0YXRpYyB2b2lkIGF0aDEwa19odHRf cnhfdHhfZmV0Y2hfaW5kKHN0cnVjdCBhdGgxMGsgKmFyLCBzdHJ1Y3Qgc2tfYnVmZiAqc2tiKQo+ ICAJCW51bV9tc2R1cyA9IDA7Cj4gIAkJbnVtX2J5dGVzID0gMDsKPiAgCj4gKwkJaWVlZTgwMjEx X3R4cV9zY2hlZHVsZV9zdGFydChodywgdHhxLT5hYyk7Cj4gKwkJbWF5X3R4ID0gaWVlZTgwMjEx X3R4cV9tYXlfdHJhbnNtaXQoaHcsIHR4cSk7Cj4gIAkJd2hpbGUgKG51bV9tc2R1cyA8IG1heF9u dW1fbXNkdXMgJiYKPiAgCQkgICAgICAgbnVtX2J5dGVzIDwgbWF4X251bV9ieXRlcykgewo+ICsJ CQlpZiAoIW1heV90eCkKPiArCQkJCWJyZWFrOwo+ICsKPiAgCQkJcmV0ID0gYXRoMTBrX21hY190 eF9wdXNoX3R4cShodywgdHhxKTsKPiAgCQkJaWYgKHJldCA8IDApCj4gIAkJCQlicmVhazsKPiBA QCAtMjQ2MCw2ICsyNDY2LDggQEAgc3RhdGljIHZvaWQgYXRoMTBrX2h0dF9yeF90eF9mZXRjaF9p bmQoc3RydWN0IGF0aDEwayAqYXIsIHN0cnVjdCBza19idWZmICpza2IpCj4gIAkJCW51bV9tc2R1 cysrOwo+ICAJCQludW1fYnl0ZXMgKz0gcmV0Owo+ICAJCX0KPiArCQlpZWVlODAyMTFfcmV0dXJu X3R4cShodywgdHhxKTsKPiArCQlpZWVlODAyMTFfdHhxX3NjaGVkdWxlX2VuZChodywgdHhxLT5h Yyk7Cj4gIAo+ICAJCXJlY29yZC0+bnVtX21zZHVzID0gY3B1X3RvX2xlMTYobnVtX21zZHVzKTsK PiAgCQlyZWNvcmQtPm51bV9ieXRlcyA9IGNwdV90b19sZTMyKG51bV9ieXRlcyk7Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvbWFjLmMgYi9kcml2ZXJzL25l dC93aXJlbGVzcy9hdGgvYXRoMTBrL21hYy5jCj4gaW5kZXggOTc1NDhmOTZhMmY3Li4zYjQ0MTE3 OWEzNmMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9tYWMu Ywo+ICsrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvbWFjLmMKPiBAQCAtMzg3 NCw3ICszODc0LDYgQEAgc3RhdGljIHZvaWQgYXRoMTBrX21hY190eHFfaW5pdChzdHJ1Y3QgaWVl ZTgwMjExX3R4cSAqdHhxKQo+ICAKPiAgc3RhdGljIHZvaWQgYXRoMTBrX21hY190eHFfdW5yZWYo c3RydWN0IGF0aDEwayAqYXIsIHN0cnVjdCBpZWVlODAyMTFfdHhxICp0eHEpCj4gIHsKPiAtCXN0 cnVjdCBhdGgxMGtfdHhxICphcnR4cTsKPiAgCXN0cnVjdCBhdGgxMGtfc2tiX2NiICpjYjsKPiAg CXN0cnVjdCBza19idWZmICptc2R1Owo+ICAJaW50IG1zZHVfaWQ7Cj4gQEAgLTM4ODIsMTIgKzM4 ODEsNiBAQCBzdGF0aWMgdm9pZCBhdGgxMGtfbWFjX3R4cV91bnJlZihzdHJ1Y3QgYXRoMTBrICph ciwgc3RydWN0IGllZWU4MDIxMV90eHEgKnR4cSkKPiAgCWlmICghdHhxKQo+ICAJCXJldHVybjsK PiAgCj4gLQlhcnR4cSA9ICh2b2lkICopdHhxLT5kcnZfcHJpdjsKPiAtCXNwaW5fbG9ja19iaCgm YXItPnR4cXNfbG9jayk7Cj4gLQlpZiAoIWxpc3RfZW1wdHkoJmFydHhxLT5saXN0KSkKPiAtCQls aXN0X2RlbF9pbml0KCZhcnR4cS0+bGlzdCk7Cj4gLQlzcGluX3VubG9ja19iaCgmYXItPnR4cXNf bG9jayk7Cj4gLQo+ICAJc3Bpbl9sb2NrX2JoKCZhci0+aHR0LnR4X2xvY2spOwo+ICAJaWRyX2Zv cl9lYWNoX2VudHJ5KCZhci0+aHR0LnBlbmRpbmdfdHgsIG1zZHUsIG1zZHVfaWQpIHsKPiAgCQlj YiA9IEFUSDEwS19TS0JfQ0IobXNkdSk7Cj4gQEAgLTM5MjcsNyArMzkyMCw2IEBAIHN0YXRpYyBi b29sIGF0aDEwa19tYWNfdHhfY2FuX3B1c2goc3RydWN0IGllZWU4MDIxMV9odyAqaHcsCj4gIAlz dHJ1Y3QgYXRoMTBrX3R4cSAqYXJ0eHEgPSAodm9pZCAqKXR4cS0+ZHJ2X3ByaXY7Cj4gIAo+ICAJ LyogTm8gbmVlZCB0byBnZXQgbG9ja3MgKi8KPiAtCj4gIAlpZiAoYXItPmh0dC50eF9xX3N0YXRl Lm1vZGUgPT0gSFRUX1RYX01PREVfU1dJVENIX1BVU0gpCj4gIAkJcmV0dXJuIHRydWU7Cj4gIAo+ IEBAIC00MDE0LDQ4ICs0MDA2LDQ0IEBAIGludCBhdGgxMGtfbWFjX3R4X3B1c2hfdHhxKHN0cnVj dCBpZWVlODAyMTFfaHcgKmh3LAo+ICAJcmV0dXJuIHNrYl9sZW47Cj4gIH0KPiAgCj4gLXZvaWQg YXRoMTBrX21hY190eF9wdXNoX3BlbmRpbmcoc3RydWN0IGF0aDEwayAqYXIpCj4gK3N0YXRpYyBp bnQgYXRoMTBrX21hY19zY2hlZHVsZV90eHEoc3RydWN0IGllZWU4MDIxMV9odyAqaHcsIHUzMiBh YykKPiAgewo+IC0Jc3RydWN0IGllZWU4MDIxMV9odyAqaHcgPSBhci0+aHc7Cj4gIAlzdHJ1Y3Qg aWVlZTgwMjExX3R4cSAqdHhxOwo+IC0Jc3RydWN0IGF0aDEwa190eHEgKmFydHhxOwo+IC0Jc3Ry dWN0IGF0aDEwa190eHEgKmxhc3Q7Cj4gLQlpbnQgcmV0Owo+IC0JaW50IG1heDsKPiAtCj4gLQlp ZiAoYXItPmh0dC5udW1fcGVuZGluZ190eCA+PSAoYXItPmh0dC5tYXhfbnVtX3BlbmRpbmdfdHgg LyAyKSkKPiAtCQlyZXR1cm47Cj4gLQo+IC0Jc3Bpbl9sb2NrX2JoKCZhci0+dHhxc19sb2NrKTsK PiAtCXJjdV9yZWFkX2xvY2soKTsKPiAtCj4gLQlsYXN0ID0gbGlzdF9sYXN0X2VudHJ5KCZhci0+ dHhxcywgc3RydWN0IGF0aDEwa190eHEsIGxpc3QpOwo+IC0Jd2hpbGUgKCFsaXN0X2VtcHR5KCZh ci0+dHhxcykpIHsKPiAtCQlhcnR4cSA9IGxpc3RfZmlyc3RfZW50cnkoJmFyLT50eHFzLCBzdHJ1 Y3QgYXRoMTBrX3R4cSwgbGlzdCk7Cj4gLQkJdHhxID0gY29udGFpbmVyX29mKCh2b2lkICopYXJ0 eHEsIHN0cnVjdCBpZWVlODAyMTFfdHhxLAo+IC0JCQkJICAgZHJ2X3ByaXYpOwo+ICsJaW50IHJl dCA9IDA7Cj4gIAo+IC0JCS8qIFByZXZlbnQgYWdncmVzc2l2ZSBzdGEvdGlkIHRha2luZyBvdmVy IHR4IHF1ZXVlICovCj4gLQkJbWF4ID0gSFRDX0hPU1RfTUFYX01TR19QRVJfVFhfQlVORExFOwo+ IC0JCXJldCA9IDA7Cj4gLQkJd2hpbGUgKGF0aDEwa19tYWNfdHhfY2FuX3B1c2goaHcsIHR4cSkg JiYgbWF4LS0pIHsKPiArCWllZWU4MDIxMV90eHFfc2NoZWR1bGVfc3RhcnQoaHcsIGFjKTsKPiAr CXdoaWxlICgodHhxID0gaWVlZTgwMjExX25leHRfdHhxKGh3LCBhYykpKSB7Cj4gKwkJd2hpbGUg KGF0aDEwa19tYWNfdHhfY2FuX3B1c2goaHcsIHR4cSkpIHsKPiAgCQkJcmV0ID0gYXRoMTBrX21h Y190eF9wdXNoX3R4cShodywgdHhxKTsKPiAgCQkJaWYgKHJldCA8IDApCj4gIAkJCQlicmVhazsK PiAgCQl9Cj4gKwkJaWVlZTgwMjExX3JldHVybl90eHEoaHcsIHR4cSk7Cj4gKwkJYXRoMTBrX2h0 dF90eF90eHFfdXBkYXRlKGh3LCB0eHEpOwo+ICsJCWlmIChyZXQgPT0gLUVCVVNZKQo+ICsJCQli cmVhazsKPiArCX0KPiArCWllZWU4MDIxMV90eHFfc2NoZWR1bGVfZW5kKGh3LCBhYyk7Cj4gIAo+ IC0JCWxpc3RfZGVsX2luaXQoJmFydHhxLT5saXN0KTsKPiAtCQlpZiAocmV0ICE9IC1FTk9FTlQp Cj4gLQkJCWxpc3RfYWRkX3RhaWwoJmFydHhxLT5saXN0LCAmYXItPnR4cXMpOwo+ICsJcmV0dXJu IHJldDsKPiArfQo+ICAKPiAtCQlhdGgxMGtfaHR0X3R4X3R4cV91cGRhdGUoaHcsIHR4cSk7Cj4g K3ZvaWQgYXRoMTBrX21hY190eF9wdXNoX3BlbmRpbmcoc3RydWN0IGF0aDEwayAqYXIpCj4gK3sK PiArCXN0cnVjdCBpZWVlODAyMTFfaHcgKmh3ID0gYXItPmh3Owo+ICsJdTMyIGFjOwo+ICsKPiAr CWlmIChhci0+aHR0Lm51bV9wZW5kaW5nX3R4ID49IChhci0+aHR0Lm1heF9udW1fcGVuZGluZ190 eCAvIDIpKQo+ICsJCXJldHVybjsKPiAgCj4gLQkJaWYgKGFydHhxID09IGxhc3QgfHwgKHJldCA8 IDAgJiYgcmV0ICE9IC1FTk9FTlQpKQo+ICsJcmN1X3JlYWRfbG9jaygpOwo+ICsKPiArCWZvciAo YWMgPSAwOyBhYyA8IElFRUU4MDIxMV9OVU1fQUNTOyBhYysrKSB7Cj4gKwkJaWYgKGF0aDEwa19t YWNfc2NoZWR1bGVfdHhxKGh3LCBhYykgPT0gLUVCVVNZKQo+ICAJCQlicmVhazsKPiAgCX0KPiAg Cj4gIAlyY3VfcmVhZF91bmxvY2soKTsKPiAtCXNwaW5fdW5sb2NrX2JoKCZhci0+dHhxc19sb2Nr KTsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGF0aDEwa19tYWNfdHhfcHVzaF9wZW5kaW5nKTsKPiAg Cj4gQEAgLTQyOTMsMzEgKzQyODEsMjUgQEAgc3RhdGljIHZvaWQgYXRoMTBrX21hY19vcF90eChz dHJ1Y3QgaWVlZTgwMjExX2h3ICpodywKPiAgc3RhdGljIHZvaWQgYXRoMTBrX21hY19vcF93YWtl X3R4X3F1ZXVlKHN0cnVjdCBpZWVlODAyMTFfaHcgKmh3LAo+ICAJCQkJCXN0cnVjdCBpZWVlODAy MTFfdHhxICp0eHEpCj4gIHsKPiAtCXN0cnVjdCBhdGgxMGsgKmFyID0gaHctPnByaXY7Cj4gLQlz dHJ1Y3QgYXRoMTBrX3R4cSAqYXJ0eHEgPSAodm9pZCAqKXR4cS0+ZHJ2X3ByaXY7Cj4gLQlzdHJ1 Y3QgaWVlZTgwMjExX3R4cSAqZl90eHE7Cj4gLQlzdHJ1Y3QgYXRoMTBrX3R4cSAqZl9hcnR4cTsK PiArCXU4IGFjID0gdHhxLT5hYzsKPiAgCWludCByZXQgPSAwOwo+IC0JaW50IG1heCA9IEhUQ19I T1NUX01BWF9NU0dfUEVSX1RYX0JVTkRMRTsKPiAtCj4gLQlzcGluX2xvY2tfYmgoJmFyLT50eHFz X2xvY2spOwo+IC0JaWYgKGxpc3RfZW1wdHkoJmFydHhxLT5saXN0KSkKPiAtCQlsaXN0X2FkZF90 YWlsKCZhcnR4cS0+bGlzdCwgJmFyLT50eHFzKTsKPiAgCj4gLQlmX2FydHhxID0gbGlzdF9maXJz dF9lbnRyeSgmYXItPnR4cXMsIHN0cnVjdCBhdGgxMGtfdHhxLCBsaXN0KTsKPiAtCWZfdHhxID0g Y29udGFpbmVyX29mKCh2b2lkICopZl9hcnR4cSwgc3RydWN0IGllZWU4MDIxMV90eHEsIGRydl9w cml2KTsKPiAtCWxpc3RfZGVsX2luaXQoJmZfYXJ0eHEtPmxpc3QpOwo+ICsJaWVlZTgwMjExX3R4 cV9zY2hlZHVsZV9zdGFydChodywgYWMpOwo+ICsJdHhxID0gaWVlZTgwMjExX25leHRfdHhxKGh3 LCBhYyk7Cj4gKwlpZWVlODAyMTFfdHhxX3NjaGVkdWxlX2VuZChodywgYWMpOwoKWW91IHNob3Vs ZCByZWFsbHkgZGVmZXIgdGhpcyBzY2hlZHVsZV9lbmQoKSB1bnRpbCB0aGUgc2NoZWR1bGluZyBl cGlzb2RlCmFjdHVhbGx5LCB5J2tub3csIGVuZHMuLi4gOikKCj4gKwlpZiAoIXR4cSkKPiArCQly ZXR1cm47Cj4gIAo+IC0Jd2hpbGUgKGF0aDEwa19tYWNfdHhfY2FuX3B1c2goaHcsIGZfdHhxKSAm JiBtYXgtLSkgewo+IC0JCXJldCA9IGF0aDEwa19tYWNfdHhfcHVzaF90eHEoaHcsIGZfdHhxKTsK PiArCXdoaWxlIChhdGgxMGtfbWFjX3R4X2Nhbl9wdXNoKGh3LCB0eHEpKSB7Cj4gKwkJcmV0ID0g YXRoMTBrX21hY190eF9wdXNoX3R4cShodywgdHhxKTsKPiAgCQlpZiAocmV0IDwgMCkKPiAgCQkJ YnJlYWs7Cj4gIAl9Cj4gLQlpZiAocmV0ICE9IC1FTk9FTlQpCj4gLQkJbGlzdF9hZGRfdGFpbCgm Zl9hcnR4cS0+bGlzdCwgJmFyLT50eHFzKTsKPiAtCXNwaW5fdW5sb2NrX2JoKCZhci0+dHhxc19s b2NrKTsKPiAtCj4gLQlhdGgxMGtfaHR0X3R4X3R4cV91cGRhdGUoaHcsIGZfdHhxKTsKPiArCWlm IChyZXQgPT0gLUVCVVNZKSB7Cj4gKwkJaWVlZTgwMjExX3R4cV9zY2hlZHVsZV9zdGFydChodywg YWMpOwo+ICsJCWllZWU4MDIxMV9yZXR1cm5fdHhxKGh3LCB0eHEpOwo+ICsJCWllZWU4MDIxMV90 eHFfc2NoZWR1bGVfZW5kKGh3LCBhYyk7Cj4gKwl9CgpBbmQgaWVlZTgwMjExX3JldHVybl90eHEo KSBzaG91bGQgYmUgY2FsbGVkIHJlZ2FyZGxlc3Mgb2YgdGhlIHJldHVybgpjb2RlIChpdCdsbCBk byBpdCdzIG93biBjaGVja2luZyBhbmQgZG8gbm90aGluZyBpZiB0aGUgcXVldWUgaXMgZW1wdHkp LgoKCi1Ub2tlCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFF19C43143 for ; Sat, 29 Sep 2018 10:06:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40739206B2 for ; Sat, 29 Sep 2018 10:06:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toke.dk header.i=@toke.dk header.b="b9rO9yjQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40739206B2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=toke.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727854AbeI2QeF (ORCPT ); Sat, 29 Sep 2018 12:34:05 -0400 Received: from mail.toke.dk ([52.28.52.200]:48891 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727761AbeI2QeF (ORCPT ); Sat, 29 Sep 2018 12:34:05 -0400 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1538215573; bh=HDoStnazTwk9rhUNxlaGetxPNZjh7LCyAmJE4FgxHMc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=b9rO9yjQQkVV4c3FivU7/gGcgtlGGp5onn1lmd1e1WPA2uYXnYmJ14mghsX6Jl+fP RYjyVeXTLs+N3G0upNvOLW/Uq72+/9JI+kQwNraySxSyvAvgoaQj21VPoU3dAfHD2J fwLoY6adNth6ij33CYVMpWCz9R+HUhncinBWEw9DWmq35Aj5PYWNnJ4EZN45lMyy81 8shkeXTYqrziWr6ihdSQxL3AhQjYxfoj4PvG7WyfAE8D9JF0hawoqFif1OTNzj0A7U pftovFVF4bcSDCvwhGdacBq/I/NnZHl3NGd2s8WKxc/YEkRDlgDaCt6K8VZp0Ikf9M nFq2EhcpCgOlw== To: Rajkumar Manoharan , ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Rajkumar Manoharan Subject: Re: [RFC v2 1/2] ath10k: migrate to mac80211 txq scheduling In-Reply-To: <1538176574-5580-1-git-send-email-rmanohar@codeaurora.org> References: <1538176574-5580-1-git-send-email-rmanohar@codeaurora.org> Date: Sat, 29 Sep 2018 12:06:13 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87k1n4botm.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Rajkumar Manoharan writes: > ath10k maintains common txqs list for all stations. This txq > management can be removed by migrating to mac80211 txq APIs > and let mac80211 handle txqs reordering based on reported airtime. > By doing this, txq fairness maintained in ath10k i.e processing > N frames per txq is removed. By adapting to mac80211 APIs, > ath10k will support mac80211 based airtime fairness algorithm. > > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > Signed-off-by: Rajkumar Manoharan > --- > drivers/net/wireless/ath/ath10k/core.c | 2 - > drivers/net/wireless/ath/ath10k/core.h | 3 -- > drivers/net/wireless/ath/ath10k/htc.h | 1 - > drivers/net/wireless/ath/ath10k/htt_rx.c | 8 +++ > drivers/net/wireless/ath/ath10k/mac.c | 92 +++++++++++++-------------= ------ > 5 files changed, 45 insertions(+), 61 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireles= s/ath/ath10k/core.c > index cf3c47b8cb2d..0684f87abc9b 100644 > --- a/drivers/net/wireless/ath/ath10k/core.c > +++ b/drivers/net/wireless/ath/ath10k/core.c > @@ -3068,9 +3068,7 @@ struct ath10k *ath10k_core_create(size_t priv_size,= struct device *dev, >=20=20 > mutex_init(&ar->conf_mutex); > spin_lock_init(&ar->data_lock); > - spin_lock_init(&ar->txqs_lock); >=20=20 > - INIT_LIST_HEAD(&ar->txqs); > INIT_LIST_HEAD(&ar->peers); > init_waitqueue_head(&ar->peer_mapping_wq); > init_waitqueue_head(&ar->htt.empty_tx_wq); > diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireles= s/ath/ath10k/core.h > index f6e5c29f74e7..d3e20aaf8023 100644 > --- a/drivers/net/wireless/ath/ath10k/core.h > +++ b/drivers/net/wireless/ath/ath10k/core.h > @@ -1054,10 +1054,7 @@ struct ath10k { >=20=20 > /* protects shared structure data */ > spinlock_t data_lock; > - /* protects: ar->txqs, artxq->list */ > - spinlock_t txqs_lock; >=20=20 > - struct list_head txqs; > struct list_head arvifs; > struct list_head peers; > struct ath10k_peer *peer_map[ATH10K_MAX_NUM_PEER_IDS]; > diff --git a/drivers/net/wireless/ath/ath10k/htc.h b/drivers/net/wireless= /ath/ath10k/htc.h > index 51fda6c23f69..cb30add7dd33 100644 > --- a/drivers/net/wireless/ath/ath10k/htc.h > +++ b/drivers/net/wireless/ath/ath10k/htc.h > @@ -51,7 +51,6 @@ > */ >=20=20 > #define HTC_HOST_MAX_MSG_PER_RX_BUNDLE 8 > -#define HTC_HOST_MAX_MSG_PER_TX_BUNDLE 16 >=20=20 > enum ath10k_htc_tx_flags { > ATH10K_HTC_FLAG_NEED_CREDIT_UPDATE =3D 0x01, > diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wirel= ess/ath/ath10k/htt_rx.c > index f2405258a6d3..f2aaa2f7a022 100644 > --- a/drivers/net/wireless/ath/ath10k/htt_rx.c > +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c > @@ -2379,6 +2379,7 @@ static void ath10k_htt_rx_tx_fetch_ind(struct ath10= k *ar, struct sk_buff *skb) > u8 tid; > int ret; > int i; > + bool may_tx; >=20=20 > ath10k_dbg(ar, ATH10K_DBG_HTT, "htt rx tx fetch ind\n"); >=20=20 > @@ -2451,8 +2452,13 @@ static void ath10k_htt_rx_tx_fetch_ind(struct ath1= 0k *ar, struct sk_buff *skb) > num_msdus =3D 0; > num_bytes =3D 0; >=20=20 > + ieee80211_txq_schedule_start(hw, txq->ac); > + may_tx =3D ieee80211_txq_may_transmit(hw, txq); > while (num_msdus < max_num_msdus && > num_bytes < max_num_bytes) { > + if (!may_tx) > + break; > + > ret =3D ath10k_mac_tx_push_txq(hw, txq); > if (ret < 0) > break; > @@ -2460,6 +2466,8 @@ static void ath10k_htt_rx_tx_fetch_ind(struct ath10= k *ar, struct sk_buff *skb) > num_msdus++; > num_bytes +=3D ret; > } > + ieee80211_return_txq(hw, txq); > + ieee80211_txq_schedule_end(hw, txq->ac); >=20=20 > record->num_msdus =3D cpu_to_le16(num_msdus); > record->num_bytes =3D cpu_to_le32(num_bytes); > diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless= /ath/ath10k/mac.c > index 97548f96a2f7..3b441179a36c 100644 > --- a/drivers/net/wireless/ath/ath10k/mac.c > +++ b/drivers/net/wireless/ath/ath10k/mac.c > @@ -3874,7 +3874,6 @@ static void ath10k_mac_txq_init(struct ieee80211_tx= q *txq) >=20=20 > static void ath10k_mac_txq_unref(struct ath10k *ar, struct ieee80211_txq= *txq) > { > - struct ath10k_txq *artxq; > struct ath10k_skb_cb *cb; > struct sk_buff *msdu; > int msdu_id; > @@ -3882,12 +3881,6 @@ static void ath10k_mac_txq_unref(struct ath10k *ar= , struct ieee80211_txq *txq) > if (!txq) > return; >=20=20 > - artxq =3D (void *)txq->drv_priv; > - spin_lock_bh(&ar->txqs_lock); > - if (!list_empty(&artxq->list)) > - list_del_init(&artxq->list); > - spin_unlock_bh(&ar->txqs_lock); > - > spin_lock_bh(&ar->htt.tx_lock); > idr_for_each_entry(&ar->htt.pending_tx, msdu, msdu_id) { > cb =3D ATH10K_SKB_CB(msdu); > @@ -3927,7 +3920,6 @@ static bool ath10k_mac_tx_can_push(struct ieee80211= _hw *hw, > struct ath10k_txq *artxq =3D (void *)txq->drv_priv; >=20=20 > /* No need to get locks */ > - > if (ar->htt.tx_q_state.mode =3D=3D HTT_TX_MODE_SWITCH_PUSH) > return true; >=20=20 > @@ -4014,48 +4006,44 @@ int ath10k_mac_tx_push_txq(struct ieee80211_hw *h= w, > return skb_len; > } >=20=20 > -void ath10k_mac_tx_push_pending(struct ath10k *ar) > +static int ath10k_mac_schedule_txq(struct ieee80211_hw *hw, u32 ac) > { > - struct ieee80211_hw *hw =3D ar->hw; > struct ieee80211_txq *txq; > - struct ath10k_txq *artxq; > - struct ath10k_txq *last; > - int ret; > - int max; > - > - if (ar->htt.num_pending_tx >=3D (ar->htt.max_num_pending_tx / 2)) > - return; > - > - spin_lock_bh(&ar->txqs_lock); > - rcu_read_lock(); > - > - last =3D list_last_entry(&ar->txqs, struct ath10k_txq, list); > - while (!list_empty(&ar->txqs)) { > - artxq =3D list_first_entry(&ar->txqs, struct ath10k_txq, list); > - txq =3D container_of((void *)artxq, struct ieee80211_txq, > - drv_priv); > + int ret =3D 0; >=20=20 > - /* Prevent aggressive sta/tid taking over tx queue */ > - max =3D HTC_HOST_MAX_MSG_PER_TX_BUNDLE; > - ret =3D 0; > - while (ath10k_mac_tx_can_push(hw, txq) && max--) { > + ieee80211_txq_schedule_start(hw, ac); > + while ((txq =3D ieee80211_next_txq(hw, ac))) { > + while (ath10k_mac_tx_can_push(hw, txq)) { > ret =3D ath10k_mac_tx_push_txq(hw, txq); > if (ret < 0) > break; > } > + ieee80211_return_txq(hw, txq); > + ath10k_htt_tx_txq_update(hw, txq); > + if (ret =3D=3D -EBUSY) > + break; > + } > + ieee80211_txq_schedule_end(hw, ac); >=20=20 > - list_del_init(&artxq->list); > - if (ret !=3D -ENOENT) > - list_add_tail(&artxq->list, &ar->txqs); > + return ret; > +} >=20=20 > - ath10k_htt_tx_txq_update(hw, txq); > +void ath10k_mac_tx_push_pending(struct ath10k *ar) > +{ > + struct ieee80211_hw *hw =3D ar->hw; > + u32 ac; > + > + if (ar->htt.num_pending_tx >=3D (ar->htt.max_num_pending_tx / 2)) > + return; >=20=20 > - if (artxq =3D=3D last || (ret < 0 && ret !=3D -ENOENT)) > + rcu_read_lock(); > + > + for (ac =3D 0; ac < IEEE80211_NUM_ACS; ac++) { > + if (ath10k_mac_schedule_txq(hw, ac) =3D=3D -EBUSY) > break; > } >=20=20 > rcu_read_unlock(); > - spin_unlock_bh(&ar->txqs_lock); > } > EXPORT_SYMBOL(ath10k_mac_tx_push_pending); >=20=20 > @@ -4293,31 +4281,25 @@ static void ath10k_mac_op_tx(struct ieee80211_hw = *hw, > static void ath10k_mac_op_wake_tx_queue(struct ieee80211_hw *hw, > struct ieee80211_txq *txq) > { > - struct ath10k *ar =3D hw->priv; > - struct ath10k_txq *artxq =3D (void *)txq->drv_priv; > - struct ieee80211_txq *f_txq; > - struct ath10k_txq *f_artxq; > + u8 ac =3D txq->ac; > int ret =3D 0; > - int max =3D HTC_HOST_MAX_MSG_PER_TX_BUNDLE; > - > - spin_lock_bh(&ar->txqs_lock); > - if (list_empty(&artxq->list)) > - list_add_tail(&artxq->list, &ar->txqs); >=20=20 > - f_artxq =3D list_first_entry(&ar->txqs, struct ath10k_txq, list); > - f_txq =3D container_of((void *)f_artxq, struct ieee80211_txq, drv_priv); > - list_del_init(&f_artxq->list); > + ieee80211_txq_schedule_start(hw, ac); > + txq =3D ieee80211_next_txq(hw, ac); > + ieee80211_txq_schedule_end(hw, ac); You should really defer this schedule_end() until the scheduling episode actually, y'know, ends... :) > + if (!txq) > + return; >=20=20 > - while (ath10k_mac_tx_can_push(hw, f_txq) && max--) { > - ret =3D ath10k_mac_tx_push_txq(hw, f_txq); > + while (ath10k_mac_tx_can_push(hw, txq)) { > + ret =3D ath10k_mac_tx_push_txq(hw, txq); > if (ret < 0) > break; > } > - if (ret !=3D -ENOENT) > - list_add_tail(&f_artxq->list, &ar->txqs); > - spin_unlock_bh(&ar->txqs_lock); > - > - ath10k_htt_tx_txq_update(hw, f_txq); > + if (ret =3D=3D -EBUSY) { > + ieee80211_txq_schedule_start(hw, ac); > + ieee80211_return_txq(hw, txq); > + ieee80211_txq_schedule_end(hw, ac); > + } And ieee80211_return_txq() should be called regardless of the return code (it'll do it's own checking and do nothing if the queue is empty). -Toke