All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Emilio G. Cota" <cota@braap.org>
Cc: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 1/6] qht: remove unused map param from qht_remove__locked
Date: Fri, 07 Sep 2018 15:43:00 +0100	[thread overview]
Message-ID: <87k1nxz7uz.fsf@linaro.org> (raw)
In-Reply-To: <20180817232923.28899-2-cota@braap.org>


Emilio G. Cota <cota@braap.org> writes:

> Signed-off-by: Emilio G. Cota <cota@braap.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  util/qht.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/util/qht.c b/util/qht.c
> index c138777a9c..7b57b50a24 100644
> --- a/util/qht.c
> +++ b/util/qht.c
> @@ -665,8 +665,7 @@ static inline void qht_bucket_remove_entry(struct qht_bucket *orig, int pos)
>
>  /* call with b->lock held */
>  static inline
> -bool qht_remove__locked(struct qht_map *map, struct qht_bucket *head,
> -                        const void *p, uint32_t hash)
> +bool qht_remove__locked(struct qht_bucket *head, const void *p, uint32_t hash)
>  {
>      struct qht_bucket *b = head;
>      int i;
> @@ -701,7 +700,7 @@ bool qht_remove(struct qht *ht, const void *p, uint32_t hash)
>      qht_debug_assert(p);
>
>      b = qht_bucket_lock__no_stale(ht, hash, &map);
> -    ret = qht_remove__locked(map, b, p, hash);
> +    ret = qht_remove__locked(b, p, hash);
>      qht_bucket_debug__locked(b);
>      qemu_spin_unlock(&b->lock);
>      return ret;


--
Alex Bennée

  reply	other threads:[~2018-09-07 14:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-17 23:29 [Qemu-devel] [PATCH 0/6] qht improvements for 3.1 Emilio G. Cota
2018-08-17 23:29 ` [Qemu-devel] [PATCH 1/6] qht: remove unused map param from qht_remove__locked Emilio G. Cota
2018-09-07 14:43   ` Alex Bennée [this message]
2018-08-17 23:29 ` [Qemu-devel] [PATCH 2/6] qht: add qht_iter_remove Emilio G. Cota
2018-09-07 14:51   ` Alex Bennée
2018-09-07 15:45     ` Emilio G. Cota
2018-08-17 23:29 ` [Qemu-devel] [PATCH 3/6] test-qht: test qht_iter_remove Emilio G. Cota
2018-09-07 15:15   ` Alex Bennée
2018-08-17 23:29 ` [Qemu-devel] [PATCH 4/6] test-qht: test removal of non-existent entries Emilio G. Cota
2018-09-07 15:16   ` Alex Bennée
2018-08-17 23:29 ` [Qemu-devel] [PATCH 5/6] test-qht: test deletion of the last entry in a bucket Emilio G. Cota
2018-09-07 15:17   ` Alex Bennée
2018-08-17 23:29 ` [Qemu-devel] [PATCH 6/6] test-qht: speed up + test qht_resize Emilio G. Cota
2018-09-07 15:34   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1nxz7uz.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=cota@braap.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.