From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEF49ECDFB8 for ; Sun, 22 Jul 2018 13:33:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A18F120874 for ; Sun, 22 Jul 2018 13:33:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A18F120874 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=users.sourceforge.jp Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728533AbeGVOaT (ORCPT ); Sun, 22 Jul 2018 10:30:19 -0400 Received: from mail03.asahi-net.or.jp ([202.224.55.15]:52604 "EHLO mail03.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728244AbeGVOaT (ORCPT ); Sun, 22 Jul 2018 10:30:19 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.vps.ablenet.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail03.asahi-net.or.jp (Postfix) with ESMTPA id 84F81EB287; Sun, 22 Jul 2018 22:33:36 +0900 (JST) Received: from yo-satoh-debian.ysato.ml (ZM028236.ppp.dion.ne.jp [222.8.28.236]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 309BE24006D; Sun, 22 Jul 2018 22:33:36 +0900 (JST) Date: Sun, 22 Jul 2018 22:33:35 +0900 Message-ID: <87k1pnfl8w.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Randy Dunlap Cc: LKML , uclinux-h8-devel@lists.sourceforge.jp Subject: Re: [PATCH] arch/h8300: eliminate kgbd.c warning In-Reply-To: <7c458f27-9603-af24-e4e3-b87ef99693e3@infradead.org> References: <7c458f27-9603-af24-e4e3-b87ef99693e3@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Jul 2018 11:36:06 +0900, Randy Dunlap wrote: > > From: Randy Dunlap > > Drop the "const" qualifier from arch_kgdb_ops to eliminate the gcc > warning (gcc version is 8.1.0). > > arch/h8300/kernel/kgdb.c:132:24: error: conflicting type qualifiers for 'arch_kgdb_ops' > const struct kgdb_arch arch_kgdb_ops = { > In file included from ../arch/h8300/kernel/kgdb.c:12: > ../include/linux/kgdb.h:284:26: note: previous declaration of 'arch_kgdb_ops' was here > extern struct kgdb_arch arch_kgdb_ops; > > Signed-off-by: Randy Dunlap > Cc: Yoshinori Sato > Cc: uclinux-h8-devel@lists.sourceforge.jp > --- > arch/h8300/kernel/kgdb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20180717.orig/arch/h8300/kernel/kgdb.c > +++ linux-next-20180717/arch/h8300/kernel/kgdb.c > @@ -129,7 +129,7 @@ void kgdb_arch_exit(void) > /* Nothing to do */ > } > > -const struct kgdb_arch arch_kgdb_ops = { > +struct kgdb_arch arch_kgdb_ops = { > /* Breakpoint instruction: trapa #2 */ > .gdb_bpt_instr = { 0x57, 0x20 }, > }; > > Applied to h8300-next. Thanks. -- Yosinori Sato