From: Markus Armbruster <armbru@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
imammedo@redhat.com, Markus Armbruster <armbru@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig
Date: Tue, 12 Jun 2018 14:00:05 +0200 [thread overview]
Message-ID: <87k1r4use2.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20180612053720.pp2xvb7r34o6ort7@sirius.home.kraxel.org> (Gerd Hoffmann's message of "Tue, 12 Jun 2018 07:37:20 +0200")
Gerd Hoffmann <kraxel@redhat.com> writes:
> Hi,
>
>> > Now let's review the three commands:
>> >
>> > * Gerd, why does "info usbhost" have no QMP equivalent?
>
> Works only when running qemu directly, in the libvirt sandbox qemu
> hasn't the permissions needed to scan the host usb bus so that would be
> rather pointless ...
I don't think this meets either of the two criteria:
* I meets "makes no sense in QMP" only if QMP implies "can't scan host
USB bus". Libvirt implies it, but QMP doesn't imply libvirt; it's its
most important, not its sole user.
* It meets "of use only for human users" only if we're convinced it's of
no use to programs.
To avoid speculation and endless arguments about what could or could
not be of use, we've always stuck to "when in doubt, assume it could
be of use".
"Libvirt can't use it" falls short.
"Any management application worth anything would deny QEMU the
capability to scan the USB host bus, and thus wouldn't be able to use
it" is exactly the argument we intended to avoid.
QMP falling short of completeness in relatively unimportant ways like
this one isn't exactly terrible. The most serious effect is probably
serving as a bad example that leads to further arguments like this one.
These are well worth avoiding, though.
next prev parent reply other threads:[~2018-06-12 12:00 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 13:08 [Qemu-devel] [PATCH v3 0/7] Reenable hmp for preconfig mode Dr. David Alan Gilbert (git)
2018-06-08 13:08 ` [Qemu-devel] [PATCH v3 1/7] hmp: Add flag for preconfig commands Dr. David Alan Gilbert (git)
2018-06-11 8:49 ` Markus Armbruster
2018-06-11 17:37 ` Dr. David Alan Gilbert
2018-06-08 13:08 ` [Qemu-devel] [PATCH v3 2/7] hmp: Allow help on " Dr. David Alan Gilbert (git)
2018-06-11 9:00 ` Markus Armbruster
2018-06-11 10:27 ` Dr. David Alan Gilbert
2018-06-11 13:18 ` Markus Armbruster
2018-06-11 18:49 ` Dr. David Alan Gilbert
2018-06-12 7:03 ` Markus Armbruster
2018-06-08 13:08 ` [Qemu-devel] [PATCH v3 3/7] hmp: Restrict auto-complete in preconfig Dr. David Alan Gilbert (git)
2018-06-11 9:02 ` Markus Armbruster
2018-06-11 17:38 ` Dr. David Alan Gilbert
2018-06-08 13:08 ` [Qemu-devel] [PATCH v3 4/7] qmp: enable query-[chardev|version|name|uuid|iothreads|memdev] commands in preconfig state Dr. David Alan Gilbert (git)
2018-06-11 11:28 ` Markus Armbruster
2018-06-11 17:43 ` Dr. David Alan Gilbert
2018-06-12 7:05 ` Markus Armbruster
2018-06-08 13:08 ` [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig Dr. David Alan Gilbert (git)
2018-06-11 12:01 ` Markus Armbruster
2018-06-11 17:49 ` Dr. David Alan Gilbert
2018-06-12 5:37 ` Gerd Hoffmann
2018-06-12 12:00 ` Markus Armbruster [this message]
2018-06-12 12:52 ` Dr. David Alan Gilbert
2018-06-15 16:10 ` [Qemu-devel] Abandon our QMP first policy? (was: [PATCH v3 5/7] hmp: Add info commands for preconfig) Markus Armbruster
2018-06-15 16:32 ` Dr. David Alan Gilbert
2018-06-15 18:44 ` Eduardo Habkost
2018-06-18 6:36 ` Gerd Hoffmann
2018-06-20 14:48 ` Dr. David Alan Gilbert
2018-06-12 6:43 ` [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig Markus Armbruster
2018-06-12 8:49 ` Dr. David Alan Gilbert
2018-06-13 13:47 ` Eduardo Habkost
2018-06-13 13:53 ` Daniel P. Berrangé
2018-06-13 16:59 ` Eduardo Habkost
2018-06-11 18:40 ` Eduardo Habkost
2018-06-11 21:33 ` Igor Mammedov
2018-06-12 7:00 ` Markus Armbruster
2018-06-13 13:44 ` Eduardo Habkost
2018-06-12 7:57 ` Daniel P. Berrangé
2018-06-08 13:08 ` [Qemu-devel] [PATCH v3 6/7] hmp: add exit_preconfig Dr. David Alan Gilbert (git)
2018-06-11 12:04 ` Markus Armbruster
2018-06-11 18:29 ` Dr. David Alan Gilbert
2018-06-08 13:08 ` [Qemu-devel] [PATCH v3 7/7] hmp: Allow HMP in preconfig state again Dr. David Alan Gilbert (git)
2018-06-11 12:06 ` [Qemu-devel] [PATCH v3 0/7] Reenable hmp for preconfig mode Markus Armbruster
2018-06-11 12:09 ` Dr. David Alan Gilbert
2018-06-11 12:44 ` Markus Armbruster
2018-06-14 13:17 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1r4use2.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.