All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] linux: may fail to boot for binutils 2.29+ even without armv7m
Date: Fri, 01 Jun 2018 21:42:19 +0200	[thread overview]
Message-ID: <87k1rixpic.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180601180157.759-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Fri, 1 Jun 2018 20:01:57 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Commit f13477b (linux: config.in: add comment for Arm Cortex-M) added a
 > comment so that the user that the linux kernel may miscompile with
 > binutils 2.29+, when the target is an armv7m CPU.

 > However, the real trigger is a compilation in thumb2 mode, which happens
 > to be the only option for armv7m CPUs.

 > We can't know whether the kernel will be built in arm or thumb2 mode,
 > though, because we do not have that information: it is only available in
 > the Linux' .config file, which we don;t have access to at the time we
 > run our menuconfig.

 > So, relax the conditions under which the comment is made, so that it
 > appears as soon as binutils are >= 2.29 (i.e. not 2.28, which is the
 > oldest we support) for ARM CPUs.

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Christophe Priouzeau <christophe.priouzeau@st.com>
 > Cc: Laurent GONZALEZ <br22@gezedo.com>
 > Cc: Peter Korsgaard <peter@korsgaard.com>
 > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 > Cc: Arnout Vandecappelle <arnout@mind.be>

 > ---
 > Changes v1 -> v2:
 >   - only applicable to ARM CPUs.  (Peter)
 > ---
 >  linux/Config.in | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)

 > diff --git a/linux/Config.in b/linux/Config.in
 > index bffb52fd18..c29b1f6c88 100644
 > --- a/linux/Config.in
 > +++ b/linux/Config.in
 > @@ -9,7 +9,7 @@ config BR2_LINUX_KERNEL
 >  if BR2_LINUX_KERNEL
 
 >  comment "Linux kernel may fail to boot with binutils >= 2.29"
 > -	depends on BR2_ARM_CPU_ARMV7M
 > +	depends on BR2_arm || BR2_armeb

This only applies to a kernel built with CONFIG_THUMB2=y, so I've
slightly reworded the comment to be:

comment "Linux kernel in thumb mode may be broken with binutils >= 2.29"

And applied, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2018-06-01 19:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 18:01 [Buildroot] [PATCHv2] linux: may fail to boot for binutils 2.29+ even without armv7m Yann E. MORIN
2018-06-01 19:42 ` Peter Korsgaard [this message]
2018-06-04 22:10 ` Arnout Vandecappelle
2018-06-05  5:49   ` Thomas Petazzoni
2018-06-05  7:23     ` Laurent GONZALEZ
2018-06-05 15:43       ` Yann E. MORIN
2018-06-05 15:29     ` Yann E. MORIN
2018-06-08 14:22       ` Peter Korsgaard
2018-06-08 17:15         ` Yann E. MORIN
2018-06-05 15:25   ` Yann E. MORIN
2018-06-08 14:19   ` Peter Korsgaard
2018-06-17 15:04 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1rixpic.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.