From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521105795; bh=YwYDI8cRNyVG2C1P6mgiDvI4ynE80Qge4I1Klvb+LhQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gJ7vfOq78VVCVuAqNGGOJ62hSPrv+4b2WbLxDlUUjto3TVxcIXgXJF8VqJBuYzMfy lCOluIuHZ2iCWyt4L/YRghxfBJA+0qo0TSVidTPGGdhXmXztvRNANqj0tRmC8UFt6N hAms4KJiol3Om7m9h+GgBQc7OZ0Ufae42S6ZMCMY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521105793; bh=YwYDI8cRNyVG2C1P6mgiDvI4ynE80Qge4I1Klvb+LhQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=P9a2Nto5zwAEhUMu0p/8yC884dGPaL6ycY920qK4n56VBulYhTm3yuR8slz5COa2u L36PxrdTGSlMlx96tjXH1Wo83TEuXzNsT/YQDs+n5LmQ9tlXYxu/N7pvUbER61jgu6 +6EotWV8qScLLpmXRLfoIFbuczj+FTzu4+czX0AY= From: Kalle Valo References: <20180314110119.13631-1-zajec5@gmail.com> <878tau7n23.fsf@codeaurora.org> <52b1812dd3e843adb63ff67fbe95975f@milecki.pl> <877eqe63kr.fsf@codeaurora.org> <5AA98C3B.2070406@broadcom.com> In-Reply-To: <5AA98C3B.2070406@broadcom.com> (Arend van Spriel's message of "Wed, 14 Mar 2018 21:55:23 +0100") Message-ID: <87k1ud7kw4.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Thu, 15 Mar 2018 09:23:15 -0000 To: Arend van Spriel Cc: James Hughes , brcm80211-dev-list.pdl@broadcom.com, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, Chi-Hsien Lin , =?utf-8?Q?Raf?= =?utf-8?Q?a=C5=82_Mi=C5=82ecki?= , linux-wireless@vger.kernel.org, Hante Meuleman , Pieter-Paul Giesberts , Wright Feng , =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Felix Fietkau , brcm80211-dev-list@cypress.com, Franky Lin Arend van Spriel writes: > On 3/14/2018 5:10 PM, Kalle Valo wrote: >> Rafa=C5=82 Mi=C5=82ecki writes: >> >>>>> + unsigned char *eth_data =3D skb_mac_header(skb) + ETH_HLEN; >>>>> +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) >>>> >>>> #ifndef? >>> >>> I followed what is used in the include/linux/etherdevice.h. Is that a >>> good exceuse? Could it be there any some good reason for #if defined()? >> >> Don't know, maybe just a matter of taste? But it would be nice to know >> the background behind #ifdef vs #if defined(), never figured it out why >> two different forms. > > Well. In this case you could use either one, but if you have more > conditions #if defined() is bit more efficient: > > #ifdef A > #ifdef B > #endif > #endif > > vs. > > #if defined(A) && defined(B) Oh yeah, here defined() definitely helps. --=20 Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:51942 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751289AbeCOJXP (ORCPT ); Thu, 15 Mar 2018 05:23:15 -0400 From: Kalle Valo To: Arend van Spriel Cc: =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , =?utf-8?Q?Raf?= =?utf-8?Q?a=C5=82_Mi=C5=82ecki?= , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Pieter-Paul Giesberts , James Hughes , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, Linus =?utf-8?Q?L=C3=BCssing?= , Felix Fietkau , bridge@lists.linux-foundation.org Subject: Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default References: <20180314110119.13631-1-zajec5@gmail.com> <878tau7n23.fsf@codeaurora.org> <52b1812dd3e843adb63ff67fbe95975f@milecki.pl> <877eqe63kr.fsf@codeaurora.org> <5AA98C3B.2070406@broadcom.com> Date: Thu, 15 Mar 2018 11:23:07 +0200 In-Reply-To: <5AA98C3B.2070406@broadcom.com> (Arend van Spriel's message of "Wed, 14 Mar 2018 21:55:23 +0100") Message-ID: <87k1ud7kw4.fsf@kamboji.qca.qualcomm.com> (sfid-20180315_102323_811695_D40FC829) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Arend van Spriel writes: > On 3/14/2018 5:10 PM, Kalle Valo wrote: >> Rafa=C5=82 Mi=C5=82ecki writes: >> >>>>> + unsigned char *eth_data =3D skb_mac_header(skb) + ETH_HLEN; >>>>> +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) >>>> >>>> #ifndef? >>> >>> I followed what is used in the include/linux/etherdevice.h. Is that a >>> good exceuse? Could it be there any some good reason for #if defined()? >> >> Don't know, maybe just a matter of taste? But it would be nice to know >> the background behind #ifdef vs #if defined(), never figured it out why >> two different forms. > > Well. In this case you could use either one, but if you have more > conditions #if defined() is bit more efficient: > > #ifdef A > #ifdef B > #endif > #endif > > vs. > > #if defined(A) && defined(B) Oh yeah, here defined() definitely helps. --=20 Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default Date: Thu, 15 Mar 2018 11:23:07 +0200 Message-ID: <87k1ud7kw4.fsf@kamboji.qca.qualcomm.com> References: <20180314110119.13631-1-zajec5@gmail.com> <878tau7n23.fsf@codeaurora.org> <52b1812dd3e843adb63ff67fbe95975f@milecki.pl> <877eqe63kr.fsf@codeaurora.org> <5AA98C3B.2070406@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , =?utf-8?Q?Raf?= =?utf-8?Q?a=C5=82_Mi=C5=82ecki?= , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Pieter-Paul Giesberts , James Hughes , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, brcm80211-dev-list.pdl-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, brcm80211-dev-list-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linus =?utf-8?Q?L=C3=BCssing?= , Felix Fietkau , bridge-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Arend van Spriel Return-path: In-Reply-To: <5AA98C3B.2070406-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> (Arend van Spriel's message of "Wed, 14 Mar 2018 21:55:23 +0100") Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Arend van Spriel writes: > On 3/14/2018 5:10 PM, Kalle Valo wrote: >> Rafa=C5=82 Mi=C5=82ecki writes: >> >>>>> + unsigned char *eth_data =3D skb_mac_header(skb) + ETH_HLEN; >>>>> +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) >>>> >>>> #ifndef? >>> >>> I followed what is used in the include/linux/etherdevice.h. Is that a >>> good exceuse? Could it be there any some good reason for #if defined()? >> >> Don't know, maybe just a matter of taste? But it would be nice to know >> the background behind #ifdef vs #if defined(), never figured it out why >> two different forms. > > Well. In this case you could use either one, but if you have more > conditions #if defined() is bit more efficient: > > #ifdef A > #ifdef B > #endif > #endif > > vs. > > #if defined(A) && defined(B) Oh yeah, here defined() definitely helps. --=20 Kalle Valo