From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 1/3] drm/vc4: Set premultiplied for alpha formats Date: Tue, 06 Mar 2018 11:35:36 -0800 Message-ID: <87k1updmk7.fsf@anholt.net> References: <1520300919-103427-1-git-send-email-stschake@gmail.com> <1520300919-103427-2-git-send-email-stschake@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1290920475==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 89DAC6E292 for ; Tue, 6 Mar 2018 19:35:38 +0000 (UTC) In-Reply-To: <1520300919-103427-2-git-send-email-stschake@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Cc: airlied@linux.ie, linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Stefan Schake List-Id: dri-devel@lists.freedesktop.org --===============1290920475== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Stefan Schake writes: > Alpha formats in DRM are assumed to be premultiplied, so we should be > setting the PREMULT bit in the plane configuration for HVS. > > Signed-off-by: Stefan Schake > --- > drivers/gpu/drm/vc4/vc4_plane.c | 3 ++- > drivers/gpu/drm/vc4/vc4_regs.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_pl= ane.c > index c4c7af1..3d0c8a2 100644 > --- a/drivers/gpu/drm/vc4/vc4_plane.c > +++ b/drivers/gpu/drm/vc4/vc4_plane.c > @@ -618,13 +618,14 @@ static int vc4_plane_mode_set(struct drm_plane *pla= ne, > SCALER_POS1_SCL_HEIGHT)); > } >=20=20 > - /* Position Word 2: Source Image Size, Alpha Mode */ > + /* Position Word 2: Source Image Size, Alpha */ > vc4_state->pos2_offset =3D vc4_state->dlist_count; > vc4_dlist_write(vc4_state, > VC4_SET_FIELD(fb->format->has_alpha ? > SCALER_POS2_ALPHA_MODE_PIPELINE : > SCALER_POS2_ALPHA_MODE_FIXED, > SCALER_POS2_ALPHA_MODE) | > + (format->has_alpha ? SCALER_POS2_ALPHA_PREMULT : 0) | Looks like you meant fb->format->has_alpha here. I can fix that up when applying -- everything else looks good to me. I'll let this sit on the list for a day or two in case anyone else has feedback. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlqe7YgACgkQtdYpNtH8 nuiFRA/7BdGG1HiNYOoDudEiFtCcjXUhgK4QaYSkGz+nLTmv/QAd+hZ9J2v1E6v9 krNAjGJ5OEt1OkEZrRAmposXrqlk9fBUBzgB1wzz4yIjyTrN/ggujPKmmbGE45cC VcUc6n16EOV+MzypHplyW2AGBzgiDxvv88uby4p8JPE/VJhGRx4d5UQ4UOfyhOXx iNj18ufyoZtiEiWlsfBaJ5sZcYbiAAy85IyZ4ZGVvEGzgGN7pWGwAC+AF//OgSp4 hBHnnikF86LLW3xSzsnmC2L7clgZR8e0wLF5p7wwsyxq61xlkBiA7dGuEKaPIClT yJ+ib6l13wU3EroDEW7RLiq/58CDXRV1p5ggX5wUoEESm6euJvffSzuZXhLXoAnR 3jw6i/yrTzkHGsLoaGFRCBKIuVG5452ExDjWHk2wzVPpfetwgcbX3SldoXqnhyUt 3Ga7kROSGmd0ZKRP1WKG1rMK/uoIwx1MLf1IxG6yHV4ED/YkoYuoM/bMxfVn9B8D o5DfOVXPYppPD5HsMVi8yLb5n/w0wH2r+CvsJhgqriEnUY3VBYhqgkilHERzFuDd xg7szFM8hOxMH+sRUq4/ECRnkVPBGeL5N1uVbhT5frKctPC3Z7EGVRg2b54g93SC MJ8KpKlwg9ajg0knYiKJU5YqRyGV6ns/Wh7ZNvjdUCZ0ZtvzeQ0= =w//+ -----END PGP SIGNATURE----- --=-=-=-- --===============1290920475== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1290920475==--