Re: [PATCH v2 1/3] drm/i915/guc: Allow preempt-client to be NULL

[Mika Kuoppala <mika.kuoppala@linux.intel.com>]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Quoting Mika Kuoppala (2018-01-31 11:31:09)
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>> 
>> > In the next patch, we may only conditionally allocate the preempt-client
>> > if there is a global preempt context and so we need to be prepared in
>> > case the preempt-client itself is NULL.
>> >
>> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> > Cc: Michal Winiarski <michal.winiarski@intel.com>
>> > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> > Cc: Michel Thierry <michel.thierry@intel.com>
>> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> > ---
>> >  drivers/gpu/drm/i915/intel_guc_submission.c | 27 +++++++++++++++++----------
>> >  1 file changed, 17 insertions(+), 10 deletions(-)
>> >
>> 
>> You need to prepare the debugfs to handle the null also.
>> 
>> Does our simple igt/debugfs test include reading through all the nodes
>> it finds?
>
> It does, but we don't actually end up with NULLs.

Not with this patch alone but the commit message promises
that we prepare for it :)

-Mika

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx