From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
"make-wifi-fast\@lists.bufferbloat.net"
<make-wifi-fast@lists.bufferbloat.net>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] ath10k: Re-enable TXQs for all devices
Date: Fri, 10 Nov 2017 09:10:07 +0900 [thread overview]
Message-ID: <87k1yzq9i8.fsf@toke.dk> (raw)
In-Reply-To: <6112ae948ba2409da27709d01da567eb@NALASEXR01H.na.qualcomm.com>
Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
>> Commit 4ca1807815aa6801aaced7fdefa9edacc2521767 disables the use of the
>> mac80211 TXQs for some devices because of a theoretical throughput
>> regression. We have not seen this regression for a while now, so it shou=
ld be
>> safe to re-enable TXQs.
>>=20
>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk>
>> ---
>> This has been in LEDE trunk for a couple of months now with good results.
>>
> Toke,
>=20=20
> Good to know that the performance drop is not seen with the chips that do=
es not
> have push-pull support. The issue was originally reported with ap152 + qc=
a988x
> by community [1]. Hope this combination is also considered in LEDE.
Ah, was that the original bug report? Thank you, I have not been able to
find that anywhere!
The issue that seems to point to has been fixed a while ago; I'll send
and updated patch with a better commit message (also forgot to cc the
ath10k list, I see).
-Toke
next prev parent reply other threads:[~2017-11-10 0:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 7:19 [PATCH] ath10k: Re-enable TXQs for all devices Toke Høiland-Jørgensen
2017-11-09 16:13 ` Rajkumar Manoharan
2017-11-10 0:10 ` Toke Høiland-Jørgensen [this message]
2017-11-10 0:29 ` [Make-wifi-fast] " Dave Taht
2017-11-10 1:06 ` Kalle Valo
2017-11-10 1:06 ` Kalle Valo
2017-11-10 1:49 ` Rajkumar Manoharan
2017-11-10 1:49 ` Rajkumar Manoharan
2017-11-10 2:33 ` Toke Høiland-Jørgensen
2017-11-10 2:33 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1yzq9i8.fsf@toke.dk \
--to=toke@toke.dk \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.