From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, jdenemar@redhat.com,
wangjie88@huawei.com, peterx@redhat.com, mreitz@redhat.com,
berrange@redhat.com, eblake@redhat.com, fuweiwei2@huawei.com
Subject: Re: [Qemu-devel] [PATCH v4 3/7] migration: Wait for semaphore before completing migration
Date: Mon, 23 Oct 2017 13:02:48 +0200 [thread overview]
Message-ID: <87k1zmazzb.fsf@secure.laptop> (raw)
In-Reply-To: <20171020090556.18631-4-dgilbert@redhat.com> (David Alan Gilbert's message of "Fri, 20 Oct 2017 10:05:52 +0100")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Wait for a semaphore before completing the migration,
> if the previously added capability was enabled.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
> + while (qemu_sem_timedwait(&s->pause_sem, 1) == 0) {
wait
> + /* This block intentionally left blank */
> + }
> +
> + qemu_sem_wait(&s->pause_sem);
wait
and no posts on the whole patchset.
I agree that we only wait if we enable the feature, but still O:-)
next prev parent reply other threads:[~2017-10-23 11:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 9:05 [Qemu-devel] [PATCH v4 0/7] migration: pause-before-switchover Dr. David Alan Gilbert (git)
2017-10-20 9:05 ` [Qemu-devel] [PATCH v4 1/7] migration: Add 'pause-before-switchover' capability Dr. David Alan Gilbert (git)
2017-10-23 10:55 ` Juan Quintela
2017-10-20 9:05 ` [Qemu-devel] [PATCH v4 2/7] migration: Add 'pre-switchover' and 'device' statuses Dr. David Alan Gilbert (git)
2017-10-23 10:55 ` Juan Quintela
2017-10-20 9:05 ` [Qemu-devel] [PATCH v4 3/7] migration: Wait for semaphore before completing migration Dr. David Alan Gilbert (git)
2017-10-23 11:02 ` Juan Quintela [this message]
2017-10-20 9:05 ` [Qemu-devel] [PATCH v4 4/7] migration: migrate-continue Dr. David Alan Gilbert (git)
2017-10-23 11:03 ` Juan Quintela
2017-10-20 9:05 ` [Qemu-devel] [PATCH v4 5/7] migrate: HMP migate_continue Dr. David Alan Gilbert (git)
2017-10-23 11:03 ` Juan Quintela
2017-10-20 9:05 ` [Qemu-devel] [PATCH v4 6/7] migration: allow cancel to unpause Dr. David Alan Gilbert (git)
2017-10-23 11:04 ` Juan Quintela
2017-10-20 9:05 ` [Qemu-devel] [PATCH v4 7/7] migration: pause-before-switchover for postcopy Dr. David Alan Gilbert (git)
2017-10-23 11:05 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1zmazzb.fsf@secure.laptop \
--to=quintela@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=fuweiwei2@huawei.com \
--cc=jdenemar@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wangjie88@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.