From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ds4Mw-0004vC-7W for qemu-devel@nongnu.org; Wed, 13 Sep 2017 05:54:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ds4Mr-0002KQ-BW for qemu-devel@nongnu.org; Wed, 13 Sep 2017 05:54:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39136) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ds4Mr-0002Jt-64 for qemu-devel@nongnu.org; Wed, 13 Sep 2017 05:54:01 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 33EF98553C for ; Wed, 13 Sep 2017 09:54:00 +0000 (UTC) From: Juan Quintela In-Reply-To: <20170811152949.GU2554@redhat.com> (Daniel P. Berrange's message of "Fri, 11 Aug 2017 16:29:49 +0100") References: <20170808162629.32493-1-quintela@redhat.com> <20170808162629.32493-16-quintela@redhat.com> <20170811152949.GU2554@redhat.com> Reply-To: quintela@redhat.com Date: Wed, 13 Sep 2017 11:53:58 +0200 Message-ID: <87k212exft.fsf@secure.laptop> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v6 15/19] migration: Create thread infrastructure for multifd recv side List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com "Daniel P. Berrange" wrote: > On Tue, Aug 08, 2017 at 06:26:25PM +0200, Juan Quintela wrote: >> We make the locking and the transfer of information specific, even if we >> are still receiving things through the main thread. >> >> Signed-off-by: Juan Quintela >> >> -- >> >> We split when we create the main channel and where we start the main >> migration thread, so we wait for the creation of the other threads. >> >> Use multifd_clear_group(). >> --- >> migration/migration.c | 7 ++++--- >> migration/migration.h | 1 + >> migration/ram.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++---- >> migration/socket.c | 2 +- >> 4 files changed, 57 insertions(+), 8 deletions(-) > > >> diff --git a/migration/socket.c b/migration/socket.c >> index 5dd6f42..3af9f7c 100644 >> --- a/migration/socket.c >> +++ b/migration/socket.c >> @@ -183,12 +183,12 @@ static gboolean >> socket_accept_incoming_migration(QIOChannel *ioc, >> >> qio_channel_set_name(QIO_CHANNEL(sioc), "migration-socket-incoming"); >> migration_channel_process_incoming(QIO_CHANNEL(sioc)); >> - object_unref(OBJECT(sioc)); > > AFAICT, migration_channel_process_incoming() acquires its own reference > on 'sioc', so removing this object_unref means the code is now leaking a > reference Done. Thanks, Juan.