diff for duplicates of <87k26ye50d.fsf@yhuang-dev.intel.com> diff --git a/a/1.txt b/N1/1.txt index 5fe55ef..e7da0e9 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,16 +3,16 @@ Rik van Riel <riel@redhat.com> writes: > On Wed, 2017-04-05 at 15:10 +0800, Huang, Ying wrote: >> To solve the issue, the per-CPU buffer is sorted according to the >> swap ->> device before freeing the swap entries.A A Test shows that the time +>> device before freeing the swap entries. Test shows that the time >> spent by swapcache_free_entries() could be reduced after the patch. > > That makes a lot of sense. > >> @@ -1075,6 +1083,8 @@ void swapcache_free_entries(swp_entry_t >> *entries, int n) ->> A ->> A prev = NULL; ->> A p = NULL; +>> +>> prev = NULL; +>> p = NULL; >> + if (nr_swapfiles > 1) >> + sort(entries, n, sizeof(entries[0]), swp_entry_cmp, >> NULL); @@ -22,7 +22,7 @@ Rik van Riel <riel@redhat.com> writes: > we are sorting things we are about to free. > > Maybe something like: -> A A A A /* Sort swap entries by swap device, so each lock is only taken +> /* Sort swap entries by swap device, so each lock is only taken > once. */ Good suggestion! I will add it in the next version. @@ -30,12 +30,6 @@ Good suggestion! I will add it in the next version. Best Regards, Huang, Ying ->> A for (i = 0; i < n; ++i) { ->> A p = swap_info_get_cont(entries[i], prev); ->> A if (p) - --- -To unsubscribe, send a message with 'unsubscribe linux-mm' in -the body to majordomo@kvack.org. For more info on Linux MM, -see: http://www.linux-mm.org/ . -Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> +>> for (i = 0; i < n; ++i) { +>> p = swap_info_get_cont(entries[i], prev); +>> if (p) diff --git a/a/content_digest b/N1/content_digest index 449e071..37ef918 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,11 +4,11 @@ "Subject\0Re: [PATCH -mm -v2] mm, swap: Sort swap entries before free\0" "Date\0Thu, 06 Apr 2017 08:47:30 +0800\0" "To\0Rik van Riel <riel@redhat.com>\0" - "Cc\0Huang" + "Cc\0Huang\\" Ying <ying.huang@intel.com> Andrew Morton <akpm@linux-foundation.org> - linux-mm@kvack.org - linux-kernel@vger.kernel.org + <linux-mm@kvack.org> + <linux-kernel@vger.kernel.org> Hugh Dickins <hughd@google.com> Shaohua Li <shli@kernel.org> " Minchan Kim <minchan@kernel.org>\0" @@ -19,16 +19,16 @@ "> On Wed, 2017-04-05 at 15:10 +0800, Huang, Ying wrote:\n" ">> To solve the issue, the per-CPU buffer is sorted according to the\n" ">> swap\n" - ">> device before freeing the swap entries.A A Test shows that the time\n" + ">> device before freeing the swap entries.\302\240\302\240Test shows that the time\n" ">> spent by swapcache_free_entries() could be reduced after the patch.\n" ">\n" "> That makes a lot of sense.\n" ">\n" ">> @@ -1075,6 +1083,8 @@ void swapcache_free_entries(swp_entry_t\n" ">> *entries, int n)\n" - ">> A \n" - ">> A \tprev = NULL;\n" - ">> A \tp = NULL;\n" + ">> \302\240\n" + ">> \302\240\tprev = NULL;\n" + ">> \302\240\tp = NULL;\n" ">> +\tif (nr_swapfiles > 1)\n" ">> +\t\tsort(entries, n, sizeof(entries[0]), swp_entry_cmp,\n" ">> NULL);\n" @@ -38,7 +38,7 @@ "> we are sorting things we are about to free.\n" ">\n" "> Maybe something like:\n" - "> A A A A /* Sort swap entries by swap device, so each lock is only taken\n" + "> \302\240 \302\240 \302\240 \302\240 /* Sort swap entries by swap device, so each lock is only taken\n" "> once. */\n" "\n" "Good suggestion! I will add it in the next version.\n" @@ -46,14 +46,8 @@ "Best Regards,\n" "Huang, Ying\n" "\n" - ">> A \tfor (i = 0; i < n; ++i) {\n" - ">> A \t\tp = swap_info_get_cont(entries[i], prev);\n" - ">> A \t\tif (p)\n" - "\n" - "--\n" - "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" - "the body to majordomo@kvack.org. For more info on Linux MM,\n" - "see: http://www.linux-mm.org/ .\n" - "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" + ">> \302\240\tfor (i = 0; i < n; ++i) {\n" + ">> \302\240\t\tp = swap_info_get_cont(entries[i], prev);\n" + ">> \302\240\t\tif (p)" -4e49faac0553dd50663461a8633543a40ade2ef95efee64ea3314572450752ee +853f8e06ac0caa6329ee3fba5734624e20280fa2beede1ed16ee0cc7e8cb78e0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.