From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:44056 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751384AbdDCNCe (ORCPT ); Mon, 3 Apr 2017 09:02:34 -0400 From: Kalle Valo To: Johan Hovold CC: ath9k-devel , Daniel Drake , Ulrich Kunitz , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sujith Manoharan Subject: Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe Date: Mon, 3 Apr 2017 13:02:28 +0000 Message-ID: <87k271myos.fsf@kamboji.qca.qualcomm.com> (sfid-20170403_150313_258376_4BA3835D) References: <20170313124421.28587-1-johan@kernel.org> <20170403084213.GE25742@localhost> <87shlpomvx.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87shlpomvx.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Mon, 03 Apr 2017 12:34:26 +0300") Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Kalle Valo writes: > Johan Hovold writes: > >> On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote: >>> Make sure to check the number of endpoints to avoid dereferencing a >>> NULL-pointer or accessing memory beyond the endpoint array should a >>> malicious device lack the expected endpoints. >>>=20 >>> Fixes: 36bcce430657 ("ath9k_htc: Handle storage devices") >>> Cc: Sujith Manoharan >>> Signed-off-by: Johan Hovold >> >> Is this one still in your queue, Kalle? > > Yes, I'm just lacking behing: > > https://patchwork.kernel.org/patch/9620723/ Meant "lagging" of course. Mondays.. >> As I mentioned earlier, I should have added a >> >> Cc: stable # 2.6.39 >> >> but left it out as I mistakingly thought the net recommendations to do >> so applied also to wireless. > > Ok, I'll add that. But is 2.6.39 really correct? Shouldn't it be 2.6.39+ so that it means all versions since 2.6.39? --=20 Kalle Valo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752055AbdDCNCg (ORCPT ); Mon, 3 Apr 2017 09:02:36 -0400 Received: from wolverine01.qualcomm.com ([199.106.114.254]:44056 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751384AbdDCNCe (ORCPT ); Mon, 3 Apr 2017 09:02:34 -0400 X-IronPort-AV: E=Sophos;i="5.36,270,1486454400"; d="scan'208";a="275606418" X-IronPort-AV: E=McAfee;i="5800,7501,8486"; a="1340051469" X-MGA-submission: =?us-ascii?q?MDHiG3A023fi6Kt83ljAVMHGDZvIzsFGi5rPF3?= =?us-ascii?q?Plx3R9ovMbXKhPqDon+hRL9ughvNslGMnKwT1z6dFDZOKBELbrqlv57Z?= =?us-ascii?q?Fv32EYn+UfwaH1IvqgAK8YcF2qQA2jhZ9YV+GtUFdHKHXNiM4eEwZ1Qr?= =?us-ascii?q?HX?= From: Kalle Valo To: Johan Hovold CC: ath9k-devel , Daniel Drake , Ulrich Kunitz , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sujith Manoharan Subject: Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe Thread-Topic: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe Thread-Index: AQHSrHqL/M5YQDg7HEy/03ZBkiz3aQ== Date: Mon, 3 Apr 2017 13:02:28 +0000 Message-ID: <87k271myos.fsf@kamboji.qca.qualcomm.com> References: <20170313124421.28587-1-johan@kernel.org> <20170403084213.GE25742@localhost> <87shlpomvx.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87shlpomvx.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Mon, 03 Apr 2017 12:34:26 +0300") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.251.52.12] Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v33D2kYI019292 Kalle Valo writes: > Johan Hovold writes: > >> On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote: >>> Make sure to check the number of endpoints to avoid dereferencing a >>> NULL-pointer or accessing memory beyond the endpoint array should a >>> malicious device lack the expected endpoints. >>> >>> Fixes: 36bcce430657 ("ath9k_htc: Handle storage devices") >>> Cc: Sujith Manoharan >>> Signed-off-by: Johan Hovold >> >> Is this one still in your queue, Kalle? > > Yes, I'm just lacking behing: > > https://patchwork.kernel.org/patch/9620723/ Meant "lagging" of course. Mondays.. >> As I mentioned earlier, I should have added a >> >> Cc: stable # 2.6.39 >> >> but left it out as I mistakingly thought the net recommendations to do >> so applied also to wireless. > > Ok, I'll add that. But is 2.6.39 really correct? Shouldn't it be 2.6.39+ so that it means all versions since 2.6.39? -- Kalle Valo