All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Danil Antonov <g.danil.anto@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 24/43] migration: made printf always compile in debug output
Date: Mon, 03 Apr 2017 08:35:03 +0200	[thread overview]
Message-ID: <87k272knhk.fsf@secure.mitica> (raw)
In-Reply-To: <CA+KKJYDrS0c0GoxctMGG2cg+8C9Jqg_2LoiRVy59J8rnXiZYPA@mail.gmail.com> (Danil Antonov's message of "Sat, 1 Apr 2017 16:58:55 +0300")

Danil Antonov <g.danil.anto@gmail.com> wrote:
> From e5719e802fcd1d1b426d687524ed46f10d044941 Mon Sep 17 00:00:00 2001
> From: Danil Antonov <g.danil.anto@gmail.com>
> Date: Wed, 29 Mar 2017 12:35:10 +0300
> Subject: [PATCH 24/43] migration: made printf always compile in debug output
>
> Wrapped printf calls inside debug macros (DPRINTF) in `if` statement.
> This will ensure that printf function will always compile even if debug
> output is turned off and, in turn, will prevent bitrot of the format
> strings.
>
> Signed-off-by: Danil Antonov <g.danil.anto@gmail.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

      reply	other threads:[~2017-04-03  6:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01 13:58 [Qemu-devel] [PATCH 24/43] migration: made printf always compile in debug output Danil Antonov
2017-04-03  6:35 ` Juan Quintela [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k272knhk.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=g.danil.anto@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.