From: Jani Nikula <jani.nikula@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [dim PATCH 00/10] dim: shellcheck fixes
Date: Mon, 20 Mar 2017 15:14:11 +0200 [thread overview]
Message-ID: <87k27kay58.fsf@intel.com> (raw)
In-Reply-To: <20170317165314.cpt3ol4yipgcvxus@phenom.ffwll.local>
On Fri, 17 Mar 2017, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Mar 17, 2017 at 12:42:51PM +0200, Jani Nikula wrote:
>> Noticing that 64a54c5e1a5d ("dim: Add add-link command") added a
>> condition that is always true (if [ -n $foo ]), despite my review of the
>> patch, I refreshed some of my old patches to fix issues that can be
>> caught by shellcheck.
>>
>> Starting from patch 1, the minimal merge criteria for any new dim
>> patches is that 'make shellcheck' passes.
>>
>> I add shellcheck exceptions for starters, so there are no errors
>> reported, and then remove the exceptions by fixing them one by one. I'm
>> not sure if we'll ever fix them all, but let's at least make sure we're
>> not adding any new silly mistakes.
>
> Ack on the entire series. checkpatch for dim!
Thanks, pushed.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-03-20 13:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 10:42 [dim PATCH 00/10] dim: shellcheck fixes Jani Nikula
2017-03-17 10:42 ` [dim PATCH 01/10] dim: add make target to shellcheck dim Jani Nikula
2017-03-17 10:42 ` [dim PATCH 02/10] dim: quote check for non-zero string Jani Nikula
2017-03-17 10:42 ` [dim PATCH 03/10] dim: replace expr with $((..)) Jani Nikula
2017-03-17 10:42 ` [dim PATCH 04/10] dim: use $* instead of $@ within string Jani Nikula
2017-03-17 10:42 ` [dim PATCH 05/10] dim: double quote array expansions Jani Nikula
2017-03-17 10:42 ` [dim PATCH 06/10] dim: quote expressions using { } Jani Nikula
2017-03-17 10:42 ` [dim PATCH 07/10] dim: add double quotes to prevent glob interpretation Jani Nikula
2017-03-17 10:42 ` [dim PATCH 08/10] dim: prevent * from becoming options Jani Nikula
2017-03-17 10:43 ` [dim PATCH 09/10] dim: avoid useless cat in apply-branch Jani Nikula
2017-03-17 10:43 ` [dim PATCH 10/10] dim: Replace `..` with $(..) Jani Nikula
2017-03-17 16:53 ` [dim PATCH 00/10] dim: shellcheck fixes Daniel Vetter
2017-03-20 13:14 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k27kay58.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.