From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com ([192.55.52.43]:15640 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbdCHL5P (ORCPT ); Wed, 8 Mar 2017 06:57:15 -0500 From: Felipe Balbi To: Thinh Nguyen Cc: Linux USB , "stable\@vger.kernel.org" , John Youn Subject: RE: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid In-Reply-To: <87mvcw0zxc.fsf@linux.intel.com> References: <20170119114034.15184-1-felipe.balbi@linux.intel.com> <30102591E157244384E984126FC3CB4F2FF567F3@US01WEMBX2.internal.synopsys.com> <87vark15hc.fsf@linux.intel.com> <87shmo15bd.fsf@linux.intel.com> <87mvcw0zxc.fsf@linux.intel.com> Date: Wed, 08 Mar 2017 13:55:39 +0200 Message-ID: <87k2800ypw.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Felipe Balbi writes: >>> I've been looking at this and based on sniffer and dwc3 tracepoints, it >>> seems like dwc3 is behaving properly. The real issue seems to be that >>> g_mass_storage isn't queueing a new request to IN endpoint. >>> >>> I'll continue debugging this and try to find a solution that doesn't >>> involve reverting $subject. >> >> oh no, wait. ep2out misses XferInProgress: >> >> file-storage-1592 [000] d..1 152.809922: dwc3_ep_queue: ep2out: r= eq ffff88003cd6ee40 length 0/512 zsI =3D=3D> -115 >> file-storage-1592 [000] d..1 152.809931: dwc3_prepare_trb: ep2out= : 3/8 trb ffff88003a196050 buf 000000002d5e4000 size 512 ctrl 00000819 (Hlc= S:sC:normal) >> file-storage-1592 [000] d..1 152.809942: dwc3_gadget_ep_cmd: ep2o= ut: cmd 'Update Transfer' [262151] params 00000000 00000000 00000000 --> st= atus: Successful >> file-storage-1592 [000] .... 152.809951: usb_ep_queue: ep2out: le= ngth 0/512 sgs 0/0 stream 0 zsI status -115 --> 0 >> irq/34-dwc3-1593 [001] d..1 152.810212: dwc3_event: event (0000c= 040): ep0out: Transfer Complete [Setup Phase] >> irq/34-dwc3-1593 [001] d..1 152.810218: dwc3_ctrl_req: bRequestT= ype 02 bRequest 01 wValue 0000 wIndex 0002 wLength 0 >> irq/34-dwc3-1593 [001] d..1 152.810228: __dwc3_gadget_ep_set_hal= t: ep2out: NOT stalled >> >> Sniffer shows me this completing, but I don't see IRQ for this. > > BTW, I just tested without $subject and it fails the same way. This is > caused by something else. Can you rerun your bisect while I look at the > problem here? Okay, found it. This is caused by the ep_dequeue bug that I already fixed. see [1] for that [1] https://marc.info/?i=3D20170217105759.24356-1-felipe.balbi@linux.intel.= com =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAli/8TsACgkQzL64meEa mQaPdA/8C1/QzQFX7La+PbX/Xh+MdrXHfqauRBbmswQv23mhnTHoE0Q8bwxGe9us xD7MPjsxPKcuPFGOHhP94lVvQTu5kinxZMmggeQkdZFwzt+hXQ+K3pRhfNB6hvTX 9GOgkRkeKEIVV0h8uRmHqrjMvm5FPV42zd2Yxjrin+gGCZ1KDVYznlwlhf5rBVsk MXXkA1PkQkmXQd/1bPGYc0yyN62rrwywA3N3uzlvDFaH+w/fPhz7anpzy/h8rl7o cQKsmiu7a2Z9aonTI68G+z09mLZcURnNSdCWwzON/MuwMaiYMTVXvWc8DxOOg1kt UbmCCn45rgJGnkMfyRKRQ7/qwXMhaWsUQsYARaL/lw52YkVX/ZcNb3Tnd4vK7JMG myoDkNAaBqiLiFM0mzUIhLk1MzHE6qEwEj19OykZBd51qbmWvTFVz3t0oXznkjnH fg2H2Qg+86o0hP3qZL2/B7Ecj/Glp0ZbmWG+2tqlZv5e9r/m4Pzez0EOPCxUmXlV 2Y2Xk2TpNnGdjNBBZ2vafjKqmsQrasTm9EGcT3F7UxH7f0C/RK70vUUUUT6JY3Ie G8BLjCUlbDHpp2R4gGMRSCn8fgQxawBiB8VBnjPdaUms4Afluajqkeh6cMhwZvNn g65KzjRQb/aB7YRfrlebWTAM9hj5NszfMU2NlLMIe/WnmxpWcX0= =UTM+ -----END PGP SIGNATURE----- --=-=-=--