From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zen.linaro.local (host5-81-235-77.range5-81.btcentralplus.com. [5.81.235.77]) by smtp.gmail.com with ESMTPSA id h23sm11052423wrc.48.2017.02.24.09.17.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Feb 2017 09:17:36 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTPS id 526103E0198; Fri, 24 Feb 2017 17:17:36 +0000 (GMT) References: <1487262963-11519-1-git-send-email-peter.maydell@linaro.org> <87wpcflmmb.fsf@linaro.org> <87shn3lkj3.fsf@linaro.org> <87r32nleue.fsf@linaro.org> User-agent: mu4e 0.9.19; emacs 25.2.5 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Peter Maydell Cc: qemu-arm , QEMU Developers , "patches\@linaro.org" Subject: Re: [Qemu-arm] [PATCH v2 00/13] Rewrite NVIC to not depend on the GIC In-reply-to: Date: Fri, 24 Feb 2017 17:17:36 +0000 Message-ID: <87k28fld8v.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-TUID: SS4b5V8Kq7B+ Peter Maydell writes: > On 24 February 2017 at 16:43, Alex Bennée wrote: >> >> Peter Maydell writes: >> >>> On 24 February 2017 at 14:40, Alex Bennée wrote: >>> Could be. I use arm-linux-gnueabihf-gcc to build. If you use >>> PRIx32 does it build OK? >> >> Well the problem is the non-eabi compilers don't have PRIx32 defined for >> you. You have to specify yourself. > > Oh, right. Or we could just cast these things to unsigned int ;-) > > Other than the tests being a bit ropy, are you happy with the > patches proper? Yes, I've just looked through the last few and they look good to me. > > thanks > -- PMM -- Alex Bennée From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chJV1-0001tj-8D for qemu-devel@nongnu.org; Fri, 24 Feb 2017 12:17:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1chJUx-0000ys-Th for qemu-devel@nongnu.org; Fri, 24 Feb 2017 12:17:43 -0500 Received: from mail-wr0-x22c.google.com ([2a00:1450:400c:c0c::22c]:34272) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1chJUx-0000yM-LW for qemu-devel@nongnu.org; Fri, 24 Feb 2017 12:17:39 -0500 Received: by mail-wr0-x22c.google.com with SMTP id o22so11754569wro.1 for ; Fri, 24 Feb 2017 09:17:39 -0800 (PST) References: <1487262963-11519-1-git-send-email-peter.maydell@linaro.org> <87wpcflmmb.fsf@linaro.org> <87shn3lkj3.fsf@linaro.org> <87r32nleue.fsf@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: Date: Fri, 24 Feb 2017 17:17:36 +0000 Message-ID: <87k28fld8v.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH v2 00/13] Rewrite NVIC to not depend on the GIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-arm , QEMU Developers , "patches@linaro.org" Peter Maydell writes: > On 24 February 2017 at 16:43, Alex Bennée wrote: >> >> Peter Maydell writes: >> >>> On 24 February 2017 at 14:40, Alex Bennée wrote: >>> Could be. I use arm-linux-gnueabihf-gcc to build. If you use >>> PRIx32 does it build OK? >> >> Well the problem is the non-eabi compilers don't have PRIx32 defined for >> you. You have to specify yourself. > > Oh, right. Or we could just cast these things to unsigned int ;-) > > Other than the tests being a bit ropy, are you happy with the > patches proper? Yes, I've just looked through the last few and they look good to me. > > thanks > -- PMM -- Alex Bennée