All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: devel@linuxdriverproject.org,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org,
	Haiyang Zhang <haiyangz@microsoft.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	John Stultz <john.stultz@linaro.org>,
	Alex Ng <alexng@microsoft.com>, Olaf Hering <olaf@aepfle.de>,
	Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH v3 0/2] hv_util: adjust system time smoothly
Date: Tue, 17 Jan 2017 18:15:39 +0100	[thread overview]
Message-ID: <87k29tzjyc.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20170117083728.7b84feaa@xeon-e3> (Stephen Hemminger's message of "Tue, 17 Jan 2017 08:37:28 -0800")

Stephen Hemminger <stephen@networkplumber.org> writes:

> On Tue, 17 Jan 2017 16:27:17 +0100
> Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>
>> With TimeSync version 4 protocol support we started updating system time
>> continuously through the whole lifetime of Hyper-V guests. Every 5 seconds
>> there is a time sample from the host which triggers do_settimeofday[64]().
>> While the time from the host is very accurate such adjustments may cause
>> issues:
>> - Time is jumping forward and backward, some applications may misbehave.
>> - In case an NTP server runs in parallel and uses something else for time
>>   sync (network, PTP,...) system time will never converge.
>> - Systemd starts annoying you by printing "Time has been changed" every 5
>>   seconds to the system log.
>> 
>> Instead of doing in-kernel time adjustments offload the work to an
>> NTP client by exposing TimeSync messages as a PTP device. Users may now
>> decide what they want to use as a source.
>> 
>> Changes since v2:
>> - Implement Hyper-V PTP device instead of doint in-kernel time sync.
>> 
>> Changes since "[PATCH RFC] hv_utils: implement Hyper-V PTP source":
>> - Richard Cochran: implement .adjfreq, .adjtime, .settime64 returning
>>   -EOPNOTSUPP.
>> - Olaf Hering: change IS_ERR->IS_ERR_OR_NULL as CONFIG_PTP_1588_CLOCK
>>   can be disabled.
>> - Thomas Gleixner: formatting fixes, comments added.
>> 
>> Vitaly Kuznetsov (2):
>>   hv_util: switch to using timespec64
>>   hv_utils: implement Hyper-V PTP source
>> 
>>  drivers/hv/hv_util.c | 142 +++++++++++++++++++++++++++++++++++++++++----------
>>  1 file changed, 116 insertions(+), 26 deletions(-)
>> 
>
> It would be good to update Documentation files to describe any configuration needed.

This is just a PTP device, not any different for other PTP devices so
users will be reading their NTP server docs to figure out how to add a
PTP reference clock.

Or do you have any particular idea where to put an example?

-- 
  Vitaly

      reply	other threads:[~2017-01-17 17:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17 15:27 [PATCH v3 0/2] hv_util: adjust system time smoothly Vitaly Kuznetsov
2017-01-17 15:27 ` [PATCH v3 1/2] hv_util: switch to using timespec64 Vitaly Kuznetsov
2017-01-17 17:37   ` Thomas Gleixner
2017-01-17 15:27 ` [PATCH v3 2/2] hv_utils: implement Hyper-V PTP source Vitaly Kuznetsov
2017-01-17 16:35   ` Stephen Hemminger
2017-01-17 17:11     ` Vitaly Kuznetsov
2017-01-17 19:17       ` Thomas Gleixner
2017-01-17 16:37 ` [PATCH v3 0/2] hv_util: adjust system time smoothly Stephen Hemminger
2017-01-17 17:15   ` Vitaly Kuznetsov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k29tzjyc.fsf@vitty.brq.redhat.com \
    --to=vkuznets@redhat.com \
    --cc=alexng@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=john.stultz@linaro.org \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=richardcochran@gmail.com \
    --cc=stephen@networkplumber.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.