From: Jani Nikula <jani.nikula@linux.intel.com>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/irq: drm_legacy_ prefix for legacy ioctls
Date: Wed, 07 Dec 2016 11:28:54 +0200 [thread overview]
Message-ID: <87k2bcxf3d.fsf@intel.com> (raw)
In-Reply-To: <20161207085134.4774-1-daniel.vetter@ffwll.ch>
On Wed, 07 Dec 2016, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Spotted while auditing our ioctl table. Also nuke the
> not-really-kerneldoc comments, we don't document internals and
> definitely don't want to mislead people with the old dragons.
Not just specific to this patch, but I'm not sure I agree with the "we
don't document internals" in general. That seems to be something that
just started happening without much discussion. We have *loads* of
complicated functions that would benefit from documentation, even if
they're internal (i.e. not exported).
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-12-07 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 8:51 [PATCH] drm/irq: drm_legacy_ prefix for legacy ioctls Daniel Vetter
2016-12-07 9:28 ` Jani Nikula [this message]
2016-12-07 10:26 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2bcxf3d.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.