From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate". Date: Thu, 20 Oct 2016 16:44:49 +0300 Message-ID: <87k2d3qgmm.fsf@intel.com> References: <87h98ktxow.fsf@intel.com> <87lgxvqlg3.fsf@intel.com> <877f9dd4kp.fsf@intel.com> <34ef3414-952d-461f-bc3c-a47fadd1b69a@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 10AD56EB5B for ; Thu, 20 Oct 2016 13:44:54 +0000 (UTC) In-Reply-To: <34ef3414-952d-461f-bc3c-a47fadd1b69a@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda , Emil Velikov Cc: "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Sun, Jing A" , "Vetter, Daniel" , Thierry Reding List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyMCBPY3QgMjAxNiwgQW5kcnplaiBIYWpkYSA8YS5oYWpkYUBzYW1zdW5nLmNvbT4g d3JvdGU6Cj4gSGkgSmFuaSwKPgo+IEZvcmdpdmUgbWUgbGF0ZSByZXNwb25zZS4KPgo+IE9uIDEy LjEwLjIwMTYgMTY6MjgsIEphbmkgTmlrdWxhIHdyb3RlOgo+PiBPbiBXZWQsIDEyIE9jdCAyMDE2 LCBFbWlsIFZlbGlrb3YgPGVtaWwubC52ZWxpa292QGdtYWlsLmNvbT4gd3JvdGU6Cj4+PiBPbiAx MSBPY3RvYmVyIDIwMTYgYXQgMTA6MzMsIEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5p bnRlbC5jb20+IHdyb3RlOgo+Pj4+IE9uIFR1ZSwgMTEgT2N0IDIwMTYsICJTdW4sIEppbmcgQSIg PGppbmcuYS5zdW5AaW50ZWwuY29tPiB3cm90ZToKPj4+Pj4gSXQncyBuZWVkZWQgdGhhdCBEUk0g RHJpdmVyIG1vZHVsZSBjb3VsZCBiZSByZW1vdmVkIGFuZCByZWxvYWRlZCBhZnRlcgo+Pj4+PiBr ZXJuZWwgYm9vdGluZyBvbiB0aGUgcHJvamVjdHMgdGhhdCBJIGhhdmUgYmVlbiB3b3JraW5nIG9u LCBhbmQgSSBob3BlCj4+Pj4+IHN1Y2ggbW9kdWxlIHR5cGUgY2hhbmdlIGNvdWxkIGJlIGFjY2Vw dGVkLiBMb29rcyBsaWtlIEl3YWkgaGFzIHNpbWlsYXIKPj4+Pj4gY2hhbmdlIHJlcXVlc3QgYXMg d2VsbC4gV291bGQgeW91IHBsZWFzZSByZXZpZXcgaXQgYW5kIGxldCB1cyBrbm93IGlmCj4+Pj4+ IGFueSBjb25jZXJucz8KPj4+PiBMb29raW5nIGF0IHRoZSBLY29uZmlnLCBzZWxlY3RpbmcgQ09O RklHX0RSTV9NSVBJX0RTSSBpcyBhZ2FpbnN0IHRoZQo+Pj4+IHJlY29tbWVuZGF0aW9ucyBvZiBE b2N1bWVudGF0aW9uL2tidWlsZC9rY29uZmlnLWxhbmd1YWdlLnR4dDoKPj4+Pgo+Pj4+ICAgICAg ICAgc2VsZWN0IHNob3VsZCBiZSB1c2VkIHdpdGggY2FyZS4gc2VsZWN0IHdpbGwgZm9yY2UKPj4+ PiAgICAgICAgIGEgc3ltYm9sIHRvIGEgdmFsdWUgd2l0aG91dCB2aXNpdGluZyB0aGUgZGVwZW5k ZW5jaWVzLgo+Pj4+ICAgICAgICAgQnkgYWJ1c2luZyBzZWxlY3QgeW91IGFyZSBhYmxlIHRvIHNl bGVjdCBhIHN5bWJvbCBGT08gZXZlbgo+Pj4+ICAgICAgICAgaWYgRk9PIGRlcGVuZHMgb24gQkFS IHRoYXQgaXMgbm90IHNldC4KPj4+PiAgICAgICAgIEluIGdlbmVyYWwgdXNlIHNlbGVjdCBvbmx5 IGZvciBub24tdmlzaWJsZSBzeW1ib2xzCj4+Pj4gICAgICAgICAobm8gcHJvbXB0cyBhbnl3aGVy ZSkgYW5kIGZvciBzeW1ib2xzIHdpdGggbm8gZGVwZW5kZW5jaWVzLgo+Pj4+ICAgICAgICAgVGhh dCB3aWxsIGxpbWl0IHRoZSB1c2VmdWxuZXNzIGJ1dCBvbiB0aGUgb3RoZXIgaGFuZCBhdm9pZAo+ Pj4+ICAgICAgICAgdGhlIGlsbGVnYWwgY29uZmlndXJhdGlvbnMgYWxsIG92ZXIuCj4+Pj4KPj4+ PiBJbmRlZWQsIHlvdSBtYXkgZW5kIHVwIHdpdGggQ09ORklHX0RSTV9NSVBJX0RTST15IGFuZCBD T05GSUdfRFJNPW0sCj4+Pj4gd2hpY2ggdmlvbGF0ZXMgRFJNX01JUElfRFNJIGRlcGVuZGVuY3kg b24gQ09ORklHX0RSTS4gVGhpcyBpcyBicm9rZW4gYW5kCj4+Pj4gc2hvdWxkIGJlIGZpeGVkLiBU aGUgc3VnZ2VzdGVkIHBhdGNoIGRvZXMgKm5vdCogZml4IHRoaXMgaXNzdWUuCj4+Pj4KPj4+IEph bmksIGdpdCBsb2cgc3VnZ2VzdHMgeW91IGFzIHRoZSB1bmZvcnR1bmF0ZSBhdXRob3Igb2YgdGhl IHNlbGVjdAo+Pj4gRFJNX01JUElfRFNJL3NlbGVjdCBEUk1fUEFORUwgaHVua3MgaW4gaTkxNSA7 LSkKPj4gL29cCj4+Cj4+IEFzIG11Y2ggYXMgbXkgcHJlc2VudCBzZWxmIHdvdWxkIGxpa2UgdG8g c2NvbGQgbXkgcGFzdCBzZWxmIGZvciBhbGwgaGlzCj4+IG1pc3Rha2VzLCBJIGhhdmUgdG8gcmVt aW5kIG15c2VsZiB0aGF0IGl0IGlzIHRoZSBtaXN0YWtlcyB0aGF0IGhhdmUKPj4gZ2l2ZW4gbWUg aW52YWx1YWJsZSBleHBlcmllbmNlIHRoYXQgbXkgcGFzdCBzZWxmIGRpZG4ndCBoYXZlLiBJIGNh biBvbmx5Cj4+IGhvcGUgbXkgZnV0dXJlIHNlbGYgd2lsbCBoYXZlIHRpbWUgdG8gZml4IGV2ZW4g YSBmcmFjdGlvbiBvZiB0aGUKPj4gbWlzdGFrZXMuCj4+Cj4+IEFueXdheSwgYXMgQW5kcnplaiBw b2ludGVkIG91dCwgYWxsIGNvbmZpZ3MgdGhhdCBzZWxlY3QgRFJNX01JUElfRFNJCj4+IGFsc28g ZGVwZW5kIG9uIERSTSwgc28gdGhpcyBwcm9ibGVtIGNhbid0IGN1cnJlbnRseSBvY2N1ci4gT25j ZSBkc2kgYnVzCj4+IHVuLXJlZ2lzdHJhdGlvbiBnZXRzIGFkZHJlc3NlZCwgd2UgY2FuIHR1cm4g RFJNX01JUElfRFNJIGludG8gYSB0cmlzdGF0ZQo+PiBjb25maWcgKGkuZS4gYSBsb2FkYWJsZSBt b2R1bGUpLgo+Cj4gVGhlcmUgaXMgYWxyZWFkeSBwYXRjaCBhZGRpbmcgYnVzIHVucmVnaXN0cmF0 aW9uIFsxXS4gSXQgd2FzIHB1Ymxpc2hlZAo+IHRvZ2V0aGVyCj4gd2l0aCAndHJpc3RhdGUnIHBh dGNoIFsyXSwgYm90aCB3ZXJlIGNyZWF0ZWQgYnkgVGFrYXNoaSBmZXcgbW9udGhzIGFnby4KClJp Z2h0LiBTbyBtYWtlIHRoYXQgIk9uY2UgZGlzIGJ1cyB1bi1yZWdpc3RyYXRpb24gZ2V0cyBtZXJn ZWQKdXBzdHJlYW0iLiA7KQoKQlIsCkphbmkuCgoKPgo+IFsxXToKPiBodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9kcmktZGV2ZWwvMjAxNi1BdWd1c3QvMTE0ODcwLmh0bWwK PiBbMl06Cj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRldmVs LzIwMTYtQXVndXN0LzExNDQ5Ny5odG1sCj4KPiBSZWdhcmRzCj4gQW5kcnplago+Cj4+Cj4+IEJS LAo+PiBKYW5pLgo+Pgo+CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hu b2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757157AbcJTNo5 (ORCPT ); Thu, 20 Oct 2016 09:44:57 -0400 Received: from mga14.intel.com ([192.55.52.115]:49527 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755635AbcJTNoz (ORCPT ); Thu, 20 Oct 2016 09:44:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,371,1473145200"; d="scan'208";a="775043447" From: Jani Nikula To: Andrzej Hajda , Emil Velikov Cc: "Sun\, Jing A" , Takashi Iwai , "airlied\@linux.ie" , "Vetter\, Daniel" , "linux-kernel\@vger.kernel.org" , "dri-devel\@lists.freedesktop.org" , Thierry Reding Subject: Re: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate". In-Reply-To: <34ef3414-952d-461f-bc3c-a47fadd1b69a@samsung.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <87h98ktxow.fsf@intel.com> <87lgxvqlg3.fsf@intel.com> <877f9dd4kp.fsf@intel.com> <34ef3414-952d-461f-bc3c-a47fadd1b69a@samsung.com> Date: Thu, 20 Oct 2016 16:44:49 +0300 Message-ID: <87k2d3qgmm.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Oct 2016, Andrzej Hajda wrote: > Hi Jani, > > Forgive me late response. > > On 12.10.2016 16:28, Jani Nikula wrote: >> On Wed, 12 Oct 2016, Emil Velikov wrote: >>> On 11 October 2016 at 10:33, Jani Nikula wrote: >>>> On Tue, 11 Oct 2016, "Sun, Jing A" wrote: >>>>> It's needed that DRM Driver module could be removed and reloaded after >>>>> kernel booting on the projects that I have been working on, and I hope >>>>> such module type change could be accepted. Looks like Iwai has similar >>>>> change request as well. Would you please review it and let us know if >>>>> any concerns? >>>> Looking at the Kconfig, selecting CONFIG_DRM_MIPI_DSI is against the >>>> recommendations of Documentation/kbuild/kconfig-language.txt: >>>> >>>> select should be used with care. select will force >>>> a symbol to a value without visiting the dependencies. >>>> By abusing select you are able to select a symbol FOO even >>>> if FOO depends on BAR that is not set. >>>> In general use select only for non-visible symbols >>>> (no prompts anywhere) and for symbols with no dependencies. >>>> That will limit the usefulness but on the other hand avoid >>>> the illegal configurations all over. >>>> >>>> Indeed, you may end up with CONFIG_DRM_MIPI_DSI=y and CONFIG_DRM=m, >>>> which violates DRM_MIPI_DSI dependency on CONFIG_DRM. This is broken and >>>> should be fixed. The suggested patch does *not* fix this issue. >>>> >>> Jani, git log suggests you as the unfortunate author of the select >>> DRM_MIPI_DSI/select DRM_PANEL hunks in i915 ;-) >> /o\ >> >> As much as my present self would like to scold my past self for all his >> mistakes, I have to remind myself that it is the mistakes that have >> given me invaluable experience that my past self didn't have. I can only >> hope my future self will have time to fix even a fraction of the >> mistakes. >> >> Anyway, as Andrzej pointed out, all configs that select DRM_MIPI_DSI >> also depend on DRM, so this problem can't currently occur. Once dsi bus >> un-registration gets addressed, we can turn DRM_MIPI_DSI into a tristate >> config (i.e. a loadable module). > > There is already patch adding bus unregistration [1]. It was published > together > with 'tristate' patch [2], both were created by Takashi few months ago. Right. So make that "Once dis bus un-registration gets merged upstream". ;) BR, Jani. > > [1]: > https://lists.freedesktop.org/archives/dri-devel/2016-August/114870.html > [2]: > https://lists.freedesktop.org/archives/dri-devel/2016-August/114497.html > > Regards > Andrzej > >> >> BR, >> Jani. >> > -- Jani Nikula, Intel Open Source Technology Center