From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55175)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aoUXo-0004vX-KT
	for qemu-devel@nongnu.org; Fri, 08 Apr 2016 07:25:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aoUXj-0005oc-By
	for qemu-devel@nongnu.org; Fri, 08 Apr 2016 07:25:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57546)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aoUXj-0005oY-6K
	for qemu-devel@nongnu.org; Fri, 08 Apr 2016 07:25:39 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <FA92D092-2DE4-4599-9CD9-EF42831F345E@gmail.com>
	<56FC0102.9060206@redhat.com>
Date: Fri, 08 Apr 2016 13:25:36 +0200
In-Reply-To: <56FC0102.9060206@redhat.com> (Paolo Bonzini's message of "Wed,
	30 Mar 2016 18:38:26 +0200")
Message-ID: <87k2k8wde7.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] fix missing event_notifier_init_fd()
 function on Mac OS X
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Programmingkid <programmingkidx@gmail.com>, qemu-devel qemu-devel <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>

[Wasn't delivered correctly by eggs.gnu.org, resending]

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 30/03/2016 18:35, Programmingkid wrote:
>> Remove macro that prevents event_notifier_init_fd() function from being compiled on Mac OS X.
>> 
>> This patch fixes this error:
>> 
>> Undefined symbols for architecture x86_64:
>>   "_event_notifier_init_fd", referenced from:
>>       _process_msg in ivshmem.o
>> ld: symbol(s) not found for architecture x86_64
>> collect2: error: ld returned 1 exit status
>> make[1]: *** [qemu-system-ppc] Error 1
>> make: *** [subdir-ppc-softmmu] Error 2
>> 
>> 
>> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
>
> This is intentional, this feature of ivshmem.o could never work on OS X.
>  I am not sure that failing the build is intentional.  Markus, any clue?

ivshmem.o should only be linked when CONFIG_EVENTFD is set.  pci.mak has

    CONFIG_IVSHMEM=$(CONFIG_EVENTFD)

The compile error shown above indicates CONFIG_EVENTFD=y for make (since
ivshmem.o gets linked), but !defined(CONFIG_EVENTFD) for C (or else
event_notifier_init_fd() would exist).  Your build tree is messed up, or
the makefiles are broken.  Try starting over with a fresh build tree.