From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDf7-0001IS-Pp for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:43:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHDf4-0006DJ-FD for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:43:45 -0500 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:55848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDf3-0006D2-Tf for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:43:42 -0500 Received: from localhost by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Jan 2016 02:43:39 +1000 Received: from d23relay09.au.ibm.com (d23relay09.au.ibm.com [9.185.63.181]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id BB8353578052 for ; Fri, 8 Jan 2016 03:43:36 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u07GhSf619792024 for ; Fri, 8 Jan 2016 03:43:36 +1100 Received: from d23av03.au.ibm.com (localhost [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u07Gh4lk022704 for ; Fri, 8 Jan 2016 03:43:04 +1100 From: "Aneesh Kumar K.V" In-Reply-To: <1452020761-24457-11-git-send-email-wei.liu2@citrix.com> References: <1452020761-24457-1-git-send-email-wei.liu2@citrix.com> <1452020761-24457-11-git-send-email-wei.liu2@citrix.com> Date: Thu, 07 Jan 2016 22:12:44 +0530 Message-ID: <87k2nlqr23.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 10/22] fsdev: break out 9p-marshal.{c, h} from virtio-9p-marshal.{c, h} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Liu , qemu-devel@nongnu.org Cc: Greg Kurz Wei Liu writes: > Break out some generic functions for marshaling 9p state. Pure code > motion plus minor fixes for build system. > > Signed-off-by: Wei Liu > --- > Makefile | 2 +- > fsdev/9p-marshal.c | 57 ++++++++++++++++++++++++++++++++ > fsdev/9p-marshal.h | 84 +++++++++++++++++++++++++++++++++++++++++++++++ > fsdev/Makefile.objs | 2 +- > fsdev/virtio-9p-marshal.c | 31 ----------------- > fsdev/virtio-9p-marshal.h | 79 +------------------------------------------- > 6 files changed, 144 insertions(+), 111 deletions(-) > create mode 100644 fsdev/9p-marshal.c > create mode 100644 fsdev/9p-marshal.h > > diff --git a/Makefile b/Makefile > index 82b2fc8..7e881d8 100644 > --- a/Makefile > +++ b/Makefile > @@ -240,7 +240,7 @@ qemu-io$(EXESUF): qemu-io.o $(block-obj-y) $(crypto-obj-y) $(qom-obj-y) libqemuu > > qemu-bridge-helper$(EXESUF): qemu-bridge-helper.o > > -fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/virtio-9p-marshal.o libqemuutil.a libqemustub.a > +fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/9p-marshal.o fsdev/virtio-9p-marshal.o libqemuutil.a libqemustub.a > fsdev/virtfs-proxy-helper$(EXESUF): LIBS += -lcap > > qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx > diff --git a/fsdev/9p-marshal.c b/fsdev/9p-marshal.c > new file mode 100644 > index 0000000..610978e > --- /dev/null > +++ b/fsdev/9p-marshal.c > @@ -0,0 +1,57 @@ > +/* > + * 9p backend > + * > + * Copyright IBM, Corp. 2010 > + * > + * Authors: > + * Anthony Liguori > + * Wei Liu If it is just code movement just retain the authors as it is ? > + * > + * This work is licensed under the terms of the GNU GPL, version 2. See > + * the COPYING file in the top-level directory. > + * > + */ > + -aneesh