From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] i915: correctly handling failed allocation Date: Wed, 30 Dec 2015 11:16:15 +0200 Message-ID: <87k2nwe1pc.fsf@intel.com> References: <1451415713-9508-1-git-send-email-wuninsu@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1451415713-9508-1-git-send-email-wuninsu@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: daniel.vetter@intel.com, airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: yeongjin.jang@gatech.edu, taesoo@gatech.edu, insu@gatech.edu, Insu Yun , changwoo@gatech.edu List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyOSBEZWMgMjAxNSwgSW5zdSBZdW4gPHd1bmluc3VAZ21haWwuY29tPiB3cm90ZToK PiBTaWduZWQtb2ZmLWJ5OiBJbnN1IFl1biA8d3VuaW5zdUBnbWFpbC5jb20+Cj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaV9wYW5lbF92YnQuYyB8IDIgKysKPiAgMSBmaWxl IGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RzaV9wYW5lbF92YnQuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RzaV9wYW5lbF92YnQuYwo+IGluZGV4IGE1ZTk5YWMuLjRlMjc5ZGQgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3BhbmVsX3ZidC5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3BhbmVsX3ZidC5jCj4gQEAgLTY2Niw2ICs2NjYsOCBA QCBzdHJ1Y3QgZHJtX3BhbmVsICp2YnRfcGFuZWxfaW5pdChzdHJ1Y3QgaW50ZWxfZHNpICppbnRl bF9kc2ksIHUxNiBwYW5lbF9pZCkKPiAgCj4gIAkvKiBUaGlzIGlzIGNoZWF0aW5nIGEgYml0IHdp dGggdGhlIGNsZWFudXAuICovCj4gIAl2YnRfcGFuZWwgPSBkZXZtX2t6YWxsb2MoZGV2LT5kZXYs IHNpemVvZigqdmJ0X3BhbmVsKSwgR0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIXZidF9wYW5uZWwpCj4g KwkJcmV0dXJuIE5VTEw7CgpXZSBoYXZlIGJ1aWxkIGJvdHMgYW5kIENJLCBidXQgdGhlIGxlYXN0 IHlvdSBtdXN0IGRvIGlzIGJ1aWxkIHRoZSBjb2RlCnlvdSBjaGFuZ2UgYmVmb3JlIHN1Ym1pdHRp bmcgcGF0Y2hlcy4KCkJSLApKYW5pLgoKCj4gIAo+ICAJdmJ0X3BhbmVsLT5pbnRlbF9kc2kgPSBp bnRlbF9kc2k7Cj4gIAlkcm1fcGFuZWxfaW5pdCgmdmJ0X3BhbmVsLT5wYW5lbCk7CgotLSAKSmFu aSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754442AbbL3JRG (ORCPT ); Wed, 30 Dec 2015 04:17:06 -0500 Received: from mga09.intel.com ([134.134.136.24]:29025 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754375AbbL3JQm (ORCPT ); Wed, 30 Dec 2015 04:16:42 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,500,1444719600"; d="scan'208";a="883374318" From: Jani Nikula To: Insu Yun , daniel.vetter@intel.com, airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu, Insu Yun Subject: Re: [PATCH] i915: correctly handling failed allocation In-Reply-To: <1451415713-9508-1-git-send-email-wuninsu@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1451415713-9508-1-git-send-email-wuninsu@gmail.com> User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Wed, 30 Dec 2015 11:16:15 +0200 Message-ID: <87k2nwe1pc.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Dec 2015, Insu Yun wrote: > Signed-off-by: Insu Yun > --- > drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > index a5e99ac..4e279dd 100644 > --- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > +++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > @@ -666,6 +666,8 @@ struct drm_panel *vbt_panel_init(struct intel_dsi *intel_dsi, u16 panel_id) > > /* This is cheating a bit with the cleanup. */ > vbt_panel = devm_kzalloc(dev->dev, sizeof(*vbt_panel), GFP_KERNEL); > + if (!vbt_pannel) > + return NULL; We have build bots and CI, but the least you must do is build the code you change before submitting patches. BR, Jani. > > vbt_panel->intel_dsi = intel_dsi; > drm_panel_init(&vbt_panel->panel); -- Jani Nikula, Intel Open Source Technology Center