Re: [PATCH v2] sh-sci: Get register size from platform data

[Yoshinori Sato <ysato@users.sourceforge.jp>]

On Sun, 17 May 2015 03:18:30 +0900,
Sergei Shtylyov wrote:
> 
> Hello.
> 
> On 05/16/2015 06:03 PM, Yoshinori Sato wrote:
> 
> > There is much implement of SCI,
> 
>    Many implementations, you mean?

There is much SCI of SoC having within,
and the register size is also different in everyone.

> > So the register size should be acquired from platform data.
> 
>    You're not acquiring them from the platform data, you're using
> platform device resources for that.

Yes.
platform device is correct.

> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> 
> [...]
> > @@ -2207,6 +2198,7 @@ static int sci_init_single(struct platform_device *dev,
> >   		return -ENOMEM;
> > 
> >   	port->mapbase = res->start;
> > +	sci_port->reg_size = res->end - res->start + 1;
> 
>    Use resource_size(res) instead, please.

OK.
I'll update.

Thanks.

> [...]
> 
> WBR, Sergei
> 

-- 
Yoshinori Sato
<ysato@users.sourceforge.jp>