From mboxrd@z Thu Jan 1 00:00:00 1970 From: OGAWA Hirofumi Subject: Re: [PATCH v3 1/1] ioctl-fat.2: new manpage for the ioctl fat API Date: Tue, 03 Feb 2015 17:51:23 +0900 Message-ID: <87k2zze5tg.fsf@mail.parknet.co.jp> References: <1422042884-10824-1-git-send-email-xypron.glpk@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Michael Kerrisk's message of "Tue, 3 Feb 2015 09:25:50 +0100") Sender: linux-kernel-owner@vger.kernel.org To: "Michael Kerrisk (man-pages)" Cc: Heinrich Schuchardt , "linux-fsdevel@vger.kernel.org" , lkml , linux-man List-Id: linux-man@vger.kernel.org "Michael Kerrisk (man-pages)" writes: > Hello Heinrich and Ogawa, Hi, > On 23 January 2015 at 20:54, Heinrich Schuchardt wrote: >> The ioctl(2) system call may be used to retrieve information about >> the fat file system and to set file attributes. >> >> This new manpage describes the details. > > @Ogawa, as the FAT maintainer, might you be willing to review this page? for (;;) { /* * Read next directory entry. */ ret = ioctl( fd, VFAT_IOCTL_READDIR_BOTH, entry); /* * If an error occurs, the return value is -1. * If d_reclen is zero, the end of the directory * list has been reached. */ if (ret == -1 || entry[0].d_reclen == 0) break; Quick reviewed, and looks good. However, entry[0].d_reclen == 0 works as backward compatibility though. The example might be good to use usual way of getdents(). I.e., "ret" means -1 == error 0 == EOD 0 > how many bytes read Thanks. -- OGAWA Hirofumi From mboxrd@z Thu Jan 1 00:00:00 1970 From: OGAWA Hirofumi Subject: Re: [PATCH v3 1/1] ioctl-fat.2: new manpage for the ioctl fat API Date: Tue, 03 Feb 2015 17:51:23 +0900 Message-ID: <87k2zze5tg.fsf@mail.parknet.co.jp> References: <1422042884-10824-1-git-send-email-xypron.glpk@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Cc: Heinrich Schuchardt , "linux-fsdevel\@vger.kernel.org" , lkml , linux-man To: "Michael Kerrisk \(man-pages\)" Return-path: In-Reply-To: (Michael Kerrisk's message of "Tue, 3 Feb 2015 09:25:50 +0100") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org "Michael Kerrisk (man-pages)" writes: > Hello Heinrich and Ogawa, Hi, > On 23 January 2015 at 20:54, Heinrich Schuchardt wrote: >> The ioctl(2) system call may be used to retrieve information about >> the fat file system and to set file attributes. >> >> This new manpage describes the details. > > @Ogawa, as the FAT maintainer, might you be willing to review this page? for (;;) { /* * Read next directory entry. */ ret = ioctl( fd, VFAT_IOCTL_READDIR_BOTH, entry); /* * If an error occurs, the return value is -1. * If d_reclen is zero, the end of the directory * list has been reached. */ if (ret == -1 || entry[0].d_reclen == 0) break; Quick reviewed, and looks good. However, entry[0].d_reclen == 0 works as backward compatibility though. The example might be good to use usual way of getdents(). I.e., "ret" means -1 == error 0 == EOD 0 > how many bytes read Thanks. -- OGAWA Hirofumi