From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Init PPGTT before context enable
Date: Wed, 21 Jan 2015 18:33:40 +0200 [thread overview]
Message-ID: <87k30g5c0r.fsf@intel.com> (raw)
In-Reply-To: <20150121095105.GD18602@nuc-i3427.alporthouse.com>
On Wed, 21 Jan 2015, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Wed, Jan 21, 2015 at 10:35:58AM +0100, Daniel Vetter wrote:
>> On Tue, Jan 20, 2015 at 05:21:42PM +0000, David Woodhouse wrote:
>> > Commit 82460d972 ("drm/i915: Rework ppgtt init to no require an aliasing
>> > ppgtt") introduced a regression on Broadwell, triggering the following
>> > IOMMU fault at startup:
>> >
>> > vgaarb: device changed decodes: PCI:0000:00:02.0,olddecodes=io+mem,decodes=io+mem:owns=io+mem
>> > dmar: DRHD: handling fault status reg 2
>> > dmar: DMAR:[DMA Write] Request device [00:02.0] fault addr 880000
>> > DMAR:[fault reason 23] Unknown
>> > fbcon: inteldrmfb (fb0) is primary device
>> >
>> > Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
>> > Cc: stable@vger.kernel.org
>>
>> I sugggested this change to David after staring at the offending patch for
>> a while. I have no idea and theory whatsoever why this would upset the gpu
>> less than the other way round. But it seems to work. David promised to
>> chase hw people a bit more to get a more meaningful answer.
>
> The issue is likely the execution of the golden render state batch
> concurrently with the flip over to ppgtt. The GPU throws a pagefault and
> we get an ERROR reported.
>
> http://patchwork.freedesktop.org/patch/38270/
> http://patchwork.freedesktop.org/patch/38269/
Pushed the revert to drm-intel-fixes, it's cc: stable and it's getting
late in the rc's too. Thanks for the patch and review.
BR,
Jani.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-01-21 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 17:21 [PATCH] drm/i915: Init PPGTT before context enable David Woodhouse
2015-01-21 9:35 ` Daniel Vetter
2015-01-21 9:51 ` Chris Wilson
2015-01-21 16:33 ` Jani Nikula [this message]
2015-01-21 17:56 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k30g5c0r.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.