Re: [PATCH 4/7] drm/i915: Don't pretend SDVO hotplug works on 915

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 09 Jan 2015, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> 915 doens't support hotplug at all, so we shouldn't try to pretend
> otherwise in the SDVO code.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/intel_sdvo.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
> index 6d7a277..4e3d362 100644
> --- a/drivers/gpu/drm/i915/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> @@ -1617,6 +1617,9 @@ static uint16_t intel_sdvo_get_hotplug_support(struct intel_sdvo *intel_sdvo)
>  	struct drm_device *dev = intel_sdvo->base.base.dev;
>  	uint16_t hotplug;
>  
> +	if (!I915_HAS_HOTPLUG(dev))
> +		return 0;
> +
>  	/* HW Erratum: SDVO Hotplug is broken on all i945G chips, there's noise
>  	 * on the line. */
>  	if (IS_I945G(dev) || IS_I945GM(dev))
> -- 
> 2.0.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx