From: Jani Nikula <jani.nikula@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Remove '& 0xffff' from the mask given to WA_REG()
Date: Wed, 10 Dec 2014 16:41:28 +0200 [thread overview]
Message-ID: <87k31zh8iv.fsf@intel.com> (raw)
In-Reply-To: <1418060138-5004-2-git-send-email-damien.lespiau@intel.com>
On Mon, 08 Dec 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> We may be hidding bugs by doing that, so let remove it and have the
> actual mask value shine through, for better or worse.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Pushed these two to drm-intel-next-fixes, thanks for the patches.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index 4f63c39..c715ef0 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -734,10 +734,10 @@ static int wa_add(struct drm_i915_private *dev_priv,
> }
>
> #define WA_SET_BIT_MASKED(addr, mask) \
> - WA_REG(addr, (mask) & 0xffff, _MASKED_BIT_ENABLE(mask))
> + WA_REG(addr, (mask), _MASKED_BIT_ENABLE(mask))
>
> #define WA_CLR_BIT_MASKED(addr, mask) \
> - WA_REG(addr, (mask) & 0xffff, _MASKED_BIT_DISABLE(mask))
> + WA_REG(addr, (mask), _MASKED_BIT_DISABLE(mask))
>
> #define WA_SET_FIELD_MASKED(addr, mask, value) \
> WA_REG(addr, mask, _MASKED_FIELD(mask, value))
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-12-10 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 17:35 [PATCH 1/2] drm/i915: Invert the mask and val arguments in wa_add() and WA_REG() Damien Lespiau
2014-12-08 17:35 ` [PATCH 2/2] drm/i915: Remove '& 0xffff' from the mask given to WA_REG() Damien Lespiau
2014-12-10 14:41 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k31zh8iv.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.