From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] gpu: drm: i915: intel_sideband.c: Remove some unused functions Date: Mon, 08 Dec 2014 12:15:19 +0200 Message-ID: <87k322o3bc.fsf@intel.com> References: <1417960301-11366-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1417960301-11366-1-git-send-email-rickard_strandqvist@spectrumdigital.se> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rickard Strandqvist List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCAwNyBEZWMgMjAxNCwgUmlja2FyZCBTdHJhbmRxdmlzdCA8cmlja2FyZF9zdHJhbmRx dmlzdEBzcGVjdHJ1bWRpZ2l0YWwuc2U+IHdyb3RlOgo+IFJlbW92ZXMgc29tZSBmdW5jdGlvbnMg dGhhdCBhcmUgbm90IHVzZWQgYW55d2hlcmU6Cj4gdmx2X2ZsaXNkc2lfcmVhZCgpIHZsdl9ncHNf Y29yZV93cml0ZSgpIHZsdl9ncHNfY29yZV9yZWFkKCkKPiB2bHZfY2N1X3dyaXRlKCkgdmx2X2Nj dV9yZWFkKCkgdmx2X2dwaW9fbmNfcmVhZCgpCgpJJ2QgbGV0IHRoZW0gYmUuCgpCUiwKSmFuaS4K Cgo+Cj4gVGhpcyB3YXMgcGFydGlhbGx5IGZvdW5kIGJ5IHVzaW5nIGEgc3RhdGljIGNvZGUgYW5h bHlzaXMgcHJvZ3JhbSBjYWxsZWQgY3BwY2hlY2suCj4KPiBTaWduZWQtb2ZmLWJ5OiBSaWNrYXJk IFN0cmFuZHF2aXN0IDxyaWNrYXJkX3N0cmFuZHF2aXN0QHNwZWN0cnVtZGlnaXRhbC5zZT4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgICB8ICAgIDYgLS0tLS0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2lkZWJhbmQuYyB8ICAgNDQgLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgNTAgZGVsZXRpb25z KC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRleCAxNmE2ZjZkLi5kMjQ4OTU3IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAgLTI4NDksMjMgKzI4NDksMTcgQEAgaW50 IHNhbmR5YnJpZGdlX3Bjb2RlX3dyaXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwgdTggbWJveCwgdTMyIHZhbCkKPiAgdTMyIHZsdl9wdW5pdF9yZWFkKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwgdTggYWRkcik7Cj4gIHZvaWQgdmx2X3B1bml0X3dyaXRlKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTggYWRkciwgdTMyIHZhbCk7Cj4gIHUz MiB2bHZfbmNfcmVhZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHU4IGFkZHIp Owo+IC11MzIgdmx2X2dwaW9fbmNfcmVhZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsIHUzMiByZWcpOwo+ICB2b2lkIHZsdl9ncGlvX25jX3dyaXRlKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiwgdTMyIHJlZywgdTMyIHZhbCk7Cj4gIHUzMiB2bHZfY2NrX3JlYWQo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgcmVnKTsKPiAgdm9pZCB2bHZf Y2NrX3dyaXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTMyIHJlZywgdTMy IHZhbCk7Cj4gLXUzMiB2bHZfY2N1X3JlYWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LCB1MzIgcmVnKTsKPiAtdm9pZCB2bHZfY2N1X3dyaXRlKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiwgdTMyIHJlZywgdTMyIHZhbCk7Cj4gIHUzMiB2bHZfYnVuaXRfcmVhZChz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiByZWcpOwo+ICB2b2lkIHZsdl9i dW5pdF93cml0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiByZWcsIHUz MiB2YWwpOwo+IC11MzIgdmx2X2dwc19jb3JlX3JlYWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LCB1MzIgcmVnKTsKPiAtdm9pZCB2bHZfZ3BzX2NvcmVfd3JpdGUoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgcmVnLCB1MzIgdmFsKTsKPiAgdTMyIHZsdl9k cGlvX3JlYWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBlbnVtIHBpcGUgcGlw ZSwgaW50IHJlZyk7Cj4gIHZvaWQgdmx2X2RwaW9fd3JpdGUoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LCBlbnVtIHBpcGUgcGlwZSwgaW50IHJlZywgdTMyIHZhbCk7Cj4gIHUzMiBp bnRlbF9zYmlfcmVhZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUxNiByZWcs Cj4gIAkJICAgZW51bSBpbnRlbF9zYmlfZGVzdGluYXRpb24gZGVzdGluYXRpb24pOwo+ICB2b2lk IGludGVsX3NiaV93cml0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUxNiBy ZWcsIHUzMiB2YWx1ZSwKPiAgCQkgICAgIGVudW0gaW50ZWxfc2JpX2Rlc3RpbmF0aW9uIGRlc3Rp bmF0aW9uKTsKPiAtdTMyIHZsdl9mbGlzZHNpX3JlYWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LCB1MzIgcmVnKTsKPiAgdm9pZCB2bHZfZmxpc2RzaV93cml0ZShzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiByZWcsIHUzMiB2YWwpOwo+ICAKPiAgaW50IHZs dl9ncHVfZnJlcShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGludCB2YWwpOwo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zaWRlYmFuZC5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2lkZWJhbmQuYwo+IGluZGV4IDAxZDg0MWUuLjU5Mzkx NzEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2lkZWJhbmQuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3NpZGViYW5kLmMKPiBAQCAtMTI5LDE0 ICsxMjksNiBAQCB1MzIgdmx2X25jX3JlYWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LCB1OCBhZGRyKQo+ICAJcmV0dXJuIHZhbDsKPiAgfQo+ICAKPiAtdTMyIHZsdl9ncGlvX25j X3JlYWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgcmVnKQo+IC17Cj4g LQl1MzIgdmFsID0gMDsKPiAtCXZsdl9zaWRlYmFuZF9ydyhkZXZfcHJpdiwgUENJX0RFVkZOKDIs IDApLCBJT1NGX1BPUlRfR1BJT19OQywKPiAtCQkJU0JfQ1JSRERBX05QLCByZWcsICZ2YWwpOwo+ IC0JcmV0dXJuIHZhbDsKPiAtfQo+IC0KPiAgdm9pZCB2bHZfZ3Bpb19uY193cml0ZShzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiByZWcsIHUzMiB2YWwpCj4gIHsKPiAgCXZs dl9zaWRlYmFuZF9ydyhkZXZfcHJpdiwgUENJX0RFVkZOKDIsIDApLCBJT1NGX1BPUlRfR1BJT19O QywKPiBAQCAtMTU3LDM0ICsxNDksNiBAQCB2b2lkIHZsdl9jY2tfd3JpdGUoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgcmVnLCB1MzIgdmFsKQo+ICAJCQlTQl9DUldSREFf TlAsIHJlZywgJnZhbCk7Cj4gIH0KPiAgCj4gLXUzMiB2bHZfY2N1X3JlYWQoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgcmVnKQo+IC17Cj4gLQl1MzIgdmFsID0gMDsKPiAt CXZsdl9zaWRlYmFuZF9ydyhkZXZfcHJpdiwgUENJX0RFVkZOKDIsIDApLCBJT1NGX1BPUlRfQ0NV LAo+IC0JCQlTQl9DUlJEREFfTlAsIHJlZywgJnZhbCk7Cj4gLQlyZXR1cm4gdmFsOwo+IC19Cj4g LQo+IC12b2lkIHZsdl9jY3Vfd3JpdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LCB1MzIgcmVnLCB1MzIgdmFsKQo+IC17Cj4gLQl2bHZfc2lkZWJhbmRfcncoZGV2X3ByaXYsIFBD SV9ERVZGTigyLCAwKSwgSU9TRl9QT1JUX0NDVSwKPiAtCQkJU0JfQ1JXUkRBX05QLCByZWcsICZ2 YWwpOwo+IC19Cj4gLQo+IC11MzIgdmx2X2dwc19jb3JlX3JlYWQoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LCB1MzIgcmVnKQo+IC17Cj4gLQl1MzIgdmFsID0gMDsKPiAtCXZsdl9z aWRlYmFuZF9ydyhkZXZfcHJpdiwgUENJX0RFVkZOKDIsIDApLCBJT1NGX1BPUlRfR1BTX0NPUkUs Cj4gLQkJCVNCX0NSUkREQV9OUCwgcmVnLCAmdmFsKTsKPiAtCXJldHVybiB2YWw7Cj4gLX0KPiAt Cj4gLXZvaWQgdmx2X2dwc19jb3JlX3dyaXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiwgdTMyIHJlZywgdTMyIHZhbCkKPiAtewo+IC0Jdmx2X3NpZGViYW5kX3J3KGRldl9wcml2 LCBQQ0lfREVWRk4oMiwgMCksIElPU0ZfUE9SVF9HUFNfQ09SRSwKPiAtCQkJU0JfQ1JXUkRBX05Q LCByZWcsICZ2YWwpOwo+IC19Cj4gLQo+ICB1MzIgdmx2X2RwaW9fcmVhZChzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcGlwZSBwaXBlLCBpbnQgcmVnKQo+ICB7Cj4gIAl1 MzIgdmFsID0gMDsKPiBAQCAtMjY3LDE0ICsyMzEsNiBAQCB2b2lkIGludGVsX3NiaV93cml0ZShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUxNiByZWcsIHUzMiB2YWx1ZSwKPiAg CX0KPiAgfQo+ICAKPiAtdTMyIHZsdl9mbGlzZHNpX3JlYWQoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LCB1MzIgcmVnKQo+IC17Cj4gLQl1MzIgdmFsID0gMDsKPiAtCXZsdl9zaWRl YmFuZF9ydyhkZXZfcHJpdiwgRFBJT19ERVZGTiwgSU9TRl9QT1JUX0ZMSVNEU0ksIFNCX0NSUkRE QV9OUCwKPiAtCQkJcmVnLCAmdmFsKTsKPiAtCXJldHVybiB2YWw7Cj4gLX0KPiAtCj4gIHZvaWQg dmx2X2ZsaXNkc2lfd3JpdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIg cmVnLCB1MzIgdmFsKQo+ICB7Cj4gIAl2bHZfc2lkZWJhbmRfcncoZGV2X3ByaXYsIERQSU9fREVW Rk4sIElPU0ZfUE9SVF9GTElTRFNJLCBTQl9DUldSREFfTlAsCj4gLS0gCj4gMS43LjEwLjQKPgoK LS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754844AbaLHKPx (ORCPT ); Mon, 8 Dec 2014 05:15:53 -0500 Received: from mga11.intel.com ([192.55.52.93]:22842 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754793AbaLHKPw (ORCPT ); Mon, 8 Dec 2014 05:15:52 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,537,1413270000"; d="scan'208";a="634348626" From: Jani Nikula To: Rickard Strandqvist , Daniel Vetter Cc: Rickard Strandqvist , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpu: drm: i915: intel_sideband.c: Remove some unused functions In-Reply-To: <1417960301-11366-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1417960301-11366-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Notmuch/0.19~rc1+1~g08b4944 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Mon, 08 Dec 2014 12:15:19 +0200 Message-ID: <87k322o3bc.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 07 Dec 2014, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > vlv_flisdsi_read() vlv_gps_core_write() vlv_gps_core_read() > vlv_ccu_write() vlv_ccu_read() vlv_gpio_nc_read() I'd let them be. BR, Jani. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > drivers/gpu/drm/i915/i915_drv.h | 6 ----- > drivers/gpu/drm/i915/intel_sideband.c | 44 --------------------------------- > 2 files changed, 50 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 16a6f6d..d248957 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -2849,23 +2849,17 @@ int sandybridge_pcode_write(struct drm_i915_private *dev_priv, u8 mbox, u32 val) > u32 vlv_punit_read(struct drm_i915_private *dev_priv, u8 addr); > void vlv_punit_write(struct drm_i915_private *dev_priv, u8 addr, u32 val); > u32 vlv_nc_read(struct drm_i915_private *dev_priv, u8 addr); > -u32 vlv_gpio_nc_read(struct drm_i915_private *dev_priv, u32 reg); > void vlv_gpio_nc_write(struct drm_i915_private *dev_priv, u32 reg, u32 val); > u32 vlv_cck_read(struct drm_i915_private *dev_priv, u32 reg); > void vlv_cck_write(struct drm_i915_private *dev_priv, u32 reg, u32 val); > -u32 vlv_ccu_read(struct drm_i915_private *dev_priv, u32 reg); > -void vlv_ccu_write(struct drm_i915_private *dev_priv, u32 reg, u32 val); > u32 vlv_bunit_read(struct drm_i915_private *dev_priv, u32 reg); > void vlv_bunit_write(struct drm_i915_private *dev_priv, u32 reg, u32 val); > -u32 vlv_gps_core_read(struct drm_i915_private *dev_priv, u32 reg); > -void vlv_gps_core_write(struct drm_i915_private *dev_priv, u32 reg, u32 val); > u32 vlv_dpio_read(struct drm_i915_private *dev_priv, enum pipe pipe, int reg); > void vlv_dpio_write(struct drm_i915_private *dev_priv, enum pipe pipe, int reg, u32 val); > u32 intel_sbi_read(struct drm_i915_private *dev_priv, u16 reg, > enum intel_sbi_destination destination); > void intel_sbi_write(struct drm_i915_private *dev_priv, u16 reg, u32 value, > enum intel_sbi_destination destination); > -u32 vlv_flisdsi_read(struct drm_i915_private *dev_priv, u32 reg); > void vlv_flisdsi_write(struct drm_i915_private *dev_priv, u32 reg, u32 val); > > int vlv_gpu_freq(struct drm_i915_private *dev_priv, int val); > diff --git a/drivers/gpu/drm/i915/intel_sideband.c b/drivers/gpu/drm/i915/intel_sideband.c > index 01d841e..5939171 100644 > --- a/drivers/gpu/drm/i915/intel_sideband.c > +++ b/drivers/gpu/drm/i915/intel_sideband.c > @@ -129,14 +129,6 @@ u32 vlv_nc_read(struct drm_i915_private *dev_priv, u8 addr) > return val; > } > > -u32 vlv_gpio_nc_read(struct drm_i915_private *dev_priv, u32 reg) > -{ > - u32 val = 0; > - vlv_sideband_rw(dev_priv, PCI_DEVFN(2, 0), IOSF_PORT_GPIO_NC, > - SB_CRRDDA_NP, reg, &val); > - return val; > -} > - > void vlv_gpio_nc_write(struct drm_i915_private *dev_priv, u32 reg, u32 val) > { > vlv_sideband_rw(dev_priv, PCI_DEVFN(2, 0), IOSF_PORT_GPIO_NC, > @@ -157,34 +149,6 @@ void vlv_cck_write(struct drm_i915_private *dev_priv, u32 reg, u32 val) > SB_CRWRDA_NP, reg, &val); > } > > -u32 vlv_ccu_read(struct drm_i915_private *dev_priv, u32 reg) > -{ > - u32 val = 0; > - vlv_sideband_rw(dev_priv, PCI_DEVFN(2, 0), IOSF_PORT_CCU, > - SB_CRRDDA_NP, reg, &val); > - return val; > -} > - > -void vlv_ccu_write(struct drm_i915_private *dev_priv, u32 reg, u32 val) > -{ > - vlv_sideband_rw(dev_priv, PCI_DEVFN(2, 0), IOSF_PORT_CCU, > - SB_CRWRDA_NP, reg, &val); > -} > - > -u32 vlv_gps_core_read(struct drm_i915_private *dev_priv, u32 reg) > -{ > - u32 val = 0; > - vlv_sideband_rw(dev_priv, PCI_DEVFN(2, 0), IOSF_PORT_GPS_CORE, > - SB_CRRDDA_NP, reg, &val); > - return val; > -} > - > -void vlv_gps_core_write(struct drm_i915_private *dev_priv, u32 reg, u32 val) > -{ > - vlv_sideband_rw(dev_priv, PCI_DEVFN(2, 0), IOSF_PORT_GPS_CORE, > - SB_CRWRDA_NP, reg, &val); > -} > - > u32 vlv_dpio_read(struct drm_i915_private *dev_priv, enum pipe pipe, int reg) > { > u32 val = 0; > @@ -267,14 +231,6 @@ void intel_sbi_write(struct drm_i915_private *dev_priv, u16 reg, u32 value, > } > } > > -u32 vlv_flisdsi_read(struct drm_i915_private *dev_priv, u32 reg) > -{ > - u32 val = 0; > - vlv_sideband_rw(dev_priv, DPIO_DEVFN, IOSF_PORT_FLISDSI, SB_CRRDDA_NP, > - reg, &val); > - return val; > -} > - > void vlv_flisdsi_write(struct drm_i915_private *dev_priv, u32 reg, u32 val) > { > vlv_sideband_rw(dev_priv, DPIO_DEVFN, IOSF_PORT_FLISDSI, SB_CRWRDA_NP, > -- > 1.7.10.4 > -- Jani Nikula, Intel Open Source Technology Center