From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Todd Previte <tprevite@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Ignore long hpds on eDP ports
Date: Wed, 22 Oct 2014 16:42:41 +0300 [thread overview]
Message-ID: <87k33ste3y.fsf@intel.com> (raw)
In-Reply-To: <20141021160005.GY26941@phenom.ffwll.local>
On Tue, 21 Oct 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Oct 17, 2014 at 09:08:28AM -0700, Todd Previte wrote:
>>
>> On 10/17/2014 1:43 AM, Ville Syrjälä wrote:
>> >On Thu, Oct 16, 2014 at 12:38:55PM -0700, Todd Previte wrote:
>> >>On 10/16/2014 10:46 AM, ville.syrjala@linux.intel.com wrote:
>> >>>From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> >>>
>> >>>Turning vdd on/off can generate a long hpd pulse on eDP ports. In order
>> >>>to handle hpd we would need to turn on vdd to perform aux transfers.
>> >>>This would lead to an endless cycle of
>> >>>"vdd off -> long hpd -> vdd on -> detect -> vdd off -> ..."
>> >>>
>> >>>So ignore long hpd pulses on eDP ports. eDP panels should be physically
>> >>>tied to the machine anyway so they should not actually disappear and
>> >>>thus don't need long hpd handling. Short hpds are still needed for link
>> >>>re-train and whatnot so we can't just turn off the hpd interrupt
>> >>>entirely for eDP ports. Perhaps we could turn it off whenever the panel
>> >>>is disabled, but just ignoring the long hpd seems sufficient.
>> >>>
>> >>>Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
...
> Anyway, Cc: stable@vger.kernel.org and one for Jani.
Pushed both patches to drm-intel-fixes, thanks for the patches and
review.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-10-22 13:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 17:46 [PATCH 1/2] drm/i915: Do a dummy DPCD read before the actual read ville.syrjala
2014-10-16 17:46 ` [PATCH 2/2] drm/i915: Ignore long hpds on eDP ports ville.syrjala
2014-10-16 19:38 ` Todd Previte
2014-10-17 8:43 ` Ville Syrjälä
2014-10-17 16:08 ` Todd Previte
2014-10-21 16:00 ` Daniel Vetter
2014-10-22 1:22 ` Dave Airlie
2014-10-22 7:39 ` Ville Syrjälä
2014-10-22 13:42 ` Jani Nikula [this message]
2014-10-17 3:37 ` Dave Airlie
2014-10-17 8:49 ` Jani Nikula
2014-10-17 9:00 ` Ville Syrjälä
2014-10-16 19:39 ` [PATCH 1/2] drm/i915: Do a dummy DPCD read before the actual read Todd Previte
2014-10-17 9:06 ` Ville Syrjälä
2014-10-17 16:13 ` Todd Previte
2014-10-21 15:57 ` Daniel Vetter
2014-10-17 8:43 ` Jani Nikula
2014-10-17 8:59 ` Ville Syrjälä
2014-10-17 16:38 ` Todd Previte
2014-10-17 16:10 ` Todd Previte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k33ste3y.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tprevite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.