From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5YqF-0004Sq-Ux for qemu-devel@nongnu.org; Fri, 11 Jul 2014 07:18:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X5Yq6-00070n-Sb for qemu-devel@nongnu.org; Fri, 11 Jul 2014 07:18:15 -0400 Received: from oxygen.pond.sub.org ([2a01:4f8:201:233:1::3]:34113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5Yq6-00070P-ME for qemu-devel@nongnu.org; Fri, 11 Jul 2014 07:18:06 -0400 From: Markus Armbruster References: <1405071380-13652-1-git-send-email-kraxel@redhat.com> <1405071380-13652-2-git-send-email-kraxel@redhat.com> Date: Fri, 11 Jul 2014 13:18:04 +0200 In-Reply-To: <1405071380-13652-2-git-send-email-kraxel@redhat.com> (Gerd Hoffmann's message of "Fri, 11 Jul 2014 11:36:20 +0200") Message-ID: <87k37k9mab.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PULL 1/1] spice: auth fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Anthony Liguori Gerd Hoffmann writes: > Set auth to sasl when sasl is enabled, this makes "info spice" correctly > display sasl auth. Fixes SPICE_CHANNEL_EVENT_CONNECTED similarly, doesn't it? If yes, I'd recommend to note this in the commit message. > Also throw an error in case someone tries to set > a spice password via monitor without auth mode being "spice". > > Signed-off-by: Gerd Hoffmann Since the patch looks fine to me: Reviewed-by: Markus Armbruster