From: "Zhao\, Gang" <gamerh2o@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 03/12] mac80211: minor changes of ieee80211_reconfig()
Date: Wed, 23 Apr 2014 15:48:13 +0800 [thread overview]
Message-ID: <87k3agjxky.fsf@gmail.com> (raw)
In-Reply-To: <1398178044.4211.9.camel@jlt4.sipsolutions.net> (Johannes Berg's message of "Tue, 22 Apr 2014 16:47:24 +0200")
On Tue, 2014-04-22 at 16:47:24 +0200, Johannes Berg wrote:
> On Mon, 2014-04-21 at 12:52 +0800, Zhao, Gang wrote:
>> Try to update chanctx only if local->use_chanctx is true.
>
> I'm not convinced this part is correct, since the internal channel
> context handling also has an effect when the driver doesn't use it.
Actually ieee80211_assign_chanctx() checks if local->use_chanctx is
true, so this patch doesn't change the logic. I should mentioned it in
the commit log.
> Have you really thought this through?
>
> johannes
next prev parent reply other threads:[~2014-04-23 7:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 4:52 [PATCH 00/12] [mac80211-next] minor changes and cleanup Zhao, Gang
2014-04-21 4:52 ` [PATCH 01/12] mac80211: unify debug function Zhao, Gang
2014-04-22 14:44 ` Johannes Berg
2014-04-21 4:52 ` [PATCH 02/12] mac80211: remove config option check Zhao, Gang
2014-04-22 14:44 ` Johannes Berg
2014-04-21 4:52 ` [PATCH 03/12] mac80211: minor changes of ieee80211_reconfig() Zhao, Gang
2014-04-22 14:47 ` Johannes Berg
2014-04-23 7:48 ` Zhao, Gang [this message]
2014-04-25 15:37 ` Johannes Berg
2014-04-26 1:43 ` [PATCH 1/2] mac80211: beautify the code Zhao, Gang
2014-04-26 1:43 ` [PATCH 2/2] mac80211: remove unnecessary assignment Zhao, Gang
2014-04-28 15:53 ` [PATCH 1/2] mac80211: beautify the code Johannes Berg
2014-04-21 4:52 ` [PATCH 04/12] mac80211: return bool instead of numbers in yes/no function Zhao, Gang
2014-04-25 15:30 ` Johannes Berg
2014-04-21 4:53 ` [PATCH 05/12] mac80211: remove unnecessary BUG_ON() Zhao, Gang
2014-04-25 15:31 ` Johannes Berg
2014-04-26 1:44 ` Zhao, Gang
2014-04-21 4:53 ` [PATCH 06/12] cfg80211: some workqueue improvements Zhao, Gang
2014-04-22 14:50 ` Johannes Berg
2014-04-21 4:53 ` [PATCH 07/12] cfg80211: change pointer name Zhao, Gang
2014-04-25 15:32 ` Johannes Berg
2014-04-21 4:53 ` [PATCH 08/12] cfg80211: change function name Zhao, Gang
2014-04-25 15:33 ` Johannes Berg
2014-04-21 4:53 ` [PATCH 09/12] cfg80211: change return value of notifier function Zhao, Gang
2014-04-25 15:34 ` Johannes Berg
2014-04-21 4:53 ` [PATCH 10/12] mac80211: " Zhao, Gang
2014-04-25 15:34 ` Johannes Berg
2014-04-21 4:53 ` [PATCH 11/12] cfg80211/mac80211: rename cfg80211_chandef_dfs_required() Zhao, Gang
2014-04-22 14:53 ` Johannes Berg
2014-04-21 4:53 ` [PATCH 12/12] cfg80211/mac80211: change variable name Zhao, Gang
2014-04-22 14:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3agjxky.fsf@gmail.com \
--to=gamerh2o@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.