From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAy6w-0003V4-Oo for qemu-devel@nongnu.org; Wed, 05 Feb 2014 03:45:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAy6r-0006wM-Is for qemu-devel@nongnu.org; Wed, 05 Feb 2014 03:45:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAy6r-0006wF-96 for qemu-devel@nongnu.org; Wed, 05 Feb 2014 03:45:29 -0500 From: Markus Armbruster References: <1387503694-11203-1-git-send-email-agraf@suse.de> <87lhzelc2k.fsf@blackfin.pond.sub.org> <52B6EC8F.8080107@redhat.com> <87k3ebddw0.fsf@blackfin.pond.sub.org> <52CC3275.9010502@redhat.com> <87sisyc2m3.fsf@blackfin.pond.sub.org> <52CD553D.3050207@suse.de> <52CD56F9.9020800@redhat.com> <87mwj443zu.fsf@blackfin.pond.sub.org> <87y51rut06.fsf@blackfin.pond.sub.org> Date: Wed, 05 Feb 2014 09:45:22 +0100 In-Reply-To: (Peter Crosthwaite's message of "Wed, 5 Feb 2014 15:19:24 +1000") Message-ID: <87k3dadk2l.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: QEMU Developers , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= , Anthony Liguori , Alexander Graf Peter Crosthwaite writes: > On Tue, Feb 4, 2014 at 7:28 PM, Markus Armbruster wro= te: >> Markus Armbruster writes: >> >>> Peter Crosthwaite writes: >>> >>>> On Wed, Jan 8, 2014 at 11:47 PM, Paolo Bonzini w= rote: >>>>> Il 08/01/2014 14:40, Andreas F=C3=A4rber ha scritto: >>>>>> > Either you fix "info qtree" to cope with your change to the device >>>>>> > graph, or the change needs to be reverted until somebody fixes it = or it >>>>>> > goes away. >>>>>> Sharing a backtrace would be a start, rather than just throwing arou= nd >>>>>> the word "crash" to justify reverting patches. :) >>>>> >>>>> I mentioned the root cause in the previous message: a Device cannot be >>>>> added to main_system_bus, but that's what the patch does. The fix is= n't >>>>> trivial, because most of the affected board are not even qdevified. >>>>> >>>> >>>> So I made progress here with the needed QOMification. Finally I have a >>>> sane info qtree WRT NAND: >>>> >>>> $ arm-softmmu/qemu-system-arm -M spitz -nographic -S >>>> (qemu) info qtree >>>> bus: main-system-bus >>>> type System >>>> ... >>>> dev: sl-nand, id "" >>>> manf_id =3D 236 >>>> chip_id =3D 115 >>>> irq 0 >>>> mmio 000000000c000000/0000000000000040 >>>> bus: nand >>>> type nand-bus >>>> dev: nand, id "" >>>> manufacturer_id =3D 236 >>>> chip_id =3D 115 >>>> drive =3D >>>> >>>> With just the proposed revert info qtree does work again, but is bogus: >>>> >>>> (qemu) info qtree >>>> bus: main-system-bus >>>> type System >>>> ... >>>> dev: nand, id "" >>>> manufacturer_id =3D 236 >>>> chip_id =3D 115 >>>> drive =3D >>>> irq 0 >>>> dev: sl-nand, id "" >>>> manf_id =3D 236 >>>> chip_id =3D 115 >>>> irq 0 >>>> mmio 000000000c000000/0000000000000040 >>> >>> Progress! >>> >>>> Patches sometime next week hopefully. >>> >>> I think we can wait that long :) >> >> I just ran into the info qtree crash again, and I can't find your fix >> right now. Got a pointer for me? >> > > Hi Markus, > > That series got very big on me with complications. I think near term > we just proceed with the revert. Sorry for the delay. > > For a straight revert of my patch nand s/SYSBUS/DEVICE patch: > > Acked-by: Peter Crosthwaite Done. Thanks!